lazemss/octoprint-uicustomizerthemes

UICustomizer Themes

octoprint-uicustomizerthemes's Issues

[BUG] striped-table class not working in the settings menu.

The class for striped tables seems not to work in the settings dialog:


The css rule for table-striped gets overwritten with the rule:

#settings_dialog_content .table td {
  background-color: #2f3136;
  border-top: none;
} 

I played a little around with it and as it comes before the other rules in the file it seems it is because that the rule with an id selector has priority.

Done a PR for it.
It is adding the selectors for the striped-table class where the div with the id "#settings_dialog_content" is a parent.
I also moved the rule for it before the hover rule.
This worked for me.

bootstrap well not accounted for

Not sure if it's all the themes as I haven't tested yet, but with red night the well is not styled.

Temperature control sizing issues

Small one, but one that has been catching my eye:

While I'm not personally a fan of the tiny temperature controls, I don't mind them being there. It is the wonky sizing with the appends and dropdowns that is annoying. Not all appends, just the ones in the temperature graph.

I can add a full list of themes tested tomorrow, but I see this on most:

• Flatly
• Cyborg
• some others I can't remember

1.6.0 compatibility

Sorry, but this made the UI for plugin manager so much better...

Need to add a style for #settings_plugin_pluginmanager_navbar's background colour for each theme, that is all.

Where do you want it in the CSS file? I can probably do it via PR, just need to take a poke at if there is any structure there.

I'll try and avoid doing this again in a contribution to OctoPrint 🙂