lcsmuller/json-build

Tiny, zero-allocation JSON serializer written in ANSI C

Hello, I am Müller!

A backend engineer at @profusion, and a hobbyist C developer at @Cogmasters!

json-build's Issues

Compilation error with GCC 10.2.1 (embedded)

GCC version 10.2.1
The _jsonb_escape function returns a log, but this is assigned to a jsonbcode eum value in the calling routines.
It isn't always possible to add a compilation flag to allow this, as the compiler error suggests:

json-build/json-build.h:406:28: error: invalid conversion from 'long int' to 'jsonbcode' [-fpermissive]

  406 |         ret = _jsonb_escape(&pos, buf + b->pos, bufsize - b->pos, key, len);
      |               ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                            |
      |                            long int

possible memory leak when calling _jsonb_escape

Hi!

We are using your amazing library and found a potential mem leak. I'm not sure the patch we prepared to solve it is good though:

pantacor#2

Seems like _jsonb_escape was using the complete bufsize but buf was passed as buf + b->pos. So could _jsonb_escape be writing beyond the limits of buf?

To give some context, we are allocating an initial buffer that we resize if any of the build functions return JSONB_ERROR_NOMEM.

question about jsonb_init()

Hello,

I could not find a better way to ask a question about some implementation details in jsonb_init(), from jason-build.
What is the purpose of the following code:
void
jsonb_init(jsonb *b)
{
static jsonb empty_builder;
*b = empty_builder;
....

Thanks in advance.
Volodimir