The bav4 from ldbv-by

use simulateMouseEvent function from mapTestUtils

also in OlMeasurementHandler.test.js

Layer Manager...

should update the name of a layer when label property changed ( observes changes on layer.label)

Checkbox visually not always in sync

with the "checked" attribute of the underlying input field.

Missing i18n in header

Tab buttons need i18n also for title attributes

Flacky DndImportPanel tests

reproducible by running all tests e.g. npm run test --browsers=FirefoxHeadless

 An error was thrown in afterAll
  Expected EventLike({ _payload: Object({ content: 'dndImport_import_no_file_found', level: Symbol(warn) }), _id: 1379875718204 }) to be undefined.
  <Jasmine>
  ./test/modules/dndImport/components/DndImportPanel.test.js/</</</</<@/tmp/_karma_webpack_727583/commons.js:233703:52

Finetune topics layout

The i-Symbol in the information-Button is partially hidden.

Originally posted by @thiloSchlemmer in #265 (comment)

ToolContainer: _deactivateByContentId

... is not covered by a test in case MeasureToolContent

consequently use EnvironmentService#getUrlParams for retrieving URL parameters

Not closing Polygon

While digitizing a measurement-polygon, the snap&click on the first point (to automaticly finish) seems not be acknowlegded and results in a Linestring-geometry.

OlFeatureInfoHandler tests are flaky

split SearchResult class into sub classes


/**
 * @enum
 */
 export const SearchResultTypes = Object.freeze({
	LOCATION: Symbol.for('location'),
	GEORESOURCE: Symbol.for('georesource'),
	CADASTRAL_PARCEL: Symbol.for('cadastral_parcel')
});

/**
 * Represents a single search result.
 * @class
 * @abstract
 * @author taulinger
 */
export class SearchResult {

	constructor(id, label, labelFormated) {
		this._id = id;
		this._label = label;
		this._labelFormated = labelFormated;
	}

	get id() {
		return this._id;
	}

	get label() {
		return this._label;
	}

	get labelFormated() {
		return this._labelFormated;
	}

	/**
	 * @abstract
	 */
	getType() {
		// The child has not implemented this method.
		throw new TypeError('Please implement abstract method #getType or do not call super.getType from child.');
	}

}

export class LocationSearchResult extends SearchResult {

	constructor(id, label, labelFormated, center = null, extent = null) {
		super(id, label, labelFormated);
		this._center = center;
		this._extent = extent;
	}

	get center() {
		return this._center;
	}

	get extent() {
		return this._extent;
	}

	getType() {
		return SearchResultTypes.LOCATION;
	}
}
export class CadastralParcelSearchResult extends SearchResult {

	constructor(id, label, labelFormated, center = null, extent = null) {
		super(id, label, labelFormated);
		this._center = center;
		this._extent = extent;
	}

	get center() {
		return this._center;
	}

	get extent() {
		return this._extent;
	}

	getType() {
		return SearchResultTypes.CADASTRAL_PARCEL;
	}

}

export class GeoResourceSearchResult extends SearchResult {

	constructor(id, layerId, label, labelFormated) {
		super(id, label, labelFormated);
		this._layerId = layerId;
	}

	get layerId() {
		return this._layerId;
	}

	getType() {
		return SearchResultTypes.GEORESOURCE;
	}
}

import.action does not set unused field to null

Layerservice does not deactivate fetching state, after loading vector georesource

While using the VectorImportService to load Vectordata from an URL as Georesource, the resulting ol.VectorSource does not fire
the 'featuresloadend'-Event. This prevents the Layerservice, to call setFetching(false).

Wrong direction of animation (flickering)

When closing the main menu in portrait mode, the animation moves the main menu downward at the beginning.

remove obsolete loader mechanism from VectorGeoResource

obsolete since we're having the type GeoResourceFuture

Window resize triggers unindended call of removeLayer()

when Browser-window is resized, ToolContent.js triggers the removing of the current stored ToolContentId without checking, if ToolContent is open.

Flaky test(s) in OlMeasurementHandler.test.js

absoluteOlMeasurementHandler.test.1703910062.js OlMeasurementHandler when activated over olMap looks for measurement-layer and adds the feature for copy on save FAILED
[INFO] 	Expected null to equal Object({ adminId: null, fileId: 'f_lastId' }).

karma-webkit-launcher does not close browser

... after tests are run. On the next run, test execution is confused.

Detect running Webkit instances:
ps -ef | grep webkit

Possible workarounds:

kill Webkit manually after each test run with something like pkill -f "webkit"
or
run tests only with FF and Chrome npm run test --browsers=FirefoxHeadless,ChromeHeadless

Missing SHORTENING_SERVICE_URL parameter

throws error.
Should just log a warning.

cleanup olMap package

Measurement: Labeling seems not to be working always correctly

Url: http://localhost:8080/?c=677751,5422939&z=8.096&l=atkis,f_a082ae30-d8d3-11eb-8f9a-f7a30b4874ed_57501125-123a-433a-9fba-abef14d2f108&t=ba

measurement tool does nothing after closing and re-opening the tool

open the tool
create a measurement on the map
close the tool
open the tool
try to create a second measurement

Move all store related files from modules dir to global store dir

Modules are not allowed to contain a /store sub-folder anymore.

Fix drag&drop in LayerManager

the capability to drag&drop a layer to reorder the layer-list isn't working anymore.
A DraggedItem (Layer) finds no space where dropping is allowed. This is only allowed on placeholder-elements, which obviously have no space.

Adding a padding: 2px would fix the issue.

Toogle.js does not work on Chrome and Webkit

header layout

The coat of arms overlaps the toolbox-content, but the opposite should be true.

remove background property of GeoResource

background GeoResources are defined within a topic definition

Draw-Interaction still active after abort&close DrawTool

if the user opens the DrawTool, activates one of the DrawTypes (Symbol,Text, Line,Polygon) and immediatly closes the DrawTool,
the selected DrawType (OpenLayers Draw-Interaction) is still active (the corresponding drawStyle is rendered).

fix geoResource typos

Drag & Drop seems not to work within Webkit

Can be reproduced with npm run test:single --spec=LayerManager.test.js --browser=WebkitHeadless

(#386 should be merged first)

Incorrect layer label

After loading a measurement geometry from the backend, the created layer is labeled with a fallback name but should retrieve its label from the KML file.

translation is missing

No value found for de.toolbox_toolbar_measure_button TranslationService.js:59
No value found for de.toolbox_toolbar_draw_button TranslationService.js:59
No value found for de.toolbox_toolbar_share_button TranslationService.js:59

baselayer switcher removes layer even when it has an index > 0

When selecting a base layer, an existing base layer should be removed only when it has an index of 0

OlHighlightLayerHandler prevents click events on map

Active LayerHandler should not disable click events on the map automatically.

Fix flaky test

npm script "start" failed after update of webpack

Due to changes in config of Webpack-dev-server the npm script "start" fails with

Webpack Dev Server Invalid Options-Error.

Removing of the 'static'-option in webpack.config.js solves the problem.
devServer: { // static: './dist', port: port }

see Webpack-Dev-Server #1501

ContextMenu must display WGS84 coordinates rounded by 5 decimal places

Modal: Event handler bindings are broken

Reason: Cutting off a Node from one place of the DOM and moving it to the Modal seems to destroy event handler bindings of nested components

measurement toolbox does not always show correct length

Misorder of geographic point locations

According to https://en.wikipedia.org/wiki/ISO_6709 the correct order of coordinates for human interfaces is latitude, longitude.

Affects:

CoordinateSelect
MapContextMenuContent

A simple [x,y].reverse() before calling coordinateService.stringify() should do it.

Flickering Overlay on Measurement-Geometry

if a measure-feature is drawn, the first partition-overlay (e.g. 100m) is flicker and switches between tow states (0.1km <> 100m), while moving the pointer over the map