1.20.1 - ``blockui-1.20.1-1.0.115-BETA.jar`` has a bug which cases ``mass lag in larger packs`` when browsing ``recipes of min stock`` SMP

[ldtteam]

1.20.1 - ``blockui-1.20.1-1.0.115-BETA.jar`` has a bug which cases ``mass lag in larger packs`` when browsing ``recipes of min stock`` SMP

[Thodor12]

It's not necessarily a "cache", a scrolling list used to only initialize the items in the view as soon as they were "in view".
That was removed in favor for allowing dynamic element sizing, which would void that logic.

So I guess we're going to have revert that.

[Raycoms]

We probably want to revert it first. And then we will have time to slowly think how we can do this more dynamically on a "need to know basis"

[Raycoms]

@Nightenom we got several of those reports with the newer blockui versions

[Thodor12]

This could potentially be due to a change I made to scrolling lists, where all items are instantiated at the start in order to allow for dynamic element size.

However I'm pretty sure the min stock list is supposed to be empty at the start.

[P3rf3ctXZer0]

This could potentially be due to a change I made to scrolling lists, where all items are instantiated at the start in order to allow for dynamic element size.

However I'm pretty sure the min stock list is supposed to be empty at the start.

It is empty. Clicking add triggers the bug or did you mean the search list ... if you mean the search list no it seems to list things numerical to alphabetical in ingredients list. Example my pack as 44 ammo so that is always on top.

[Thodor12]

Yeah then this is probably due to the fact that min stock renders every single possible item in the game.
So on open it's stuck making potentially thousands of items before it can show.

[P3rf3ctXZer0]

So my theory of it is re-caching everything on open is not far off? Who knows maybe I will be a coder yet :)

[P3rf3ctXZer0]

What about modifying the system to use pages so you limit spawn of things in beginning to 40 items and then all other things are indexed in 40 slot pages like a book. That way regardless to ui you could still allow dynamic ui window resizing? If people need to fast lookup they can use search function.

In another theory why not allow item lookup through JEI when present? That way they can change things and you can offload the heavy lifting to JEI/REI/EMI

[uecasm]

List virtualization is tricky, especially if you want to be able to randomly scroll to the end of the list without loading anything in the middle. It's much much simplified if all items are fixed size.

Possibly related: I've noticed (prior to these changes) that when using the Replace list in the scan tool, quickly scrolling all the way to the end, then clicking on a block select button, results in selecting the wrong block. Clicking on the "same" button selects a new wrong block each time, until it eventually "catches up" and selects the correct block.