Giter Site home page Giter Site logo

blockui's Introduction

BlockUI

An XML based UI management system for minecraft. Defines the structure for the UI inside an XML while providing a backing "Window" class that is used to handle callbacks and data supply.

blockui's People

Contributors

marchermans avatar nightenom avatar raycoms avatar theanaxman avatar thodor12 avatar uecasm avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

blockui's Issues

1.20.1 - ``blockui-1.20.1-1.0.115-BETA.jar`` has a bug which cases ``mass lag in larger packs`` when browsing ``recipes of min stock`` SMP

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest Structurize Version?

  • I am running the latest alpha version of Structurize for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies/Structurize Wiki or I asked on discord.

Minecraft Version

1.20

Structurize Version

structurize-1.20.1-1.0.659-BETA.jar

MineColonies Version (if related bug)

minecolonies-1.20.1-1.1.303-BETA.jar

Related Mods and their Versions

blockui-1.20.1-1.0.115-BETA.jar
Requires a large modpack such as ATM9 or Fiction Friction Pixelated Monsters. Otherwise the spike is not very big.

Current Behavior

When browsing to set stock recipes etc at a station there is a massive client side lag spike that spans between 55-65 seconds. (Note the server keeps running as normal thus my comment directly calling out clientside.) After the spike ends all the villagers talk at once. ... In testing it does not affect anyone else on server just the person messing in UI.

Expected Behavior

No time freeze lag spike.

Reproduction Steps

Update Block UI to required version in large modpack. Click on a any station stock min wait forever.

Logs

https://gist.github.com/P3rf3ctXZer0/7f7ddc4df77a7e7d3ee5e9c33137be8b and https://gist.github.com/P3rf3ctXZer0/dc96c354006fd1d2ebde1890315e34fa

Anything else?

The bug does not exist in blockui-1.20.1-0.0.103-ALPHA.jar

Footer


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

Crash when opening recipe book with minecolonies loaded

Minecraft version 1.17
Using Minecolonies 1.0.27-Alpha (and confirmed with minecolonies 1.0.56)
Using Block-UI 0.0.26-Alpha
Using Forge 1.0.85

In forge 1.0.85, tooltips changed. From this forge version onwards, minecraft crashes when the recipe book is opened and you have a build tool and wooden planks in your inventory, and just minecolonies and its dependencies are loaded.

Crash log: https://gist.github.com/MotionlessTrain/9d1bf7be909dd8f2ab095b869c8f5223

By removing mods, it turned out this didn't happen with just the dependency mods loaded. When minecolonies was added as well, it started to crash.

I asked Ray on stream where I should post the crash log, and he pointed me to here.

Nested elements

Macro project - requires splitting current logic to publicly immutable yet library mutable classes, also XML support - sth like fixed object id, or special I'd like nestedId

Tabs: ldtteam/Structurize#392, backing view + tabs element
Scroll things: #5, backing view + scrollbar(s) + background renderable element
Buttons, text fields - background renderable elem. + text

Allow Config to change the width/height of the UI (not zooming)

I would like a feature request like JEI has where you can specify make UI larger by width or height, so you can reduce the amount of scroll bars. And make it look slimmer, like on attached picture the buttons would move to the right hand side when this was made wide enough. And would liek to make it longer to easily see more.

Related to MineColonies, Domom (what eer that mod is called)

Same with the postbox, Architechs cutter

image

Add mechanism for overlay rendering

Similar to what is done using forge extensions, but:

  • steal rendering pipeline so we can use blockui elements
  • make it configurable by players and save such settings into our client folder

Images be broken

Updating to the latest 0.0.16 breaks most .setImage cases in MineColonies, where it repeats the images instead of streatching it.

[bug] Project MMO Cannot Detect Interface is Active

Describe the bug
Block-picking interfaces in huts are having an interaction with Project MMO.

Trying to type into the (for example) Minimum Stock text field, and starting the string with a P, opens the Project MMO interface.

This seems to be a case of PMMO needing to action its interface whenever there is a tooltip visible and those specific interfaces having tooltips.

image

Expected behavior
Pressing the interface key for PMMO should not cause it to come up.

To Reproduce
Steps to reproduce the behavior:

  1. Open builder hut interface
  2. Select Minimum Stock and click Add
  3. In the provided text box, try to type Pickaxe
  4. The Project MMO interface will pop up

Versions:
Minecraft: 1.20.1
Forge: 47.1.0
BlockUI: 1.20.1-0.0.84
Domum Ornamentum: 1.20.1-1.0.104
Multipiston: 1.20.1-1.2.31
Minecolonies: 1.20.1-1.1.9
Project MMO: 1.20.1-1.0.2

Additional context
Additional information from the PMMO mod developer: Caltinor/Project-MMO-2.0#324

[1.16.5] Minor Hut GUI issue with tooltips

Prerequisites

  • [x ] I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • [x ] I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • [x ] I made sure that this issue is not a duplicate of any existing issue.

Context

Expected behavior

Not drawing over tooltips

Actual behavior

The numbers for recipes (ingredients and results) are drawing over top of tooltips in the Hut GUI. Near as I can tell this is occurring with all huts that can have recipes.

2022-02-15_01 11 03

Editing to add: I am now noticing this appears to occur on all GUIs anytime there is a number shown next to an item, such as the clipboard, visitor recruitment windows, minimum stock screen, etc.

Steps to reproduce the issue

  1. Open Hut GUI
  2. View recipes
  3. Profit?

Logs

  • latest.log: N/A
  • crashlog: N/A

Notes


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

[BUG] When removing yourself or someone else from the permissions tab crashes the client

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Version?

  • I am running the latest beta version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20.1

MineColonies Version

1.1.601-BETA

Structurize Version

1.0.738-BETA

Related Mods and their Versions

Forge 47.2.23

Current Behavior

If you try to remove yourself by hitting the X (or someone) it has a high chance of crashing your client. Does not happen every single time. Also, you can't add custom roles or hostile to other players, you can add neutral, officer and friend though.

Expected Behavior

Should allow to remove people without crashing and should be able to add other permission roles to other players apart from the first 3.

Reproduction Steps

  1. Make a colony in multiplayer

  2. Add someone as officer

  3. Remove it -> Crash or success

  4. Make a colony in multiplayer

  5. Make a new custom role

  6. Try to add someone and fails, try to add Hostile and fails too (Which is built-in)

Logs

https://mclo.gs/X3H9TTW

Anything else?

The crashlog is a local log, the server doesn't log anything when any of this happens. Seems to be a bug on BlockUI. Happens in our modpack and on a clean installation. This is the version 601-BETA, not the newest, haven't tested if it happens on newer versions.

BlockPixel Resource pack causes: java.lang.RuntimeException: Can't parse xml at: minecolonies:gui/citizen/windowinteraction.xml when interacting with MineColonies entities

BlockUI version: blockui-1.20.1-1.0.125-BETA
Any MineColonies version for 1.20.1, though repro'ed in minecolonies-1.20.1-1.1.333-BETA
BlockPixel version: BlockPixel-JavaEdition_13

Disclaimer: Ray told me to post this bug in BlockUI as I couldn't find a place to file it for BlockPixel in hopes you could figure out what's going on.

Issue: When I try to interact with a citizen, the game crashes and I get the following error:

The game crashed whilst unexpected error
Error: java.lang.RuntimeException: Can't parse xml at: minecolonies:gui/citizen/windowinteraction.xml

Exit Code: 255

This also occurs if I try to use the clipboard, or access the Tasks tab in a hut block.

Steps to reproduce:

  1. Install MineColonies 1.20.1, most recent version. Install the BlockPixel resource pack and activate it in the Resource Pack menu of Minecraft.
  2. Create a new world and colony and allow citizens to spawn.
  3. Right click a citizen to interact with them.

Expected: The Citizen's UI appears and you can interact with that.

Actual Result: The game freezes, then crashes to desktop with the above error message.

Crash Log:
https://gist.github.com/kedamono/e495a7917409da07f449f70f50e0d93d
Latest Log:
https://gist.github.com/kedamono/e5b60d62702ac4390a05841009a4c776[
](https://gist.github.com/kedamono/e5b60d62702ac4390a05841009a4c776)

Container is empty and can't scroll through my hotbar

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.17.1
  • MineColonies Version: 1.17.1-1.0.43-ALPHA
  • Structurize Version: 1.17.1-0.13.253-ALPHA
  • Related Mods and their Versions:
  • Domum Ornamentum Version: 1.17.1-1.0.10-ALPHA
  • Block UI/ UI Library Mod Version: 1.17.1-0.0.26-ALPHA
  • Multi-Piston Version: 1.17.1-1.2.1-ALPHA

Expected behavior

I would be able to look at a chest or other container and scroll through my Hotbar at the same time.

Actual behavior

When I look at a chest or other container just right a message appears over it saying "This Container is Empty" and while looking at the chest while within interacting distance I am unable to scroll through my Hotbar. If the container has things in it, the message doesn't appear and when I look at the chest and/or crouch while looking at the chest a message in chat states "OpenGL Error: 1281 (Invalid value).

2021-10-13_20 29 56
2021-10-13_21 22 16

Steps to reproduce the issue

  1. Create a New World.
  2. Place a Chest or other container.
  3. Look at the container while within interaction distance and try to scroll through your hotbar.

Logs

Notes

Ignore the other mods, I recreated the issue with only Minecolonies and its dependencies installed.

Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

Tip mechanism

add tip mechanism:

  • xml argument tip_delay::int_gte_zero - if (not zero) then hide x ticks after open/tip show button pressed
  • renders in highest layer, above tooltips
  • has X button to close earlier
  • has xml_res_loc based settings to permanently hide for given window

Box color ignored due to missing alpha

Tested in 1.18 only for the moment. Using 0.0.34-ALPHA, which is the current default for Structurize (though updating to .42 doesn't seem to help).

A box such as:

<box size="100 50" color="white" linewidth="1">...</box>

does not result in actually drawing anything. This is because Color.getByName returns an RGB value, not an RGBA value, so the alpha component is 0 and the box is transparent (or actually not drawn at all, since UiRenderMacros.drawLineRect opts out if alpha is 0).

Theoretically, then, using color="#ffffffff" should work -- except that causes a crash due to java.lang.NumberFormatException: For input string: "#ffffffff" under radix 16 because it's not actually stripping off the leading # like the code seems to think it is.

Using color="rgb(255,255,255)" does work, as does color="4294967295". (Is there documentation for any of this anywhere?)

And is the only way to have a non-transparent background color to use an image background? I couldn't find any background color properties...

Drag and Drop editing

Would be nice if we had the ability to drag n drop UI elements ingame, and get their coords for the XML file after/or even edit the xml file its from? To make placement in dev much easier, could enable the mode with a hotkey or so

[BUG] Custom style packs with icons crash

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Verison?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

Minecraft Version

1.19

MineColonies Version

1.0.988-ALPHA

Structurize Version

1.0.437-ALPHA

Related Mods and their Versions

Forge: 43.1.1
BlockUI: 0.0.60-ALPHA
Domum Ornamentum: 1.0.59-ALPHA-universal
Multi-Piston: 1.2.16-ALPHA

Current Behavior

I am currently developing the Antique style pack and transitioned my style to the new build tool.
I changed my pack.json's icon (among other properties, such as the description and required mods list).
Now, whenever I try to change my build tool's style pack and scroll down to where my style would (supposedly) be, the game crashes.
Removing the custom icon fixes the issue.
I have also heard that the Cavern style currently faces the same issues, so I assume this is the case for all custom style packs.

Expected Behavior

Not to crash, and show the pack (including the icon) as you would expect.

Reproduction Steps

  1. Build something and scan it.
  2. Close your game. (Might not be necessary, but I did it in both cases I encountered this bug.)
  3. In your newly-created player style pack in the blueprints folder, in pack.json, set the icon to an image of your choosing (located in the same folder).
  4. Start the game and enter your world.
  5. Open the build tool UI.
  6. Click on Switch Pack and scroll down to your player-specific style pack. (I'd guess that if it crashes immediately, the pack already shows up at the top, I haven't encountered this myself though.)
  7. Observe how the game crashes.

Logs

https://gist.github.com/IchHabeHunger54/509f37ce2c19e911635d7286a5fc6468

Anything else?

The issue appears to be caused by the game loading the image path as a resource location instead of a path (as I highly doubt that the structurize: prefix is supposed to be there).

[BUG] Forester settings crash

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Version?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20.1

MineColonies Version

1.20.1-1.1.240-RELEASE

Structurize Version

1.20.1-1.0.653-BETA

Related Mods and their Versions

blockui-1.20.1-0.0.97-ALPHA

Current Behavior

Opening settings in forester hut crashes the game. Downgrading BlockUI to blockui-1.20.1-0.0.94-ALPHA fixes it for now.

Expected Behavior

Game does not crash.

Reproduction Steps

  1. Open UI of forester hut
  2. Click on gear icon

Logs

https://gist.github.com/janisl/23f7a2a24dfac8c7356270ed00ca4def

Anything else?

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

In text item icons

As the title says. There should be a way to do: Give me one <itemicon> please. Instead of having to do complicated hide/show logic.

Rework Scrollable elements

Lower the count of class for scrollable elements
Add mechanism for derived elements (scrollbar, dropdown, ...)
Merge tabs from structurize
Backport?

Dropdowns that exit UIs don't work

If you have a dropdown at the bottom of a UI and on opening it extends outside of the parent, it is not clickable anymore (on the outside area at least)

Support "empty texts" in scrolling lists

When a list has no items in it, you usually have some supporting text stating "This list is empty" to have at least something present on your screen.

Could the scrolling list support an emptytext attribute that works similar to any text source.
When the data provider of the list has no items in it, it will render a single text element with the given emptytext, when there are items in the data provider, the items are rendered instead.

Combine box, gradient and image elements

Image standalone? But they are all logicless
Four colour vertices for box and BG
Box thickness and offset
Single colour is fill mode
Possible image as bg?
Two types - view and element?

[BUG] [1.19.2] Client Crash to Desktop

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Version?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.19.2

MineColonies Version

1.19.2-1.1.244-BETA

Structurize Version

1.19.2-1.0.649-BETA

Related Mods and their Versions

Forge: 43.2.21
BlockUI: 1.19.2-0.0.96-ALPHA
DO: 1.19-1.0.137-BETA-universal

Current Behavior

Client crashed to desktop when clicking on the settings tab of the Farmer's hut GUI.

Expected Behavior

No crash.

Reproduction Steps

Self explanatory.

Logs

https://gist.github.com/Sandriell/ed1547eec1dad5ba56c68c97e40c5dce

Anything else?

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

[BUG] Wonky Entity Shadows

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Version?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.19.2

MineColonies Version

1.19.2-1.1.266-BETA

Structurize Version

1.19.2-1.0.661-RELEASE

Related Mods and their Versions

Minecraft 1.19.2
Forge 43.3.2
Domum Ornamentum 1.19-1.0.143-BETA
Multi-Piston 1.19.2-1.2.25-ALPHA
BlockUI 1.19.2-0.0.99-ALPHA

Current Behavior

Entity Shadows get wonky over time or opening some menus.
grafik

Expected Behavior

Entity Shadows staying the same

Reproduction Steps

  1. Generate World (i used Creative Superflat)
  2. Start Colonie
  3. Place Builder
  4. Wait for Builder to Request something from Player
  5. Open Builders Request Menu or Clipboard
  6. Shadows are messed up

Logs

https://pastebin.com/ux0yGSSk

Anything else?

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

Manual in-game resizing

Addendum to #90
Should be on xml resLoc + modid basis
Allow for all UIs:

  • override gui-scale additively, eg. vanilla settings is 2x, but user would like to have 4x

Allow for single primary resizable element:

  • override gui size additively, eg. xml size is 320x240, but user would like to have 320x480
  • override gui size anchor, ie. xml size (now) or screen size (fullscreen window type without scaling) - effectively enabling UI to follow screen resolution
  • should be automatic or UIs having only one resizable element at root view (list or zoomdrag only?)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.