leandrolcampos/dcn-v2

Implementation of DCN V2: improved Deep & Cross Network.

dcn-v2's Issues

Implementation different from the origin paper

Based on the original paper, I think the cross-network part should be like:

x_cross = cross_layer(x_in, x_cross)

dcn-v2/model.py

Lines 120 to 140 in 2d0f072

	if self._model_structure == 'stacked':
	x_cross = x_in
	for cross_layer in self._cross_layers:
	x_cross = cross_layer(x_cross)
	x_deep = x_cross
	for deep_layer in self._deep_layers:
	x_deep = deep_layer(x_deep)
	x_out = x_deep
	else:
	x_cross = x_in
	for cross_layer in self._cross_layers:
	x_cross = cross_layer(x_cross)
	x_deep = x_in
	for deep_layer in self._deep_layers:
	x_deep = deep_layer(x_deep)
	x_out = tf.concat([x_cross, x_deep], axis=1)