learn-co-curriculum/insertion-sort

insertion-sort's Issues

Selection sort vs insertion sort

Hi, I think the title to this lesson should be "Selection Sort" instead of "Insertion Sort" - the algorithm described is actually selection sort, not insertion sort, which is significant because the runtime will not be O(n) for an already sorted array using the described method. Also, the code examples in the lesson name the function selection sort. Thanks!

Typos / Formatting Issues

While working through the Insertion-Sort readme lesson, I found that there is a typo in the first code block as well as a formatting issue with the picture and the text.

I'm guessing the array just needs a comma after the 6.
What is there Now:
let unsortedArray = [5, 6 -1, 1, 3]

Fixed missing comma:
let unsortedArray = [5, 6, -1, 1, 3]

Unused variable...

Hi. Small thing -- a few times in the sample code throughout the lesson, currentElement is declared but not used. Just wanted to avoid confusion for future readers. Thanks!

The title of the readme is insertion sort but the content is selection sort

I think this may be incorrectly named.

Minor correct of variable

Throughout the lesson the unsortedArray needs to be corrected to add a comma between the 6 and -1 to ensure proper differentiation between elements. It should look as follows:

let unsortedArray = [5, 6, -1, 1, 3]

Selection sort but titled insertion sort

The cover image, which depicts a card game, does show insertion sort, but all subsequent code-along is selection sort.