learn-co-curriculum/intro-to-capybara

intro-to-capybara's Issues

There is an instruction to fork and clone this readme

"Now that our test suite is setup to use Capybara, let's start writing some tests for our application. Everything is already built and included with this lesson if you fork and clone it or you can rebuild it on your own by copying the code into the files."

But lesson is a readme and can't currently be opened with the learn button. Unclear if users will remember the git workflow at this point to get it done on their own

Anyone want to review?

@AnnJohn

It's long but I love it.

tests

It seems like this is forked with the corrected code already included. Tests are supposed to fail but pass.

No Gemfile, and rspec not done

It says in the lesson "All of the code we will review below is already present in this repo. You can fork and clone this repo to take a closer look, or you can rebuild this simple app on your own as we review it together, below.". Couldn't bundle install due to no gemfile present. Also the rspec for "application_integration_spec.rb" wasn't completed(which i would of added the code myself, but i'm not sure which gems you wanted installed which was the main issue).

Raises a Gem::ConflictError from the start

This lesson raises a Gem::Conflict error from the start so am unable to actually proceed with the lesson....beginning of error message is below

usr/local/rvm/rubies/ruby-2.3.0/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:2288:in raise_if_co
nflicts': Unable to activate sinatra-1.4.7, because rack-2.0.1 conflicts with rack (~> 1.5) (Gem::Confli
ctError)   `

The 2nd test in the lesson passed w/o any editing

Is this the way it should be:

The lesson says that after we edit the spec/application_integration_spec.rb file, there should be 2 errors with one passing. I had no errors--turned out my spec/application_integration_spec.rb file has the exact same text as the lesson.

The README and application_integration_spec.rb aren't in sync

Since this is a code-along lab, the instructions in the readme file refer to steps that are already taken in the application_integration_spec.rb file when it is forked. This caused some confusion and also makes most of the first portion of the readme not make much sense because it tells you what errors you should see and you are seeing different errors. Someone should go back and remove most of the code from application_integration_spec.rb so it only includes the first section so the user sees the errors as they progress through the readme and correct them.

I forked the lab into the learnIDE

Forked the lab into the learnIDE and finished it yet it still shows that I haven't forked it. I'll be moving on but I just wanted to raise the issue.

config.ru instructions should be shown sooner

Without the

require 'sinatra'
require_relative './app'

run Application

code in config.ru the learn command does not run. A rack error is shown.

/Users/myname/.rvm/gems/ruby-2.3.3/gems/rack-1.6.5/lib/rack/builder.rb:146:in `to_app': missing run or map statement (RuntimeError)

This instruction should be moved up in the README

Note should be try using bundle update

On the note we should do "bundle update" and then "bundle install" to see if that fixed the problem first. Followed by the note below.
Note: If you're getting an error about conflicting gems, you may need to run bundle exec rspec (or bundle exec learn). Prepending a command with bundle exec forces your terminal to run the process with the version of the gems specified in the gem file rather than just using the most recent versions on your machine.

Contradictory Infographic

"INTEGRATION TESTS: ...Commonly referred to as 'End-to-End' tests, integration tests should flex your entire application stack (i.e., all of the MVC components) and rarely isolate components or behaviors..."

bundler: failed to load command: rspec (/usr/local/rvm/gems/ruby-2.3.1/bin/rspec)

Running learn or rspec in terminal raises the following error:

bundler: failed to load command: rspec (/usr/local/rvm/gems/ruby-2.3.1/bin/rspec) RuntimeError: missing run or map statement /usr/local/rvm/gems/ruby-2.3.1/gems/rack-1.6.5/lib/rack/builder.rb:146:in to_app'
config.ru:3:in <main>' /usr/local/rvm/gems/ruby-2.3.1/gems/rack-1.6.5/lib/rack/builder.rb:49:in eval'
/usr/local/rvm/gems/ruby-2.3.1/gems/rack-1.6.5/lib/rack/builder.rb:49:in new_from_string' /usr/local/rvm/gems/ruby-2.3.1/gems/rack-1.6.5/lib/rack/builder.rb:40:in parse_file'
/home/hillevieklow/intro-to-capybara-v-000/spec/spec_helper.rb:16:in app' /home/hillevieklow/intro-to-capybara-v-000/spec/spec_helper.rb:20:in <top (required)>'
/usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration.rb:1455:in require' /usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration.rb:1455:in block in requires='
/usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration.rb:1455:in each' /usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration.rb:1455:in requires='
/usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration_options.rb:112:in block in process_ options_into' /usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration_options.rb:111:in each'
/usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration_options.rb:111:in process_options_i nto' /usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/configuration_options.rb:21:in configure'
/usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:99:in setup' /usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:86:in run'
/usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:71:in run' /usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:45:in invoke'
/usr/local/rvm/gems/ruby-2.3.1/gems/rspec-core-3.7.1/exe/rspec:4:in <top (required)>' /usr/local/rvm/gems/ruby-2.3.1/bin/rspec:23:in load'
/usr/local/rvm/gems/ruby-2.3.1/bin/rspec:23:in <top (required)>'

Not tracking Fork or Submit functionality here.

Capybara Tests won't run because of gem conflict.

These are from an open issue on learn-co-students. Ran into this issue with a student today and their steps resolved it.

ran tests after doing the code for the first half of the readme and got the following error:
Unable to activate sinatra-1.4.7,
because rack-2.0.1 conflicts with rack (~> 1.5) (Gem::ConflictError)

I was able to resolve this issue by running 'gem uninstall sinatra' and 'gem uninstall rack' (uninstalled all versions and said yes to every prompt). then, ran bundle install again.

Uninstalling the gems and bundle install fixed it so I assume the gemfile just needs to be updated.

Tests pass without any edits

Lesson is written as a code-along, but requires no editing to pass the tests.