learn-co-curriculum/looping-while-until

looping-while-until's Issues

Not Forking

I solved the lab and the passed the test but the lab didn't fork

Tests passing at beginning

When I run learn on this project the tests pass - correct answers already inside.

new readme and repl

no more repl, now a lab. ready to deploy after 👀

@jmburges @aviflombaum

we never explicitly looked at `.times` before

it was mentioned in passing in earlier curriculum, but we were kind of told to ignore it

"While" is misspelled in the title

"While" is misspelled in the title and navigation

LOOPING - WILE AND UNTIL CONSTRUCTORS

Update from user

User: Garett Arrowood

Batch: 000

Current Lesson: OO Cash Register

Location: https://learn.co/tracks/web-development-with-ruby-on-rails/ruby/looping/looping-while-and-until-constructors?track_id=5309&batch_id=76

Bug Description: In the Until example - Change the original value of counter to 0.

Levitation Charm?

In the "USING WHILE AND UNTIL" it says "Guess what? We're still struggling to master that levitation charm! But we are so close...."

Seems like this lab is referring to a previous example (or I guess "Wingardium Levios" is a levitation charm?). Worth clarifying a bit.

Do we want to introduce or provide links to while and until syntax?

Looks to me like we're asking people to use while and until loops, but in the previous class when we introduced loops we didn't provide either of those syntaxes. Is this a deliberate "time for you to guess/google it", were those syntaxes mentioned earlier in the curriculum and/or is this not a problem because people are getting through it?

Not saying we should change this, but wanted a placeholder so we could have a conversation about it . . .

Error in Looping-While-Until lab

I'm getting an error occurs while loading after hitting "learn"

An error occurred while loading ./spec/until_spec.rb.
Failure/Error: require_relative "../lib/until.rb"

0 examples, 0 failures, 2 errors occurred outside of examples

LOOPING - WILE AND UNTIL CONSTRUCTORS

Couldn't edit the Title here, but the lesson misspelled While as Wile in title.

Message in terminal: You are attempting to open a lesson that is beyond your current lesson. Are you sure you want to continue?

When I attempt to fork the lesson, I get this message in my terminal: "You are attempting to open a lesson that is beyond your current lesson. Are you sure you want to continue?" This is not the case, as I am going in order with the lessons....

this example was never given

Remember our long and repetitiously-counting code that used if statements to count from 0 to 20? Well, we can refactor that into simple, readable, short code with the while construct:

(nope, I don't remember.)

unable to ask a question

Spec description is wrong

while_spec is testing for an output 4X, but instructs students to output it 10X

Lab message

When I clicked the "Open IDE" button and the lab opened, there was a prompt stating I was opening a lesson past the point where I was in the curriculum. I clicked Yes and looked at the ReadMe compared to the website and they were the same lesson.

until.rb has incorrect indentation

4 spaces, gasp!

Actually spec `while` vs `until` usage.

The tests should try to enforce this syntax.

Inconsistent indentation between while.rb and until.rb

until.rb uses eight spaces for its indentation, whereas while.rb uses one tab.

Issue #16 first reported this issue as having four spaces, but commit 32799c8 that supposedly fixes it replaced it with eight spaces instead of one tab like in while.rb.

Ruby convention seems to favor two spaces for indentation. For beginners, the inconsistency can be confusing.