learn-co-curriculum/python-p3-loops

python-p3-loops's Issues

index.js missing JavaScript version of square_integer solution

Canvas Link

https://learning.flatironschool.com/courses/6274/assignments/236172?module_item_id=554041

Concern

The index.js file for this lesson doesn't include a javascript version of the square_integers solution.

Additional Context

No response

Suggested Changes

No response

Solution code pushed to main branch

Canvas Link

https://learning.flatironschool.com/courses/6258/assignments/231345?module_item_id=541450

Concern

Hi there! It looks like the solution code was pushed to the main branch. When I cloned this lab to complete it, the solution code was already in the looping.py file and all three tests were passing without any updates on my end. Just letting you know!

Additional Context

No response

Suggested Changes

No response

Incorrect Instructions

Canvas Link

https://learning.flatironschool.com/courses/6274/assignments/236172?module_item_id=554041

Concern

In the "Instructions" section at the bottom of the page on Canvas:

Write a function happy_new_year() using a while loop that outputs numbers starting at 10 and counting down to 1. After reaching 1, print out "Happy New Year!"

Compared to the Github repository's solution code:

def happy_new_year():
for i in range(10, 0, -1):
print(i)

print("Happy New Year!")

Additional Context

I'm not sure if there happens to also be a way to make this work with a while loop, but the instructions clearly state to use the while loop in this lab. Meanwhile, the solution does not even do that.

Suggested Changes

Either the instructions need to be changed to reflect what is actually being asked of us, or the solution code should be updated for those who get stuck and look to such a resource for answers/clarifications. Thanks.

General Writing feedback

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195246?module_item_id=439014

Concern

1. In the first sentence of the Basic Loops in Python section, our sentence reads In JavaScript, there are a few common approaches to for control flow that will allow us to run the same lines of code over and over again. Having both to and for in between approaches and control is grammatically incorrect. Either would probably work fine on its own.

2. When discussing ranges, we neglect to mention that the number passed to the range (or the second number passed, if we give it a starting and ending point) isn't included in the range. We also don't discuss the fact that you can give a range a starting and ending point - we just tell students that ranges start at 0.

Additional Context

No response

Suggested Changes

No response