learn-co-curriculum/python-p3-mapping-python-classes-to-a-database

python-p3-mapping-python-classes-to-a-database's Issues

Submit button on "Mapping python classes to a database" is a website link instead of a codegrade link

Canvas Link

https://my.learn.co/courses/653/assignments/33213?module_item_id=83756

Concern

submit button is for a link, not a button that opens code grade. There is no link to submit for this module.

Additional Context

No response

Suggested Changes

No response

Canvas Reading and README not in sync

Canvas Link

https://learning.flatironschool.com/courses/6258/assignments/231365?module_item_id=541563

Concern

It appears that additions were made to the code-along for this lesson within the README that do not show up in the lesson on Canvas. Some examples that are in the README but not Canvas:

• The solution code block starting at line 577.
• Code block starting at line 441 - in particular, line 452 -- CONN.commit() -- which is necessary for getting all tests to pass.

Additional Context

No response

Suggested Changes

No response

Class method called with `self` parameter.

Canvas Link

https://learning.flatironschool.com/courses/6258/assignments/231365?module_item_id=541563

Concern

This code in the instructions:

    @classmethod
    def create_table(self):
        sql = """
            CREATE TABLE IF NOT EXISTS songs (
                id INTEGER PRIMARY KEY,
                name TEXT,
                album TEXT
            )
        """

        CURSOR.execute(sql)

erroneously calls self as the parameter for a class method. This should likely say cls, I believe!

Additional Context

No response

Suggested Changes

Inside the create_table method, call cls rather than self to make it a class method.

all v get_all

Canvas Link

https://learning.flatironschool.com/courses/6049/pages/mapping-database-records-to-python-objects?module_item_id=468023

Concern

the function in the first screen shot is called all, then it is called get_all

Additional Context

No response

Suggested Changes

No response