learn-co-curriculum/python-p3-oop-putting-it-all-together

python-p3-oop-putting-it-all-together's Issues

instructions

Canvas Link

https://learning.flatironschool.com/courses/6329/assignments/239706?module_item_id=563645

Concern

line 74 and 80:
the pytest should either be changed to lib/testing/book_test.py (same for shoe_test) or specify to navigate into lib before running in command line

Additional Context

No response

Suggested Changes

the pytest should either be changed to lib/testing/book_test.py (same for shoe_test) or specify to navigate into lib before running in command line

Lab too easy?

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195257?module_item_id=439030

Concern

We can basically pass all the tests to this lab by give Book and Shoe an __init__ method and a turn_page and cobble method, respectively. Once we have these set up, all the other tests automatically pass, since python allows you to assign attributes freely. If this is meant to illustrate the ease of OOP with Python, then it's great.

But, this could also be an opportunity for students to practice using properties more. We don't have to make all attributes properties, but at least making a few of them properties could be good practice. It could also highlight the difference between non-properties, whose tests would pass as soon as the class is set up, and properties, which would need to meet certain requirements. Thoughts?

Additional Context

No response

Suggested Changes

No response

No Fork Button

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195257?module_item_id=439030

Concern

No fork button on “Putting It All Together: Object-Oriented Programming Lab”

Additional Context

No response

Suggested Changes

No response

Putting It All Together Feedback

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195257?module_item_id=439030

Concern

• “Putting It All Together: Object-Oriented Programming Lab” –” Shoe in shoe.py says that the shoe has been repaired.” test is unclear. Doesn’t tell you what name or what to return. Unsure if this is intentional.
• “Putting It All Together: Object-Oriented Programming Lab” – most the tests you need to write no code.
• “Use the property() function to create properties and validate input.” This is never needed to pass the tests.

Additional Context

No response

Suggested Changes

No response

Module Not Found by Tests

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195257?module_item_id=439030

Concern

The tests don't work as they do not recognize that the class containing the student's code is accessible by the testing files.

Additional Context

____________________________ ERROR collecting testing/shoe_test.py _____________________________
ImportError while importing test module '/Users/eleanorkelman/Documents/Python Phase 3 Labs/python-p3-oop-putting-it-all-together/lib/testing/shoe_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../../.pyenv/versions/3.8.13/lib/python3.8/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
testing/shoe_test.py:3: in
from shoe import Shoe
E ModuleNotFoundError: No module named 'shoe'

Suggested Changes

No response

Test is commented out

In lib/testing/shoe_test.py in test test_requires_int_size one of the asserts is commented out.

def test_requires_int_size(self):
'''prints "size must be an integer" if size is not an integer.'''
stan_smith = Shoe("Adidas")
captured_out = io.StringIO()
sys.stdout = captured_out
stan_smith.size = "not an integer"
sys.stdout = sys.stdout
# assert captured_out.getvalue() == "size must be an integer\n"
assert not stan_smith.size

Main branch has solution code

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195257?module_item_id=439030

Concern

d48efe0

This commit above added the code necessary to pass all the tests. The test suite passes upon cloning the lab down.

Additional Context

No response

Suggested Changes

Remove the class body code from both Shoe and Book, and replace both bodies with passes

import error for turtle

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195257?module_item_id=439030

Concern

Unclear why we need the turtle library imported for this lab. When I run pytest, the shoe_test.py file errors out and can't seem to get tkinter (not sure how I have turtle but not the dependencies it needs so that's a big question mark).

Additional Context

No response

Suggested Changes

Remove the import turtle line from shoe_test.py and it ran smoothly for me!