learn-co-curriculum/sql-table-relations-library-lab

sql-table-relations-library-lab's Issues

Solution Branch lists a failing solution

I don't think the last test on the last method is descriptive enough. It talks about the number of books they have appeared in, in descending order but does not mention that names also need to be in ascending order. This is also not reflected in the solution code, which fails to pass the provided test.

Method Description:

def
select_character_names_and_number_of_books_they_are_in 
end

Test Description:

it 'selects all of the character names and their number of books they have appeared in, in descending order, grouped by character name'

Failing Solution:

  <<-SQL
    SELECT characters.name, COUNT(*) as book_count 
    FROM character_books 
    JOIN characters 
    ON character_books.character_id = characters.id 
    GROUP BY characters.name 
    ORDER BY book_count DESC
  SQL

Passing Solution Suggestion:

 <<-SQL
    SELECT characters.name, COUNT(*) AS book_count
    FROM character_books
    JOIN characters
    ON character_books.character_id = characters.id
    GROUP BY characters.name
    ORDER BY book_count DESC, characters.name
SQL