learnersguild/prrr

Pull Request Review Request

Prrr

Development

npm install
npm run build

Setup

Go here and register a new OAuth application.

Application name: prrr development
Homepage URL: http://localhost:3000/
Application Description:
Authorization callback URL: http://localhost:3000/auth/github/callback

NOTE: you can use any port you want. It doesnt need to be 3000

Create a .env file like this:

NODE_ENV=development
PORT=3000
GITHUB_CLIENT_ID=<FOLLOW GITHUB INSTRUCTIONS>
GITHUB_CLIENT_SECRET=<FOLLOW GITHUB INSTRUCTIONS>
GITHUB_CALLBACK=http://localhost:3000/auth/github/callback
SESSION_KEY=thiscanbeanyoldrandomstring

NOTE: you can use any port you want as long as it matches your github oauth

Database

*NOTE: you need to run npm run build before you can run knex commands

createdb prrr-development
createdb prrr-test
knex migrate:latest

prrr's Issues

As a user, when I claim a PR, a request for review is issued to me from the originating repo

Requests for reviews show up in my github as a user, with the request assigned to me.

sort order on production is wrong http://prrr.learnersguild.org/

Make a "my purrrs" page

this page would show you analytics about the Prrs you've posted

Spike stubbing and moching github api in test

back fill specs for all commands and queries

swap out table of pending Prrrs for "there are X prrrs waitring, click here to claim one"

This means a coach can only claim the next available Prrr

Personal Dashboard

when a coach is added to a repo it's watch settings is set to "ignored"

move oauth settings to prrr.learnersguild.org and make the app redirect

A/B testing for restricting reviewer to oldest PR vs. allowing reviewer to cherry pick

In reference to this discussion.

"My Reviewed Prrrs" should be sorted by "Time Claimed" youngest first

Make more thorough tests...

...to catch things like #91 before they get merged into master.

Find a way to make sure tests are being run and passing before pull requests are submitted.

disabled buttons should not be focusable or have a focus halo

If PR review is not completed within an hour of being claimed the PR moves back to "waiting for review"

dry up all the times we do this:

https://github.com/${prrr.owner}/${prrr.repo}/pull/${prrr.number}

Site should be ajaxified

As a coach, I don't want to keep refreshing to see new issues and I don't want to claim an issue that was already claimed.

Both these things won't happen if the app is ajaxified!

Add a more adorable logged-in-homepage

add /all to view a large table of all Prrrs

As a user I can see stale claimed Prrrs at the top of the page and steal them

claimed Prrrs become stale after an hour and then someone else can steal them

Hide individual Prrrs that I have reviewed ( without archiving )

• When I have completed a Prrr and it goes to my reviewed prrrs table
• as I complete Prrrs and that table gets larger I may want to remove Prrrs from that list but I can't archive them because only the current requestor of that Prrr should be able to do that.
• I want a way remove Prrrs from "My Reviewed Table" without being able to archive them

Displayed error messages should remove them selves after X seconds

If owner of repo doesn't have a prrr account - invite that user to get a prrr account via email

move from Polling to WebSockets

As a user claiming a request, I would like to see a deadline to complete the review.

Make Prrrs tables on homepage collapsible.

• make a toggle component to use project-wide

If user has a Prrr claimed, should only show claimed Prrr table & one Prrr per user

Code Review analytics

There are four metrics that can show us the health of code reviews:

_Total code reviews last week
_Total code reviews per reviewer
_Longest time for PR to be reviewed last week
_Average time for PR to be claimed last week
_Average time for PR to be completed last week
_Total number of projects that requested reviews
_Average number of reviews requested per project

MPV

All these can be inferred from a table spit out into a csv file
Pull request, requester,reviewer,date_requested,date_claimed,date_completed

Ideally

There's an analytics page that calculates all the above. When calculating longest time and average times, it should not count evenings or weekends. If it's a publicly available analytics page that shows the numbers over the last 7 days it would be accessible to learners and that would be a great thing! It would acknowledge coaches for their work, and incentivize projects with lower than average review requests to raise their number

If I had a Pony

Report date-range can be selected
Adds: Average time from claim to complete, and longest time from claim to complete

Swap prrr button

If i claim a prrr but i want a different one (due to level of experience, no knowledge of particular technologies ) we create a button that does two actions at once.

1. Unclaim the prrr
   2.Claim the next prrr ( not the same prrr that i just unclaimed)

Use IDM to authenticate

This would allow you to get a valid Learners Guild JWT, along with the guild UUID for the given user, which could be useful to cross-check stats at some point.

Can't delete requested prrrs

When I click the X next to a requested prrr the following error appears in the console:

Uncaught ReferenceError: href is not defined
    at onClick (http://prrr.apps.learnersguild.org/browser-77dd2e8581d73e44683e.js:24642:42)

contribution heat map (like github)

remove cursive font from anywhere other than the logo

MyRequestedPrrrs table on the logged in homepage

user story:

As a requester I want to view my review comments on prrr 
or at least have a link to my comments so I can find comments easier

Feature:

Create a component named MyRequestedPrrrs that takes the already loaded `prrrs and displays the a table of the Prrrs you've requested for review.

ensure that the Countdown timer gets its time duration from the same place `unclaimStalePrrrs` does

Redo Navbar

Some Prrrs can be added but not claimed?

More attractive create PRRR page

setup circleci

Archive of Completed Code Reviews

...so others (SEPs, other learners) can read them, learn from them, and make additional comments

IMO, this is necessary helpful in terms of skills assessment as well as being able to address these three questions:

• How are we measuring quality and efficacy of these reviews?
• Are we reviewing reviews?
• Is there feedback on the reviews?

Can we just have an "Archive" tab on the navbar, similar to the "Metrics" tab?

Make all button styling consistent.

'Add a purr' is bigger and an <a..> tag and 'Logout' is smaller and a <button...> tag

test writing for WebSockets

Make better universal 404 page

-Inspiration- fail whale

add HTTP endpoint mocha tests

Reviewers can complete Prrr

add column to DB and add a button to complete the Prrr and remove completed Prrrs from list

Add the number of pending Prrrs to the Favicon and update it whenever it changes

MyReviewedPrrrs table on the logged in homepage

user story:

As a coach/requester I want to view a list of my completed and reviewed prrrs 
so I can see how many prrrs I've done and check prrrs I've had reviewed

Feature:

Create a component named MyReviewedPrrrs that takes the already loaded `prrrs and displays the a table of the Prrrs you've reviewed.

add selenium webdriver feature tests

add a horizontal timeline to visualize the queue

As a user I can delete my Prrrs

Unclaiming and claiming returns different Prrr

0. you see "there are 12 PRs pending review, click here to claim one"
1. you click that button
2. you decide your review is not useful enough
3. you unclaim
4. you click claim again (and you get a different Prrr)

This.