Event on('metadata') is fired twice in 0.3.1

[sahat]

Event on('metadata') is fired twice in 0.3.1

[leetreveil]

Do you have a test audio file so I can reproduce the bug?

On Sun, Jan 26, 2014 at 2:42 PM, Sahat Yalkabov [email protected]
wrote:

After hours and hours of pulling my hair, thinking there was something wrong with another library I am using, or perhaps a bug in fs.createReadableStream it turns out the latest version of musicmetadata has a bug.
I rolled back to v0.3.0 and metadata event is fired once as it supposed to.

Now as you can imagine firing this event twice was causing problems with async library calling callback(null, meta) twice which would throw an error, and in other case it would try to create database element twice and fail because of duplicate SQL entry.

Reply to this email directly or view it on GitHub:
#41

[sahat]

Hi, I was able to narrow down the problem further by testing various audio files. Some of my songs emit double meta event while others fire once.

Here are the songs that causes meta event to fire twice:

And here the songs that behave normally:

The only difference I see is in the encoding type. Your library doesn't seem to play well with non-LAME3 file encoding. At least as of version 0.3.1 with the introduction of duration option, which by the way is awesome and totally useful!

[leetreveil]

Could you send me one of the failing audio files?

[sahat]

I can confirm it is fixed now. Thanks!