Other language support?

[leetreveil]

Other language support?

[leetreveil]

Can you send me the audio file?

On Sat, Apr 19, 2014 at 10:27 AM, kirasagi [email protected]
wrote:

I was testing this on japanese songs and it returns squares instead of japanese characters in the tags. Mind adding support for other languages, such as Japanese and Korean characters?

Reply to this email directly or view it on GitHub:
#48

[enbrent]

Not sure how you want to get it but I've uploaded it on Dropbox. Japanese. Korean.

[leetreveil]

Both files work correctly for me, here's the output from the second one:

{ title: '지하철에서',
  artist: [ '악동뮤지션 (AKMU)' ],
  albumartist: [ '악동뮤지션 (AKMU)' ],
  album: '1집 PLAY',
  year: '20140407',
  track: { no: 4, of: 0 },
  genre: [ 'Folk' ],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 00 48 00 48 00 00 ff db 00 43 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 ...> } ],
  duration: 0 }

[leetreveil]

If you're on windows your console might not be displaying the unicode characters correctly.

http://stackoverflow.com/questions/388490/unicode-characters-in-windows-command-line-how

[enbrent]

Yes you're right it wasn't displaying right on the console. Thank you for your help.

A little offtopic, but I don't want to open up another issue. I'm getting 0 duration for all the songs I've tried with this module. Is there going to be a fix anytime soon?

[leetreveil]

You have to pass a parameter to read the duration:

var parser = mm(fs.createReadStream('sample.mp3'), { duration: true });

[enbrent]

Well that solves that. Thank you.