Invalid buffer data

[leetreveil]

Invalid buffer data

[leetreveil]

Both files worked ok for me:

[enbrent]

I'm sorry for the very late response. Can I see your code? Also do you know if force saving a png buffer to a jpg would have any effects on the final image file?

[leetreveil]

@Kirasagi did you solve this problem?

[mavericken]

I think I may have seen this same bug or maybe a bit different one that is likely related. For me it only happens when musicmetadata is handling two requests simultaneously. It is causing the first few and last few characters in the picture buffer to be corrupt. I was able to work around it by scheduling one file at a time to the parser.

[leetreveil]

@mavericken that's interesting, do you have some code that I could run to try and reproduce?

[leetreveil]

@mavericken I just pushed version 0.4.0 out, can you try that?

[mavericken]

Thanks for your efforts. It didn't solve it. I have tried to make some simple reproduction code, but so far I can't reproduce with the simple code. It could be a problem with my code, but it still looks very much like its coming from musicmetadata. If/when I find what the problem is or reproduce with simple code, I will let you know.

[rmoak]

I'm late to the party on this one but I think I've been able to reproduce this. I've been testing with ~8 files with embedded data (including Song 1 above), I notice that the image parsing randomly fails when I pass a {duration: true} argument to the mm function. If I don't calculate duration then I can get the image data correctly consistently.

[leetreveil]

I would LOVE if we could somehow get a reproducible test case.

[the-eater]

Okay I have build an reproducible test case, run index.js and at least one (or even 2 :O) of the six images are corrupt. you can download it here (be aware it contains speedcore and other obnoxious music)

[leetreveil]

Thanks @Eaterofcode, I can reproduce this. Let me see if I can figure out what is going on.

[the-eater]

I hope you can because it has been a PITA. I wish you success music metadata lord

[the-eater]

Your statement

it will theoretically effect other container types.

is incorrect because all data turns into immutable objects except images

[leetreveil]

I meant picture data within other container types (flac, ogg) etc. Good point though.

[the-eater]

Ah I see, sorry for the misunderstanding