leezhengjing/pe

pe's Issues

Feature Flaw: listAllConflicts is not very helpful

As shown in the user guide, this command aims to help a user view all their conflicting medicines with their current prescriptions. "Should you need to see all the drugs that conflict with all your current prescriptions, BayMeds
allows you to view all these drugs in a single list."

However, this is not a very useful command, as from the screenshot, the prescriptionList shows both paracetemol and aspirin, yet the conflicting drugs also show paracetemol and aspirin, with a new addition of amoxicillin. This might confuse the user instead of helping the user figure out conflicting medicines, as it might appear that paracetemol conflicts with itself, or aspirin with itself.

As a user, I don't think this command is very helpful. Perhaps just having the listConflicts command to target certain medicines would be sufficient.

Command success when adding duplicate completed prescription (i.e. sd and ed before current date), but prescriptionList does not reflect the change.

When I add a prescription with start date and end date that happened before the current date, i.e.
add mn/Test1 sd/01/08/2023 ed/01/11/2023, it works.

However, when I type it again, it also works as seen in the command response

However, when I try to find it using listCompleted, it doesnt show up.
So this raises the question, the command is a success but nothing happens to the prescriptionList(it's not updated). Should the command be a failure, if not and its an intended success, then why is the prescriptionList not updated with a duplicate prescription?

test

test

Documentation: Typo in DG

Simimulate should be simulate

Functionality: After running an untake command, expected screen (from UG) is different from the actual screen.

To reproduce: untake 1

Same as the take command, after running untake 1, the next screen shown is:

However, this is different from the user guide, which shows this.

It would be more friendly to the user to show the screen as promised in the user guide, as there is the updated consumption and stock.

Functionality Bug: Behaviour differs from User Guide

Documentation: Navigability

Lack of hyperlinks to direct back to the table of contents in their User Guide's PDF.

Would be more navigable for a user if there is a hyperlink at the end of a section to bring them back to the table of contents.

Documentation: Prescription missing conflicting drugs (DG)

Prescription class diagram missing conflicting drugs

Documentation: Wrong argument for saveCompletedPrescriptionList (DG)

Should be completedPrescriptionList instead of completedList

Documentation: DG lack of sequence diagrams for edit and take/untake

The edit feature and take/untake feature sections of the DG lack an accompanying sequence diagram in their explanation of an example usage of that command, making it hard to read and understand the different classes that are named.

Documentation: Constraints of note not mentioned

In the user guide:

However, the Note class actually has constraints which are not mentioned in the UG.

Functionality: After running a take command, expected screen (from UG) is different from the actual screen.

After running a take command, i.e. take 1 d/1

This is the next screen:

However, in the UG, it shows something different.

This is an inaccurate UG, as likely what occurred is the screenshot being taken after running a listToday command along with a take command.

This is likely to cause inconvenience to most users as long as they run a take command, but does not make the app unusuable, hence medium severity bug.

Functionality Bug: Behaviour differs from User Guide

Feature Flaw: Unused result display

The choice of making result display bigger (nearly half the app) yet not fully utilising the space by entering a new line when the command response exceeds the length of the result display GUI. (Cosmetic bug)