lefauxmatt/stardewmods

Stardew Valley mods

Hello 👋 My name is Matthew. I'm a privacy-enthusiast, an amateur sysadmin, and sometimes a good cook.

stardewmods's Issues

Toolbat Icons: NullReference when calling GetApi

Hello, someone had reported an error to me. When trying to getapi from Toolbar Icons, it says NullReferenceException. (https://smapi.io/log/61ce5105734041a8aa4da78555d0df7d)

Failed loading the per-mod API instance from Toolbar Icons. Integrations with other mods may not work. 
Error: NullReferenceException: Object reference not set to an instance of an object. 
at StardewMods.ToolbarIcons.ModEntry.GetApi(IModInfo mod) in X:\Repos\stardew-mods\ToolbarIcons\ModEntry.cs:line 33 
at StardewModdingAPI.Framework.ModHelpers.ModRegistryHelper.GetApi(String uniqueID) in SMAPI\Framework\ModHelpers\ModRegistryHelper.cs:line 88

I assume it's the container object not been initialized yet when my mod firstly reached OnGameLaunched.
So I think container needs to be inited early in the Entry part, rather than OnGameLaunched.

Craft From Workbench Distance not working as expected

I cannot get the Workbench to work with chests. I have better Crafting installed, and but none of the Craft From Workbench Distance settings work, just the Craft From Chest Distance, which also applies to me when I'm not using a workbench I'd prefer to have my workbench pull from nearby chests, respecting Better Crafting's config, and only allow me to craft from my personal inventory otherwise.

This is new, I had no issues in previous versions.

Error Message For Better Chests

This is an error message given by Smapi when trying to launch this mod after updating for 1.6:

[Better Chests] This mod failed in the GameLoop.GameLaunched event. Technical details:
InvalidOperationException: The configuration is invalid. Creating the instance for type IModConfig failed. Can't parse JSON file at D:\Steam\steamapps\common\Stardew Valley\Mods\BetterChests\config.json. This doesn't seem to be valid JSON.
Technical details: Could not convert string to boolean: Enabled. Path 'StashToChestStacks', line 62, position 33.
---> SimpleInjector.ActivationException: Can't parse JSON file at D:\Steam\steamapps\common\Stardew Valley\Mods\BetterChests\config.json. This doesn't seem to be valid JSON.
Technical details: Could not convert string to boolean: Enabled. Path 'StashToChestStacks', line 62, position 33.
---> Newtonsoft.Json.JsonReaderException: Can't parse JSON file at D:\Steam\steamapps\common\Stardew Valley\Mods\BetterChests\config.json. This doesn't seem to be valid JSON.
Technical details: Could not convert string to boolean: Enabled. Path 'StashToChestStacks', line 62, position 33.
at StardewModdingAPI.Toolkit.Serialization.JsonHelper.ReadJsonFileIfExists[TModel](String fullPath, TModel& result) in SMAPI.Toolkit\Serialization\JsonHelper.cs:line 86
at StardewModdingAPI.Framework.ModHelpers.DataHelper.ReadJsonFile[TModel](String path) in SMAPI\Framework\ModHelpers\DataHelper.cs:line 50
at StardewModdingAPI.Framework.ModHelpers.ModHelper.ReadConfigTConfig in SMAPI\Framework\ModHelpers\ModHelper.cs:line 101
at StardewMods.Common.Services.ConfigManager1..ctor(IEventPublisher eventPublisher, IModHelper modHelper) in X:\Repos\stardew-mods\Common\Services\ConfigManager.cs:line 26 at lambda_method219(Closure ) at SimpleInjector.Lifestyles.SingletonLifestyle.SingletonRegistration.Execute(Func1 instanceCreator)
at SimpleInjector.Lifestyles.SingletonLifestyle.SingletonRegistration.GetInterceptedInstanceWithNullCheck()
at SimpleInjector.Lifestyles.SingletonLifestyle.SingletonRegistration.GetInterceptedInstance()
at SimpleInjector.Lifestyles.SingletonLifestyle.SingletonRegistration.BuildExpression()
at SimpleInjector.InstanceProducer.BuildExpressionInternal()
at SimpleInjector.Internals.LazyEx1.InitializeAndReturn() at SimpleInjector.InstanceProducer.BuildExpression() --- End of inner exception stack trace --- at SimpleInjector.InstanceProducer.BuildExpression() at SimpleInjector.InstanceProducer.VerifyExpressionBuilding() --- End of inner exception stack trace --- at SimpleInjector.InstanceProducer.VerifyExpressionBuilding() at SimpleInjector.Container.VerifyThatAllExpressionsCanBeBuilt(InstanceProducer[] producersToVerify) at SimpleInjector.Container.VerifyThatAllExpressionsCanBeBuilt() at SimpleInjector.Container.VerifyInternal(Boolean suppressLifestyleMismatchVerification) at SimpleInjector.Container.Verify(VerificationOption option) at StardewMods.BetterChests.ModEntry.OnGameLaunched(Object sender, GameLaunchedEventArgs e) in X:\Repos\stardew-mods\BetterChests\ModEntry.cs:line 96 at StardewModdingAPI.Framework.Events.ManagedEvent1.Raise(TEventArgs args) in SMAPI\Framework\Events\ManagedEvent.cs:line 101

Disabling Search Tabs causes continuous SMAPI error spam when chests are open in 1.5.5 beta

NullReferenceException: Object reference not set to an instance of an object.
   at XSPlus.Features.CommonFeature.OnRenderingActiveMenu(Object sender, RenderingActiveMenuEventArgs e) in C:\Users\Matthew\RiderProjects\StardewMods\XSPlus\Features\CommonFeature.cs:line 182
   at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args, Func`2 match) in SMAPI\Framework\Events\ManagedEvent.cs:line 126

If it's not specific to this one mod, I'd say the most likely culprit seems to be ChestsAnywhere, which has a few other small incompatibilities. Notably, the reason I turned off the chest filter tabs is that they frequently render underneath my inventory when using ChestsAnywhere.

Here's a full SMAPI log in the smapi.io analyzer: https://smapi.io/log/51fc136399944d7ebd48dea0ff4c5129

[Better Chests]This seems to be a bug.

Hi, it seems that when the box is set to allow certain items to be put in, it adds some unchecked items to it as well.

I selected the axe, but the other items in front of the axe were also selected.

Checking most of the props also causes the problem, some props don't.

Thanks

Better Chests - ResizeChest doesn't work - Can't add items to Chests

Versions

Stardew Valley
1.6.3

SMAPI
4.0.6

Mod
2.13.1

Issue

I used the mod before, but I after the last upgrade from 2.10.2 to 2.13.1 I can't add items anymore to Chests that are larger than the normal ones from SDV.

Things I tried

• Checked the SMAPI log – No errors (see log)
• Clean install of Better Chest + Better Crafting + Fauxcore + Generic Mod Config Menu and configuring 'Resize Chest' to -1 and 72 via Generic Mod Config Menu.
• Removing config.json and configuring 'Resize Chest' to -1 and 72 via Generic Mod Config Menu.
• Went back to version 2.10.2 and corresponding FauxCore -> ResizeChest worked again.

Extra information

In config.json there is the option ResizeChest. When I delete the file and let it auto-generate, the value gets set to Large (I checked the file in Visual Code Studio). According to the readme.md this should have one of the following values: Enabled, Disabled, or Default.

I tried manually this to Enabled by changing the code in the config file, but it still didn't work. However, in that case, the mod also wouldn't show up in Generic Mod Config Menu anymore. I've attached the config file.

config.json

barely works in online co op

open carry on and some sorting options are not available to non host players,

Better Chests v2.18.1 - Controller snapping problems

When interacting with a storage container of any kind if you modify the contents of it or your inventory the cursor snaps to the first position in the storage container. This only happens on controller, mouse controls work fine. Reverting to our previous version 2.16.3 fixes the issue.

https://smapi.io/log/f656e50942c84d3e84ed3e22291126ba

Looking up an item in the Search Bar causes an error in SMAPI

I'm attaching the SMAPI log for reference: https://smapi.io/log/ec53a4cecc274738b6681db14c0f39fa

BetterChests: Unable to open held chest on multiplayer as non-host

BetterChests version 2.8.0

When I join a friend's server and I have a held chest, I am not able to open it up. I have to place the chest on the ground in order to open it. However, the host of the server is able to open held chests.

Turkish Translation For Better Chest

Heya
I just wanted To say I'm making a Turkish Translation for mod. so For this i opened a ticket for it.

After finish i will send translation

Items are not being counted towards quests

The bug is back in beta 6

2.16.1 - Controller navigation of chests not working

After updating to 2.16.1, I am no longer able to use the controller in chests. Mouse controls still seem fine.

BetterChests: Bulk craft dupe bug

It seems that when shift-clicking to craft when you have enough ingredients for 1 craft but not 5 the recipe results will still be given to you but without subtracting any of the cost.

This is from within the normal vanilla style crafting menu (i.e. within inventory menus, not from workshop table).

Log doesn't appear to have any details for the issue, but it at least mentions version numbers. (everything relevant should be latest version anyway)
SMAPI-latest.txt

Right clicking a picked up chest, deletes its contents

Default config of just Expanded Storage, no additional mods using it.

BetterChests: Horse Overhaul mod Overburdened

BetterChests v2.8.0

If you try to stash items to nearby chests while riding a horse (with the horse overhaul mod installed) you will get the carry chest speed debuff. The horse must have items on his inventory.

Last 2 Updates Prevent Ability to Craft

If I revert back 2 previous updates I am good, but the last 2 versions are preventing the ability to craft. If you go to the crafting menu it immediately takes you out of the menu and throws the following contained in the SMAPI log file. Link below:

https://smapi.io/log/d7c1f1b5a1524ead862802c0120463fb

Edit: It might be related to BetterCrafting though, but not sure..

Better Chests: Curseforge "Not Compatible"

When I tried to load version 2.16.3 it didn't let me and gave me the following message:

01:11:07	ERROR	SMAPI	These mods could not be added to your game.
01:11:07	ERROR	SMAPI	- Better Chests 2.16.3 because it's no longer compatible. Please check for a new version at https://smapi.io/mods

Here is my smapi log:

https://smapi.io/log/54082b53d5d34c5d9d56ddea38883d02

Glitched Ui for configuring chest Categorize

using version 2.10.0

[Better Chests] [Search Items] Compatibility with Satchels mod

Better Chests seems to break the Satchels mod when Search Items feature is enabled.

When I press Escape button whilst in a chest with a Satchel menu open it does not trigger the cleanup/closed logic of the menu as it abruptly closes out of the menus.

When I disable "Search Items" in Better Chests -> Main configuration then this does not happen.

Possibly because the input is suppressed, or due to the way the menus are closed.

SearchItems.cs OnButtonPressed

case SButton.Escape when this.itemGrabMenuManager.CurrentMenu.readyToClose():
    Game1.playSound("bigDeSelect");
    this.itemGrabMenuManager.CurrentMenu.exitThisMenu();
    this.inputHelper.Suppress(e.Button);
    return;

Is it possible to add additional code if another mod is loaded and to run the menus cleanupBeforeExit method if it is open?
Or to make sure any child menus are closed in turn?

The satchels have a NetBool isOpen which is not cleared.

Reproduction steps:

1. Open a chest
2. Open a satchel by right clicking it from inventory
3. Press Escape
4. Open Inventory
5. Right clicking the satchel does not open it anymore.

Pressing Z doesnt stash any items,

Pressing Z doesnt stash any items, tried to configure the settings nothing changed, no error message or warning is shown

[Better Chests] Save Fixes Break BC

With 1.6, I decided to try to start using Better Chests and may have run into a specific issue as a result.

Only in trying to play my old save do I get the following error (at end, save fixes shown)

[SMAPI] Type 'help' for help, or 'help <cmd>' for a command's usage
[game] Applying save fix: MigrateBuildingsToData
[game] Applying save fix: ModularizeFarmhouse
[game] Applying save fix: ModularizePets
[game] Applying save fix: AddNpcRemovalFlags
[game] Applying save fix: MigrateFarmhands
[game] Applying save fix: MigrateLitterItemData
[game] Applying save fix: MigrateHoneyItems
[game] Applying save fix: MigrateMachineLastOutputRule
[game] Applying save fix: StandardizeBundleFields
[game] Applying save fix: MigrateAdventurerGoalFlags
[game] Applying save fix: SetCropSeedId
[game] Applying save fix: FixMineBoulderCollisions
[game] Applying save fix: MigratePetAndPetBowlIds
[game] Applying save fix: MigrateHousePaint
[game] Applying save fix: MigrateShedFloorWallIds
[game] Applying save fix: MigrateItemIds
[game] Applying save fix: RemoveMeatFromAnimalBundle
[game] Applying save fix: MigrateStatFields
[game] Applying save fix: RemoveMasteryRoomFoliage
[game] Applying save fix: AddTownTrees
[game] Applying save fix: MapAdjustments_1_6
[game] Applying save fix: MigrateWalletItems
[game] Applying save fix: MigrateResourceClumps
[game] Applying save fix: MigrateFishingRodAttachmentSlots
[game] Applying save fix: MoveSlimeHutches
[game] Applying save fix: AddLocationsVisited
[game] Applying save fix: MarkStarterGiftBoxes
[game] Applying save fix: MigrateMailEventsToTriggerActions
[game] Applying save fix: ShiftFarmHouseFurnitureForExpansion
[game] Applying save fix: MigratePreservesTo16
[game] Applying save fix: MigrateQuestDataTo16
[game] Applying save fix: SetBushesInPots
[game] Applying save fix: FixItemsNotMarkedAsInInventory
[game] Applying save fix: BetaFixesFor16
[game] An error occurred in the base update loop: NullReferenceException: Object reference not set to an instance of an object.
   at StardewMods.BetterChests.Framework.Services.Factory.ContainerFactory.GetAllFromLocation(GameLocation location, Func`2 predicate)+MoveNext() in X:\Repos\stardew-mods\BetterChests\Framework\Services\Factory\ContainerFactory.cs:line 144
   at StardewMods.BetterChests.Framework.Services.Factory.ContainerFactory.GetAllFromLocations(ISet`1 foundContainers, Queue`1 containerQueue, Func`2 predicate)+MoveNext() in X:\Repos\stardew-mods\BetterChests\Framework\Services\Factory\ContainerFactory.cs:line 356
   at StardewMods.BetterChests.Framework.Services.Factory.ContainerFactory.GetAll(Func`2 predicate)+MoveNext() in X:\Repos\stardew-mods\BetterChests\Framework\Services\Factory\ContainerFactory.cs:line 52
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at StardewMods.BetterChests.Framework.Services.Features.CraftFromChest.GetMaterials() in X:\Repos\stardew-mods\BetterChests\Framework\Services\Features\CraftFromChest.cs:line 144
   at StardewValley.Menus.GameMenu..ctor_PatchedBy<furyx639.BetterChests>(GameMenu this, Boolean playOpeningSound)
   at StardewValley.Game1.<>c__DisplayClass947_0.<UpdateControlInput>b__0()
   at StardewValley.Game1.UpdateControlInput(GameTime time)
   at StardewValley.Game1._update(GameTime gameTime)
   at StardewValley.Game1.Update(GameTime gameTime)
   at StardewModdingAPI.Framework.SCore.OnPlayerInstanceUpdating(SGame instance, GameTime gameTime, Action runUpdate)
[game] WARNING: Mismatched UI Mode Push/Pop counts. Correcting.

This happens on trying to open the pause/inventory menu. Using a new save this doesn't happen.

Note I didn't have Better Chests in previous versions, and since furyCore is hidden I can't try reverting and saving with old Better Chests on before attempting the update to 1.6, if you think that might have some effect. Otherwise something about save fixes seems to break Better Chests.

AllowCarryingChests picks up Volcano Dungeon treasure chests

In Expanded Storage, if AllowCarryingChests is true, left-clicking on a Volcano Dungeon treasure chest picks it up into the inventory in the form of an empty standard chest.

Gamepad compatibility

D-Pad only works for up and down, not left and right. Everything works as intended.

Edit: sorry, didn't know that you assign dpad as other way to navigate.
Hopping that you can enable like how vanilla navigates. so closing this

[Better Chests] Critical bug causes crash

this is how to recreate this bug.

• Create a new save
• Pick up the Parsnip package ( and Error item appears in Inventory )
• Try to place the Parsnip package ( the Error item ) down

AND CRASH

The same thing happens when you pickup a chest and right click on the FarmHouse door

ShoppingCart: Doesn't work on Casino

Here's the picture of it working and not working:

Compatibility issue with Stardew Valley Expanded

In the Treasure Cave of the Crimson Badlands in SVE, when this mod is loaded, the Treasure Chests that spawn there every day don't spawn, and the spaces are left blank. Once this mod is removed, they spawn as intended.

[Better Chests] Junimo chest glitched UI

I'm using the latest version available on Nexus (2.9.3), maybe could there be an option to disable these interface changes for the junimo chests? (considering it only has 9 slots)

2.16.2 Can't leave blank spaces in backpack

In 2.16.2, it's no longer to leave a blank space if your backup - For example, if you want to move a item into a later row to leave a gap in your toolbar, it will instead put in back in the first open slot in the toolbar

Critical Problem in the Crafting System

Without a doubt it is one of the best mods for Stardew Valley, however, the mod has a critical problem in one of the best functions it offers, which is the ability to craft items without having them in the inventory, this is very practical, but if the If the player holds the SHIFT key, it is possible to craft items even if the resources are not enough, and the items used for crafting are not necessarily the required recipe items, in this case, any item that is in the player chests is used, causing a big problem.

YouTube Example Video

[Better Chests] Disabled fields are hidden in Generic Mod Config Menu

Here is GMCM

and here is the config file

{
 "DefaultOptions": {
   "AutoOrganize": "Enabled",
   "CarryChest": "Enabled",
   "CategorizeChest": "Enabled",
   "CategorizeChestTags": [],
   "ChestFinder": "Enabled",
   "ChestInfo": "Disabled",
   "CollectItems": "Disabled",
   "ConfigureChest": "Enabled",
   "CraftFromChest": "Location",
   "CraftFromChestDistance": 4,
   "HslColorPicker": "Enabled",
   "InventoryTabs": "Enabled",
   "InventoryTabList": [
     "Clothing",
     "Cooking",
     "Crops",
     "Equipment",
     "Fishing",
     "Materials",
     "Misc",
     "Seeds"
   ],
   "OpenHeldChest": "Enabled",
   "ResizeChest": "Large",
   "SearchItems": "Default",
   "StashToChest": "Location",
   "StashToChestDistance": 8,
   "StashToChestPriority": 0
 },
 "CarryChestLimit": 3,
 "CarryChestSlowLimit": 1,
 "CategorizeChestMethod": "GrayedOut",
 "Controls": {
   "CloseChestFinder": "Escape",
   "ConfigureChest": "End",
   "FindChest": "LeftControl + F, RightControl + F",
   "LockSlot": "LeftAlt",
   "NextTab": "DPadRight",
   "OpenCrafting": "K",
   "OpenFoundChest": "LeftShift + Enter, RightShift + Enter",
   "PreviousTab": "DPadLeft",
   "ScrollDown": "DPadDown",
   "ScrollPage": "LeftShift, RightShift",
   "ScrollUp": "DPadUp",
   "StashItems": "Z",
   "ToggleCollectItems": "LeftControl + Space, RightControl + Space",
   "ToggleInfo": "LeftShift + OemQuestion, RightShift + OemQuestion",
   "ToggleSearch": "LeftControl + F, RightControl + F"
 },
 "CraftFromChestDisableLocations": [],
 "CraftFromWorkbench": "Location",
 "CraftFromWorkbenchDistance": 8,
 "InventoryTabMethod": "Hidden",
 "LockItem": "Default",
 "LockItemHold": true,
 "SearchItemsMethod": "GrayedOut",
 "SearchTagSymbol": "#",
 "SearchNegationSymbol": "!",
 "StashToChestDisableLocations": [],
 "StashToChestStacks": true
}

Stash to chest stashes all items

As the title suggests, the newest update v2.9.3 has an issue where if you try to stash items to existing stacks, it will instead stash your entire inventory into the opened container. Its both when you press "Z" and "Add to existing stacks".

Tools stashed into empyts chests and Colour UI wrong location

Whenever I try to use my stack to chest hotkey it also puts all of my tools into the chest instead of leaving them in my inventory like it used to, additionally the UI for chaniging the chest colour is on the left of the menu and not the right, the cursor also goes behind it though I can still interact with it

request - allow adding a label to chest so I can call a chest for exmple "MyCrap2"

Self Explanatory

Automate compatibility broke

After the most recent update automate seems to no longer be working with this and it did previously could you please take a look and try to fix it
https://smapi.io/log/c85c497b49c3451e9173e11be03a19b0

were the bugs fixed in 2.9.0?

The changelog doesnt say much besides it was updated to SV 1.6 so I was wondering if the mod was really just updated or if the known bugs were also fixed

Automatic keyboard detection for Stash to chest

Hi, thanks for this awesome mod, this isn't a bug just a suggestion. The config file automatically use the Z key for Stash to chest but I think if there was some kind of verification to detect if the keyboard is QWERTY or AZERTY to assign directly either Z or W would be better.