lekjos/django-custom-admin-pages

A Django app that allows you to register class-based views to appear in Django admin.

django-custom-admin-pages's Issues

App label issues when following dotted path convention

Describe the bug
Django recommends that for local apps, you specify the INSTALLED_APPS via the dotted path to the AppConfig (see INSTALLED_APPS).

In order to pass the check added by 1.2.2, the app_label needs to be the same string used INSTALLED_APPS. However, if this is used, then we can no longer match on app_label CustomAdminSite's get_app_list().

To Reproduce
Steps to reproduce the behavior:

1. Have an app named "my_app" with AppConfig at my_app.apps.MyAppConfig.
2. Add the dotted path to INSTALLED_APPS
3. Create a View extendeing AdminBaseView, and use "my_app" as the app_label.

Expected behavior
Correct app is identified.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Mac OS 14.1.1
• Browser Firefox (irrelevant)
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
I believe we would expect found to be set to True in this scenario (ref)

for app in app_list:
    if view_app_label == app.get("app_label", "").lower():
        found = True

But since it falls through, another issue occurs on line 210 because get_installed_apps() returns a flat list of strings, whereas app_list is a list of dicts containing 'name', 'app_label', etc.

This causes the following TypeError:

 File "<path>/.venv/lib/python3.11/site-packages/django_custom_admin_pages/admin.py", line 210, in get_app_list
   remaining_apps = set(set(get_installed_apps())).difference(app_list)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: unhashable type: 'dict'