lemoncake/mslabel

custom label allows you to specify line height and text anchoring

mslabel's Issues

MSLabel/MSLabel.m:19:1: Method definition for 'stringsWithWordsWrappedFromArray:' not found

stringsWithWordsWrappedFromArray: is not implemented:

Closest equivalent would be this I'm guessing (also has the only place the method is used shown at the top):

Doesn't apply the UILabel's shadow properties

The drawing ignores any shadow settings applied to the UILabel. This can easily be fixed by inserting the following after line 33 in MSLabel.m:

CGContextSetShadowWithColor(UIGraphicsGetCurrentContext(), self.shadowOffset, 0, self.shadowColor.CGColor);

Vertical alignement ?

I'm trying to figure out how to bring back the middle vertical alignement from the standard UILabel. Any idea how to start ?

Thanks,

Flawed text wrapping algorithm

If all you want is a label with the ability to change the line spacing there is very little to choose from on github. The example you mentioned, MTLabel, says there's a known issue in drawing in table cell due to the fact he uses performSelector:withObject:afterDelay:. Any code using this method instantly rings alarm bells in my head.

Anyway your solution seemed ideally as although it only supports one lineBreakMode it was the one I needed but alias your text wrapping code gets stuck in an infinite loop and after inspection I can see if needs some serious optimisation.

Hope you get the time to fix it as this is useful little class

Ignores newline characters

In the standard UILabel, a newline character \n causes a line break. In this component, the newline characters gets trimmed out and are not respected.

Regaring iOS line specing

Hello,

I am implementing MSLabel Class for line spacing in vertical formate label but its not working in iOS 8 Xcode 6.1 with Autolayout. please check. Help much Appreciate...

Thanks,

You should use this loop for you stringsFromText Method

NSArray *splitString = [string componentsSeparatedByString:@" "];
NSMutableArray *allLines = [NSMutableArray array];    
NSMutableString *line = [NSMutableString string];
for (int i = 0; i < splitString.count; i++) {

    NSString *word = [splitString objectAtIndex:i];
    NSString *fakeLine =  [NSString stringWithFormat:@"%@%@ ",line, word];

    CGSize lineSize = [fakeLine sizeWithFont:self.font];

    if (lineSize.width <= self.frame.size.width) {
        [line appendFormat:@"%@ ", word];
    } else {
        [allLines addObject:[line stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]]];
        line = [NSMutableString string];
        [line appendFormat:@"%@ ", word];            
    }
}
[allLines addObject:[line stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]]];

its only one loop and you don't need a set to "Remove words" you just need to know where your at. Its probably faster, plus the other one with the weird double loop was giving me an EXC_BAD_ACCESS when I used that same method to create a inner shadow rendering engine.

Podspec outdated

Podspec for cocoa pods is pointing to an old commit, please update!

License?

What license is this distributed under? Thanks!

Calling sizeToFit cuts off lines of text

Nice subclass. Calling sizeToFit though produces unexpected results.

No space between words when using word wrapping.

Sometimes when I'm using 'NSLineBreakByWordWrapping' and having more than 1 line text (2 or more) and using 'lineHeight' property, there is no space between some words. Also, I only came across this in 'Hebrew' text UTF8 from right to left, so maybe there is the problem. Why is that?

Warnings related to Deprecated property in IOS6.

There are certain warnings related to properties deprecated in IOS6. and rather we should use functions that are given for IOS6 ex. for breaklinemode OR textalignment.

If possible pls, update it so that it supports and goes well with IOS 6.

Sumit