lenarother/django-legaltext

django-legaltext's Issues

Checkboxen optional

Zu manchen TNBs gibt es kein Formular. Checkboxen können in diesem Fall deaktiviert werden.

Check for querystring existance

https://github.com/moccu/django-legaltext/blob/master/legaltext/admin.py#L29
You assume that legaltext querystring is always present. This schould be verified beforehand.

legatext version / Rechtstextversion

In the row of buttons on the lower end of the popup window is one that indicates it would be possible to edit and save the text but this is not possible currently. Would be good to either remove this one or add the functionality.

LegalTextFormField should work with empty database

Currently, code throws exception if legal text version has no checkboxes at all.

URL Pattern should be more exact

https://github.com/moccu/django-legaltext/blob/master/legaltext/urls.py#L9
Matches anything, update to [\w-]+ - this is what is allowed in slug fields.

Display all checkbox labels with single form field

Optimise LegalTextCheckboxFormField field so it:

• takes lgaltext slug as input
• is a single field in the form with a name
• displays all checkboxes belongin to the legaltext

legaltext_url Templatetag

Add a template tag which acts like url tag including support for "as" which takes the internal slug of a legal text and returns the url based on slug or url name - depending on available data.

Allow to modify target attribute of links in checkbox content

Currently, links inside checkbox contents are converted to links that cannot be customized so they open in a new window (target="_blank"), so they always open in the same window:
https://github.com/moccu/django-legaltext/blob/29f572a4816a801ff6bd0635aa233cf8efd72071/legaltext/models.py#L116-L116
This should be configurable.

admin form is not threadsafe

https://github.com/moccu/django-legaltext/blob/master/legaltext/admin.py#L85
Make sure you don't modify the base_fields of a form. This is not threadsafe. You have to find another way of passing the initial value to the form.

Make template customizable

Instead of overwriting the template by adding a new file into templates/legaltext/content.html, it would be nice to define a custom filepath. For projects with more than one simultaneous participation forms, the path may need to differ.

Enlarge slug field

The LegalText.slug and LegalText.url_slug field should store more characters (at least 128).

URL unique check not working

The Admin complains that an empty url slug is invalid because it is already in use. Looks like we cannot use unique=True here. Need to change the validator to make sure only url slugs with a value are considered when looking for duplicates.

Checkboxes order is not saved

Make checkboxes sortable.

Mögliche Optionen in readme aufnehmen

Bitte auflisten, welche Variablen im Template verwendet werden können:

Options:
	- current_version
		- name
		- valid_from
	- current_version_content

Add export possibility

Add possibility to export all LegalText versions as md. Format: YYYYMMDD_HHMMSS_VersionsID_LegalTextName_Typ.md

E.g.

Text: 20170406_194300_29_perfectage_event_terms_text_content.md
Checkbox: 20170406_194300_29_perfectage_event_terms_text_checkbox1.md

Markymark version requirement

https://github.com/moccu/django-legaltext/blob/master/setup.py#L12
Markymark install required shouldn't mention a max-version if not required - this would prevent users from using a semi-new version because legaltext required a maybe older version.

Form fieldnames

https://github.com/moccu/django-legaltext/blob/master/legaltext/fields.py#L20
Form fieldnames should never be uppercase.

Update project layout to current state of the art

Please refer to django-markymark for this.
pytest.ini .coveragerc and other can be merged into one setup.cfg.
Check for other differences too. Thanks!

Vorschau-Links hinzufügen

Bitte nach dem Speichern einer neuen Version einen Link zur Vorschau hinzufügen. Vielleicht direkt in der Bestätigungsmeldung:

FormFields schould use floppyforms if available

LegalTextFormField schould use floppyforms fields if floppyforms is installed. This can be done by

try:
    import floppyforms.__future__ as forms
except ImportError
    from django import forms

Use MultiWidget to represent checkboxes of legaltext version

Instead of adding additional checkbox inputs via custom form fields.

Packaging - check content of wheel and src dist

Make sure that both builds only contain what they should, e.g. contain locale, templates and doesn't contain tests. Keep your eyes open for other files that shouldn't belong to the packaged files.