lenwesaralonde/musician

Add-on for World of Warcraft to perform music in game.

musician's Issues

Deal with phasing in Musician.Registry.PlayerIsInRange()

Musician.Registry.PlayerIsInRange() returns true if the player is in range to hear the music. It does not take account of phasing so music coming from another phase or server shard can still be heard.

The C_PlayerInfo.IsConnected() function seems to address this.

C_PlayerInfo.IsConnected(PlayerLocation:CreateFromGUID(guid))

Mute sound during preloading

Playing music before the preloading process is complete may cause freeze on computers running WoW from a HDD.

• If samples are not preloaded, gray out the minimap icon and mute all samples until it's complete.
• Optimize preloading process to speed it up while limiting FPS drop (30%)

The average time for loading a sample can be used to determine how the sample is loaded :

• < 1ms : Loaded from RAM / OS cache (already preloaded)
• < 10ms : Loaded from a SSD (measured ~6ms on Sandisk SATA SSD)
• > 10ms : Loaded from a HDD (measured ~30ms on external USB2 5400 RPM HDD)

Wrong position of character animated notes in over the shoulder camera mode

/script SetCVar('test_cameraOverShoulder', -5)

Musician channel not joining if the player hasn't joined any channel

The communication channel MusicianComm is never joined if the player has not already joined at least one channel (ie General)

Also, don't block requests sent in group channel or whisper if the communication channel is not ready yet.

Add a message when joined communication channel but alone ("There is no other music fan around yet..." )

Workaround : Join one channel (/join General)

MyRolePlay support

Add Musician version number in player tooltips when using MyRolePlay

Detach minimap menu from minimap button

LUA error in CrossRP module

Occurred during a NZoth LFR

Fix communication on WoW Classic 1.13.3 after API change

Music streaming over CHANNEL is broken since Wow Classic 1.13.3.
Fix protocol to use YELL instead.

https://us.forums.blizzard.com/en/wow/t/classic-patch-1-13-3-lua-api-change/384543

Fix MIDI key indexes in protocol and format

MIDI key indexes do not comply with the MIDI standard in the MUS file format and communication protocol.

Middle C (261.626 Hz) should be C4 with key index 60 for all instruments, including percussions and drumkit.

• Create MUS6 format using proper MIDI key indexes
• Update communication protocol to version 6 (v5 is specific to WoW Classic version)
• Fix MIDI converter
• Fix MIDI key indexes
• Create update script for MusicianList to fix key indexes in saved songs
• Update demo songs in MusicianList

Live keyboard UI dropdowns go off screen

Preload samples during loading screen

Preloading samples in the OS file cache in background is slowed down to avoid FPS drop when starting to play after a cold start.

Loading all samples from a SSD takes ~13 seconds, which is less than the script timeout (~15s) so it can be safely done during the loading screen.

Improve preloader to attempt to load all samples within 15 seconds during cold startup. If all samples can't be loaded (HDD), continue with the background preloading.

MusicianStop sent every time a character dies even when not playing music

Rework promo emote to make it less intrusive

When playing a song, the following "promo" emote is sent in the chat :

Player is playing a song. (Get "Musician" add-on or upgrade it from https://lenwe.info/musician to listen!)

This could be annoying for players who don't want to install addons, especially because of the URL and its overall length.

The addon can now be easily found on Google by typing "musician addon" so the URL part is no longer needed.

This can also get spammy in crowded places such as taverns etc.

• Rework this to make it shorter and less intrusive (Get "Musician" add-on to listen)
• Add a settings panel to addon with options allowing to disable the promo part or the whole emote.

Note icon in nameplates does not always take the whole nameplate opacity

Synchro play and stop

Add commands syncplay and syncstop for the party/raid leader to command other who have loaded the same song.

Based on : https://gist.github.com/LenweSaralonde/0c31239bda596877c317b2ab3a9d96c4

Musician version not always showing in TotalRP tooltips

Workaround:
/run Musician.TRP3.HookTooltip()

Notes dropping when previewing with tracks muted

Standard "Is playing" emote is showing in another language

The standard " is playing music..." emote is not properly hidden if the current player has a client in a different language than the one playing music.

Hide standard emote, regardless of the client language.

About window with supporters list

Add an "About" popup accessible from the main menu showing various informations:

• Version number
• Discord link
• Donation / Patreon links
• Supports list

Fix API conflicts with Ace3 in Musician.Live module

Rename Musician.Live.IsEnabled() into Musician.Live.IsLiveEnabled()
Rename Musician.Live.Enable(enabled) into Musician.Live.EnableLive(enabled)
Update libs

Options sometimes not showing up on some machines

Manually calling Musician.Options.UpdateSize() resolves the issue. This could be a simple timing problem.

Note icon sometimes not showing up in nameplates

Occurs randomly with TRP3 + KuiNameplates on Retail

Minimap button moved back to minimap on click with Minimap Button Frame

Minimap Button Frame add-on : https://wow.curseforge.com/projects/minimap-button-frame

Probably due to the MusicianButton.Reposition() call at line 80
https://github.com/LenweSaralonde/Musician/blob/master/ui/MusicianButton.lua#L80

This line seems to have no real purpose, see if removing it fixes the problem.

Modify play and preview commands to act as toggle

Group live mode

Add a "Group sync" mode when in party or raid mode to send Note On / Note Off events in the group channel prior to playing them to allow live group play,

Force MusicianComm channel in last position

Sometimes regular General / Trade / LocalDefense take too much time to be joint and MusicianComm gets in first position.

Solution: Reorder channels every time the channel list is changed to force MusicianComm at the last position

Nameplate icons broken with ElvUI 11.49

Nameplates are broken with ElvUI 11.49

Message: Interface\AddOns\Musician\modules\ElvUI\ElvUI.lua:35: hooksecurefunc(): Update_Name is not a function

Option to disable the musician search on TRP3 map scan

LUA error with Nameplates when in garrison

Check if nameplate is forbidden prior to perform anything on it

Stop playing song when dead

Preloading progression shown as stuck to 0%

LUA error on checkboxes in WoW Classic

Mute, solo and power chords checkboxes do not work in WoW Classic and trigger a LUA error.

Message: Interface\FrameXML\OptionsPanelTemplates.lua:201: Usage: GetCVar("cvar")
Time: Fri Aug 14 00:26:00 2020
Count: 3
Stack: Interface\FrameXML\OptionsPanelTemplates.lua:201: Usage: GetCVar("cvar")
[C]: in function `GetCVar'
Interface\FrameXML\OptionsPanelTemplates.lua:201: in function `BlizzardOptionsPanel_SetCVarSafe'
Interface\FrameXML\OptionsPanelTemplates.lua:153: in function `BlizzardOptionsPanel_CheckButton_SetNewValue'
Interface\FrameXML\OptionsPanelTemplates.lua:131: in function `BlizzardOptionsPanel_CheckButton_OnClick'
[string "*:OnClick"]:6: in function <[string "*:OnClick"]:1>

Locals: (*temporary) = nil

Override OnClick for checkboxes that inherit from OptionsSmallCheckButtonTemplate

VU meter is never released in the song editor when the track is muted

VisualNoteOn events do not have a corresponding VisualNoteOff event when the track is muted.
Add notes that won't play in the track.notesOn table with a handle set to 0

Option to disable the note icon in nameplates

CrossRP integration to allow cross faction and coalesced realms communication

Create a Cross RP module to enable music to be played cross faction and deal with coalesced realms.

• Cross-realm/faction communication with Cross RP
• Destination optimization
• Options panel
• "Tips and tricks" popup window

Add and rework instruments

Add instruments :

• Accordion
• War horn (shofar)
• War drum

Rework instruments :

• Hammered dulcimer: Replace soundfont
• Celtic harp: Replace soundfont
• Renaissance lute: Replace soundfont
• Recorder: Replace soundfont
• Male tenor voice: Replace soundfont
• Female soprano voice: Fix looping and rework out of range notes using iZotope Radius
• Fiddle: Replace soundfont
• Bagpipe: Replace soundfont
• Cello: Replace soundfont by viola da gamba
• Trumpet: Replace soundfont by natural trumpet
• Trombone: Replace soundfont by sackbut
• Bassoon: Replace soundfont
• Clarinet: Replace soundfont
• Traditional percussions: Replace samples

Misc:

• Add instrument credits information in about window

Emote

I have this weird thing and I can't find the option or what I did different.

On my main I do not see the /me plays a song emote, I do on all my alts however!

What am I missing?

Musician has been blocked from an action only available to the Blizzard UI.

Some basic game actions get blocked by the addon showing the message : "Musician has been blocked from an action only available to the Blizzard UI."

Version: 1.5.0.2

Reproduction steps

Prerequisites : Having a game community created

1. Reload UI
2. Import a song
3. Preview song
4. Open song editor and change some transpose and instrument settings
5. Close song editor
6. Open Guild and Communities window
7. Left click on the community > Group parameters
8. Press "Accept"

Result

Popup with "Musician has been blocked from an action only available to the Blizzard UI." shows up. Group settings are not saved.

Expected result

Group settings are saved without error

MIDI files with tempo variations but no initial tempo are messy

Example MIDI : https://musescore.com/user/28419/scores/2190066

"Solo" track status doesn't synchronize with song actually being played

Refactor 3rd party add-ons integration into modules

Create a new modules folder to separate code that is specific to 3rd party add-ons such as Total RP3.

LUA error if changing zone while playing music

Logo Proposal for Musician

Hi! @LenweSaralonde

I'm interested in collaborating with this project by delivering a series of logotype options that fits this project for the best!

If interested let me know so we can get started!

Cheers!

Third party instruments do not preload

Third party instruments implemented in separate plugins such as Instruments v1 and Piano are loaded after the preloading process is initialized.

Move sampler and preloader initialization process to OnEnable so it starts after all other add-ons have been loaded.

Set cooldown for promo emote

Do not send the "promo" emote less than every 10 minute when the option is checked to avoid other players who don't have the add-on to see it too often.

In band play mode, only the initiator of the play action should send the promo emote.

Support for ABC format

Allow importing music in ABC format

Add music animation to nameplate of characters playing music

Investigate if it's possible to add 3D animations, text or icons to character nameplates. (check "Plater" and "RP Tags" add-ons)

• Add a music spell animation to character nameplates playing music
• Add an icon to character nameplates who have a compatible version of the add-on and can hear you.
• Options panel
• Hide nameplates content when UI is hidden but keep music spell animation visible
• "Tips and tricks" popup
• 3rd party support:
• • TRP3
• • Plater
• • KuiNameplates
• • ElvUI

Classic, LUA error when logging in with ElvUI enabled

Message: Interface\AddOns\Musician\modules\ElvUI\ElvUI.lua:17: hooksecurefunc(): StyleFilterNameChanged is not a function Time: Mon Sep 23 19:21:55 2019 Count: 1 Stack: Interface\AddOns\Musician\modules\ElvUI\ElvUI.lua:17: hooksecurefunc(): StyleFilterNameChanged is not a function (tail call): ? [C]: in function hooksecurefunc'
Interface\AddOns\Musician\modules\ElvUI\ElvUI.lua:17: in function <Interface\AddOns\Musician\modules\ElvUI\ElvUI.lua:8>
[C]: ?
...dOns\AmmoReminder\Libs\AceAddon-3.0\AceAddon-3.0.lua:70: in function <...dOns\AmmoReminder\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
...dOns\AmmoReminder\Libs\AceAddon-3.0\AceAddon-3.0.lua:527: in function EnableAddon' ...dOns\AmmoReminder\Libs\AceAddon-3.0\AceAddon-3.0.lua:620: in function <...dOns\AmmoReminder\Libs\AceAddon-3.0\AceAddon-3.0.lua:605> [C]: in function LoadAddOn'
Interface\FrameXML\UIParent.lua:353: in function UIParentLoadAddOn' Interface\FrameXML\UIParent.lua:424: in function TimeManager_LoadUI'
Interface\FrameXML\UIParent.lua:693: in function <Interface\FrameXML\UIParent.lua:658>

Locals: `

Scroll down arrow lights up when there are 11 tracks in song editor

Music do not play in battlegrounds