leonardo2718/lua-vermelha

A Lua implementation with an Eclipse OMR based JIT compiler

lua-vermelha's Issues

Add tests for meta-tables

New test cases need to be created that exercise JITed code involving meta-tables. These tests should all opcodes that can potentially deal with meta-tables.

Update license from EPL v1.0 to EPL v2.0

Following the lead of Eclipse OMR, I'd like to update the licensing of Lua Vermelha from EPL v1.0 to EPL v2.0.

@charliegracie, @lmaisons, @leejingbo, please give a +1 or a 👍 if you are okay with this update.

Fix the lvjit module to gracefully handle nil "functions"

Currently, if a nil "function" is passed to lvjit.compile(), a segmentation fault occurs. This should be handled more gracefully.

Implement CONCAT opcode

Implement ILGen for the CONCAT opcode as well as adequate testing for it.

Implement LOADKX opcode

Implement ILGen for the LOADKX opcode as well as adequate testing.

Implement VARARG opcode

Implement ILGen for the VARARG opcode as well as adequate testing for it.

Update documentation reguarding Eclipse OMR licensing

The Eclipse OMR project recently updated it's licensing from EPL 1.0 to EPL 2.0. Lua Vermelha's documentation should reflect this.

cannot build from a fresh checkout

The command make gives the following error:

make[1]: Leaving directory '/home/dev/checkout/lua-vermelha/lua'
cd /home/dev/checkout/lua-vermelha/vermelha && make /home/dev/checkout/lua-vermelha/vermelha/libvermelha.a CXX="g++" CXX_FLAGS_EXTRA="-fpermissive -DLUA_C_LINKAGE -O3 -g"
make[1]: Entering directory '/home/dev/checkout/lua-vermelha/vermelha'
g++ -std=c++0x -fno-rtti -W -Wall -Wextra -fPIC -fpermissive -DLUA_C_LINKAGE -O3 -g -I../ -I../omr/jitbuilder/release/include -I../omr/jitbuilder/x/amd64 -I../omr/jitbuilder/x -I../omr/jitbuilder -I../omr/compiler/x/amd64 -I../omr/compiler/x -I../omr/compiler -I../omr -c LuaTypeDictionary.cpp -o /home/dev/checkout/lua-vermelha/vermelha/objs/LuaTypeDictionary.o
Assembler messages:
Fatal error: can't create /home/dev/checkout/lua-vermelha/vermelha/objs/LuaTypeDictionary.o: No such file or directory
Makefile:90: recipe for target '/home/dev/checkout/lua-vermelha/vermelha/objs/LuaTypeDictionary.o' failed
make[1]: *** [/home/dev/checkout/lua-vermelha/vermelha/objs/LuaTypeDictionary.o] Error 1
make[1]: Leaving directory '/home/dev/checkout/lua-vermelha/vermelha'
Makefile:74: recipe for target '/home/dev/checkout/lua-vermelha/vermelha/libvermelha.a' failed
make: *** [/home/dev/checkout/lua-vermelha/vermelha/libvermelha.a] Error 2

The problem could be solved by

mkdir vermelha/objs

Implement SETLIST opcode

Implement IlGen to handle the SETLIST opcode.

Implement SELF opcode

Implement IlGen to handle the SELF opcode.

Add continuous integration

A service such as Travis CI should be used to ensure that all changes submitted pass some level of testing. This will help ensure that all changes meet a certain level of quality.

A slight drawback of continuous integration is that running the tests takes time. This of course increases the waiting time for a PR to be merged. The test cases executed should be carefully chosen to avoid spending too much time testing unlikely sources of bugs.

Investigate using a proper testing framework

Currently, test cases are simple Lua scripts that exercise the code paths being tested. This is a less than ideal approach as there is no convenient way of reporting errors. Using a proper testing framework would help organize and cleanup the test cases.

Add tests for implicit conversion from string in math and bitwise opcodes

There needs to be some test cases for math and bitwise opcodes that involve implicit conversion from string types to integer and floating point types.

Add the Lua test suite to the Lua Vermelha tests

For completeness, Lua Vermelha should be tested against the Lua test suite. Adding this suite as a submodule would make it easier to automate running these test (e.g. in continuous integration).

Implement GETUPVAL and SETUPVAL

Implement ILGen for the GETUPVAL and SETUPVAL opcodes as well as adequate testing for them.

Create a module for interacting with the JIT from Lua code

There are many cases where it can be useful to interact with the JIT compiler from Lua code. Some useful interactions can be:

• checking whether a function has been compiled
• requesting a compilation
• turning the JIT off
• turning the JIT on
• blacklisting a function from compilation
• removing a function from the compilation blacklist

A Lua module seems like a clean way to encapsulate this interface. Implementing this will likely require redesigning the API between the VM and the JIT.

Re-implement SUB, MUL, DIV, and IDIV

IL generation for the SUB, MUL, DIV, and IDIV, opcodes needs to be re-implemented to follow the style of ADD. Once this is done, the vm_sub(), vm_mul(), vm_div(), and vm_idiv() helper functions can be deleted.

Chinese translation of the document

I cloned the repo and made some Chinese translation of the document.

Could I make pull requests for this ?

Implement CLOSURE opcode

Implement IlGen to handle the CLOSURE opcode.