leranjun/subsrt-ts

Subtitle JavaScript library and command line tool with no dependencies.

subsrt-ts's Issues

bug(vtt): multiline caption new line removal

As stated in #2 before, currently new lines in multiline captions are replaced with spaces which can cause a problem in the captions that have more than one speaker at the current time of the video. In this situtation, subtitle editors mostly denote each speaker with a hyphen (-), words they say and a new line. Hence resulting in outputs as -Where were you? - At the store.
This may confuse people when reading the caption because of this I suggest keeping the content of the caption as it is.

Multiline subtitles

First of all thanks for this great library and conversion to typescript.
The problem is that the regex in vtt doesn't capture the first line of a multiline subtitle.
For example:

WEBVTT

00:00:00.000 --> 00:00:10.000 position:45%,line-right align:center size:35%
- Hey
- Hi

00:00:11.000 --> 00:00:20.000
- Hey
- Hi

The first caption's output is '-Hey -Hi' but the second one's is just '- Hi'.
I believe it is related to \s?.*\r?\n regex before the text group ([\s\S]*).
It matches with the first line and completely disregards it.
Explanation:
In the first caption;

• `\s?' matches with the space between the times and style
• .*\r?\n matches with the style and the new line

In the second caption;

• `\s?' doesn't match anything because there is no space
• .*\r?\n matches with - Hey because it takes every character until it comes across with a new line which also happens to be the first line of the caption.

subsrt-ts/lib/format/vtt.ts

Lines 40 to 42 in 862a66d

	const regex =
	/^([^\r\n]+\r?\n)?((?:\d{1,2}:)?\d{1,2}:\d{1,2}(?:[.,]\d{1,3})?)\s*-->\s*((?:\d{1,2}:)?\d{1,2}:\d{1,2}(?:[.,]\d{1,3})?)\s?.*\r?\n([\s\S]*)$/;
	const match = regex.exec(parts[i]);

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency eslint-config-prettier to v9
• chore(deps): update typescript-eslint monorepo to v6 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)

Detected dependencies

github-actions

.github/workflows/deploy-docs.yml

• actions/checkout v3
• actions/cache v3
• actions/setup-node v3
• actions/configure-pages v3
• actions/upload-pages-artifact v2
• actions/deploy-pages v2

.github/workflows/lint-and-test.yml

• actions/checkout v3
• actions/cache v3
• actions/setup-node v3
• wearerequired/lint-action v2

.github/workflows/release-please.yml

• google-github-actions/release-please-action v3
• actions/checkout v3
• actions/setup-node v3

npm

package.json

• @types/jest ^29.5.1
• @types/node ^18.16.2
• @typescript-eslint/eslint-plugin ^5.59.1
• @typescript-eslint/parser ^5.59.1
• eslint ^8.39.0
• eslint-config-prettier ^8.8.0
• eslint-import-resolver-typescript ^3.5.5
• eslint-plugin-import ^2.27.5
• eslint-plugin-jest ^27.2.1
• eslint-plugin-regexp ^1.14.0
• jest ^29.5.0
• prettier ^3.0.0
• ts-jest ^29.1.0
• typedoc ^0.25.0
• typedoc-plugin-missing-exports ^2.0.0
• typescript ^5.0.4
• yarn 3.6.3

---

• Check this box to trigger a request for Renovate to run again on this repository