leuchtfeuer/typo3-image-gallery

Simple image gallery for TYPO3 using file collections.

typo3-image-gallery's Issues

Image Gallery does not respect File Metadata overrides

TYPO3 8.7.10
Image Gallery 2.0.1

File metadata will not show in frontend if date overwritten in file collection. Only meta data from filelist are shown.

Extend github workflow for coding standards in ci.yaml

Update coding standards in workflow ci.yaml:

• Move php-cs-fixer and custom config file to phpcs with PSR-12
• Add steps for phpstan and rector
• Provide a basic configuration for each step
• Delete .editorconfig file and thus prioritize the workflow

Add local php dev environment to run the coding standards

• Provided via ddev (as an alternative to workflow via act)
• Run the same coding standard tools as in workflow
• Later expandable for complete dev environment with TYPO3

Finally reformat / refactor the code according to the provided coding standards

Remove the newly introduced ter-upload workflow

In order to have better control over the release notes of the TER, there will be no automatic upload.
Instead, a manual upload will take place again at this point.

Remove functional test for fileFactory class that tests nothing

To make things easyier, remove empty functional test fileFactoryTest.php. This also applies to the workflow in file ci.yaml and composer.json Maybe unit tests can be added later.

Override constants

Its not possible to override the default constants for the template-/layout-/partialRootPath.

My constants:
tx_bmimagegallery {
view {
templateRootPath = EXT:my_ext/Resources/Private/Templates/Gallery/
partialRootPath = EXT:my_ext/Resources/Private/Partials/Gallery/
layoutRootPath = EXT:my_ext/Resources/Private/Layouts/Gallery/
}
}

but it always loads the default templates/layouts/templates... maybe i'm doing something wrong...

Pagination

Is your feature request related to a problem? Please describe.
If you have a lot of images, it would be nice to have a pagination,

Describe the solution you'd like
Add the new pagination to the extension.

shows only one image

I installed the extension in TYPO3 9.5.9, in list mode it only shows one image. I tried it in 2 different installations. I also checked the generated HTML Code.

Provide an .editorconfig file according to the TYPO3 coding guidelines

Remove documentation folder from .gitattributes

Provide Documentation/ folder for ZIP-Archives. Remove export-ignore statement in .gitattributes file. This also affects the script release.sh

Desription of the filecollection not available

Describe the bug
Desription of the filecollection not available in the frontent view. "Title" is there but not the value of the RTE-Field Description.

==================================================
<f:debug>{items}</f:debug>

array(2 items)
0 => Leuchtfeuer\BmImageGallery\Domain\Transfer\CollectionInfoprototypeobject
identifier => protected7 (integer)
title => protected'Kunst im Steinbruch' (19 chars)
description => protected'' (0 chars)
itemCount => protected19 (integer)
preview => protectedTYPO3\CMS\Core\Resource\Fileprototypeobject
richTextDescription => protected'' (0 chars)

============================================================

External manual link in TER links to the wrong repository

The External manual link in the TER links to this repositoy https://github.com/bitmotion/custom-error-page.
Instead of the correct one (this one) https://github.com/bitmotion/typo3-image-gallery.

Make detail view on different page work again

Scenario 2 (A list of galleries with gallery view on another page as the plugin) does not work. The GET parameters are not correct.

"Gallery Page" ?

Hi there,
I don't really understand why the CE Plugin needs to know the Page where the Gallery is on as the CE is allready on some page or is meant to be to have the CE somwhere else than the actuall Gallery?
Best
Stefan

Add a date and location field for sys_file_collection

Is your feature request related to a problem? Please describe.
It would make the extension perfect for showing event images, if each gallery would also have a date(time) and location field.
It would make the galleries sortable by these fields.

Describe the solution you'd like
Add the fields to the file collection

Describe alternatives you've considered
Putting stuff into the description field causes data to be less structured, allowing less flexible output rendering in Fluid.

Update PHP version matrix in workflow file ci.yaml

TYPO3 12 LTS supports PHP 8.1, 8.2, 8.3. In this sense, the integration job in ci.yaml should support the same PHP versions. Possibly revise the entire job.

TYPO3 12 LTS compatibility

Is your feature request related to a problem? Please describe.
I would like to use the bm_image_gallery with TYPO3 v12

Describe the solution you'd like
Release for TYPO3 v12

Describe alternatives you've considered
PR #28

Provide namespace for TYPO3 core viewHelper in templates and partials

Provide namespace for TYPO3 core viewHelper due to better support html templates within the IDE

Rename branch master to main

Deprecate Migrations for next major release

Add PHP-Deprecation Annotation toMigrations/Code/ClassAliasMap.php and Migrations/Code/LegacyClassesForIde.php for the next major release to clarify that these will no longer be included in the future.

Flexform Override

Hey guys,
today I updated to the latest version.

Is it possible to override the ControllerActions.xml ?

In the old extension I just had to override:

Folder: my_extension/Configuration/TCA/Overrides/tt_content.php

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue( 'bmimagegallery_list', 'EXT:my_extension/path/to/flexform/ControllerActions.xml' );

It doesn't work in the new one.

It's very important for me and I hope you can help me.

Translations with bm_image_gallery 4.1.0 in TYPO3 9.5.13

Hello,

I'm using the bm_image_gallery 4.1.0 in TYPO3 9.5.13 with english as default language and try to using german translations.

The configuration I'm using:
I'm using the gallery with a list and detail view.
On the list view are two file collections linked.
Both pages are translated into german including the content elements and the file collections.

The problem:
In the german translation the link is translated and is linking to the right german url.
But the file collections are not translated and still shwoing the english default title and descripton of the file collection on the details page and the list page.

When I'm linking the german translated file collections in the translated list plugin, the german translations are show up right on the list page (Titles). But it is still not working on the detail view.

Typoscript of the plugin is included.
The languages are set up correctly. For testing purpose I inserted some text blocks on the pages that get translated right.

Thank you very much in advange and best regards,
Sören W

TER Documentation link invalid

On TER, the link to the documentation leads to a 404 Not Found error:

The description field of sys_file_collection table can be null

Bug: the description field of the sys_file_collection table can be null on empty entries. In class CollectionInfo.php the constructor considered only string.

$this->setDescription($fileCollection->getDescription());

This leads to an exception, if the field contains null.

Solution: use the null coalescing operator

Route Enhancer Error

In a TYPO3 9.5.14 installation I try to use your route enhancer and get the following error:

Parameter "tx_bmimagegallery_list__show" for route "tx_bmimagegallery_list_0" must match "[^/]++" ("" given) to generate a corresponding URL.

Remove codecov.yml file

Remove the remaining codecov.yml file. Should be also removed in various scripts.

Gallery ignores sorting order

I set up a bm_image_Gallery in my Typo3 9.5.14 Environment.
The only problem I discovered, is that the plugin does not respect sorting order.

It respects at least the field for orderBy, but the field of sortingOrder keeps being ignored.
Is this a bug, or is there some other issue with my configuration? (eg. wrong "orderBy").

best regards,
Izaquiel Tomé

Wrong relAttribute

Not sure whether it's an issue or my fault, but I get a wrong relAttribute for fancybox.

html shows rel="fancybox-{field:uid}" while {field:uid} should be a number.

In partial Image.html
<f:debug>{settings.lightbox.relAttribute}</f:debug>
shows
'fancybox-{field:uid}' (20 chars)

fancybox is not working, only one image shows up.

ParseError syntax error, unexpected ')' after activating Simple Image Gallery in a 10.4.17 installation

This is the error message:

in /www/htdocs/.../typo3conf/ext/bm_image_gallery/Configuration/TCA/Overrides/sys_file_collection.php line 53

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addToAllTCAtypes(
'sys_file_collection',
'--div--;LLL:EXT:bm_image_gallery/Resources/Private/Language/locallang_be.xlf:bm_image_gallery_tab,' . implode(',', array_keys($temporaryColumns)),
);

Add missing null coalescing operator in CollectionInfo.php to prevent exception message

Prevent exception message:

Argument 1 passed to Leuchtfeuer\BmImageGallery\Domain\Transfer\CollectionInfo::setDescription() must be of the type string, null given, called in /var/www/html/public/typo3conf/ext/bm_image_gallery/Classes/Domain/Transfer/CollectionInfo.php on line 134

SQL definition for field "bm_image_gallery_description" is text. That means, In TYPO3 context, the default value is null.

In CollectionInfo.php:

• the description setter at row 78 defined $description as string
• the function call at row 134 only set origin database value
• if description field is empty th default value from DB is null
• the exception is thrown

To prevent the exception, add missing null coalescing operator to the function call.

$this->setDescription($properties['bm_image_gallery_description'] ?? '');

TYPO3 10.4.17 / bm_image_gallery 5.1.0

TYPO3 11.5

Hi,
Thanks for the nice extension. Do you plan an upgrade to the latest version?

Regards
Hobokens

Revision of the documentation and README.md file

Most content of the README.md file belongs in the documentation.
Complete and revise documentation and README.md file to make it clearer and easier to read.

Also move the contents of file Resources/Private/Examples/RouteEnhancer.yml into the documentation.

Providing a chapter for developers on how to run the github workflow locally

Plugin in as Content Element eg Gallery

May I suggest to have the PlugIn as an own Content Element in the Wizzard.
Thx

Empty file collection description

Describe the bug
Today I upgraded from from version 4.2.1 to 5.0.0. My TYPO3 instance is on 10.4.14. The file collection attribute 'description' is empty although field 'bm_image_gallery_description' was set in the backend.

To Reproduce
Debugging shows that in class Domain/Transfer/CollectionInfo.php method returns an empty string. The root cause is the wrong use of the null coalescing operator (??). With an empty string condition it returns an empty string, too. Using a ternary operator (?:) solves the problem.

Additional context
The following test code behaves the same in PHP 7 and 8: $x3 gets an empty string because isset()evaluates to true for an empty string.
$x1 = "";
print "x1: '".$x1."'\n";
$x2 = isset($x1);
print "x2: '".$x2."'\n";
$x3 = ($x1) ?? "some text";
print "x3: '".$x3."'\n";
$x4 = ($x1) ? $x1 : "some text";
print "x4: '".$x4."'\n";

Error in Typo3 9.5.5 (but not 8.7.24)

Hi.

I'm getting this error in a Typo3 9.5.5 (composer setup). I have the same version of the extension runing on 8.7.24 ('old school' installation setup with Extension Manager) without any issues:

Argument 1 passed to Bitmotion\BmImageGallery\Domain\Model\Dto\CollectionInfo::setPreview() must be an instance of TYPO3\CMS\Core\Resource\FileInterface, boolean given, called in ...../public/typo3conf/ext/bm_image_gallery/Classes/Domain/Model/Dto/CollectionInfo.php on line 28

Any ideas where I/it might be going wrong?

Thanks. If there is any further information I can provide, feel free to ask, of course!

Cheers

Exception if description field is empty

Describe the bug
Exception if the description field of the file collection is empty.

TYPO3 10.4.15
PHP 7.4.16
Composer mode

Core: Exception handler (WEB): Uncaught TYPO3 Exception: Argument 1 passed to Leuchtfeuer\BmImageGallery\Domain\Transfer\CollectionInfo::setDescription() must be of the type string, null given, called in /var/www/vhosts/REMOVED/private/typo3conf/ext/bm_image_gallery/Classes/Domain/Transfer/CollectionInfo.php on line 134 | TypeError thrown in file /var/www/vhosts/REMOVED/private/typo3conf/ext/bm_image_gallery/Classes/Domain/Transfer/CollectionInfo.php in line 78. Requested URL: https://REMOVED

Expected behavior
The description field of a file collection is optional and could be empty.