levbernstein/levquizbowlbot

A Quizbowl Discord bot written in Python.

Lev Bernstein

DevOps Automation Engineer at Broadridge, former DevOps Engineer at Zoom. NYU CS '2022.

• Personal Website
• LinkedIn

levquizbowlbot's Issues

Undoing a neg permanently decreases TUnum by 1

Undoing a neg should not decrease TUnum, as it should revert to the previous TUnum. Unsure of the cause.

!undo does not handle TUnum properly when undoing negs

It will always remove 1 from TUnum, which is not accurate to the game. Will be fixed by storing a backup of TUnum in the Backup class. I'll have a fix out later today, after class.

Scoresheet inaccuracies

Scoresheets are close to being fully implemented. I have attached a sample from a recent game played in the NYU Quiz Bowl Discord (it's a .csv file, but GitHub does not support attaching those. I have compressed it into a .zip). There are a few issues you might notice.

1. The TU scores on TU 10 are all jammed into one cell, and feature one quotation mark.
2. TU 11 is missing (Captain No-Beard got 10 on the TU and blue team got 30 on the bonus).
3. Doug Simons' scores are inaccurate; he is missing a power on TU 10.
4. Captain No-Beard's scores are inaccurate; he got a neg on TU 10 and a 10 on TU 11.
5. Natural Log's scores are inaccurate; he got a 10 on TU 12.
6. Several cells have line breaks included in the cell.
7. Michaelp's name is included twice in the player columns.
8. Blue team's bonus total is inaccurate (due to the missing 30 points on TU 11).
9. Total team scores are not yet implemented.

I will continue work on the scoresheets in order to fix these issues.

!start runs slower after implementing role autocreation

!start runs noticeably slower due to the get() command indexing every role in the server every time.
Will fix by moving role creation to a new command, !setup, in version 1.5.4.

Scores undone back to TU#0 still display teamscores: 0

Doesn't impact gameplay at all; it's also technically true, as the teamscores are, indeed, 0, there's just no need to display that to the user yet. Can be fixed with not displaying teamscores if len(scores) == 0.

Line 0 split into two lines

Example:

TU# | Red Bonus | Blue Bonus | Green Bonus | Orange Bonus | Yellow Bonus | Purple Bonus | apoorva
Captain No-Beard |   |   |   |   |   |   |  
0 | 30 | 30 | 0 | 0 | 0 | 0 | "100

Should read:

TU# | Red Bonus | Blue Bonus | Green Bonus | Orange Bonus | Yellow Bonus | Purple Bonus | apoorva | Captain No-Beard
0 | 30 | 30 | 0 | 0 | 0 | 0 | 100 | 100

There are other issues as well, as can be seen by the second 100 not being recorded; that, at least, is due to line 1 being split.

Bot attempts to parse images as strings

The bot examines every message to see if it's a command, including messages that are just people sending images. The bot tries to read the image like a string, which creates issues with the isInt() helper method. Full output here:

Ignoring exception in on_message
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/discord/client.py", line 333, in _run_event
await coro(*args, **kwargs)
File "QBBot.py", line 371, in on_message
if len(games) != 0 and isInt(text.content): # Assigns points. Checks len games to avoid unnecessary calls.
File "QBBot.py", line 30, in isInt
if st[0] == '-' or st[0] == '+':
IndexError: string index out of range