levizimmerman/fe3-assessment-2

🏆🏆 Frontend 3 · 2017-2018 · Assessment 2 starter code

fe3-assessment-2's Issues

You didnt update the description of the repo

The top line

Great job adding all this interaction. The representation could be better though

Overall you did a great job. But there might be more interesting ways to display this data than in an ordered bar chart. The x axis is kind of weird here (using the first letter for the type of business is a bit awkward). That's not what this ass. is about though as that's more the subject of ass. 3.

Nice mapping function ++

🍌

No link to live demo

Or I missed it?

Slicing fromt he first occurrence of 'A' might be a bit risky

Consider what might happen when you load similar files that just happen to have a different column order. I mean it works here but is not as dyamic as you might think

Nice examples of sort and filter

The way you set up filter you can also use it for ass3 🍑 So you're all set up!

Great documentation

The readme basically tells me all I need to know. Which is a good thing because your main code file is 600 lines long. Aint nobody got time for that!
Code comments are on point though.

Great work cleaning the data!

Bit early for a beer but thanks for the suggestion ;)