Giter Site home page Giter Site logo

Comments (6)

lkwg82 avatar lkwg82 commented on August 15, 2024

Would be happy to see a pull request as I dont see what you mean.

Thx in advanced, for the issue and the pr. ☺

from lint-maven-plugin.

ddossot avatar ddossot commented on August 15, 2024

Try the configuration shown in step 2. Your build will break because it doesn't contain an execution ID, which violates the ExecutionId rule.

from lint-maven-plugin.

lkwg82 avatar lkwg82 commented on August 15, 2024

My question was actually, what prevents you from 'press editing' on the Readme.md and fix it? :)

Discussing this issue may be helpful for the awareness but one has to do it finally.

from lint-maven-plugin.

ddossot avatar ddossot commented on August 15, 2024

Awesome question.

Before forking the project and submitting a pull request, I wanted to make sure that this proposal for correction was valid and was not related to my lack of understanding about how the plug-in works.

As a rule of thumb, I assume that a README is accurate and that if it didn't work for me, it's probably because of an error on my side.

I'll wait for a maintainer of this project to confirm that the README is indeed inaccurate. If that is the case, then I'll be happy to fork the project and submit a pull request.

Thank you.

from lint-maven-plugin.

lewisd32 avatar lewisd32 commented on August 15, 2024

Hey folks :)

I think it's definitely a good idea for any pom samples in the README of this project to pass the lint check, otherwise it's setting people up for confusion (as this conversation has nicely demonstrated 😄)

If someone wants to fix it up, I'll happily accept a PR.

Cheers!

from lint-maven-plugin.

lewisd32 avatar lewisd32 commented on August 15, 2024

Merged! Thanks again.

from lint-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.