Comments (6)
Would be happy to see a pull request as I dont see what you mean.
Thx in advanced, for the issue and the pr. ☺
from lint-maven-plugin.
Try the configuration shown in step 2. Your build will break because it doesn't contain an execution ID, which violates the ExecutionId
rule.
from lint-maven-plugin.
My question was actually, what prevents you from 'press editing' on the Readme.md
and fix it? :)
Discussing this issue may be helpful for the awareness but one has to do it finally.
from lint-maven-plugin.
Awesome question.
Before forking the project and submitting a pull request, I wanted to make sure that this proposal for correction was valid and was not related to my lack of understanding about how the plug-in works.
As a rule of thumb, I assume that a README is accurate and that if it didn't work for me, it's probably because of an error on my side.
I'll wait for a maintainer of this project to confirm that the README is indeed inaccurate. If that is the case, then I'll be happy to fork the project and submit a pull request.
Thank you.
from lint-maven-plugin.
Hey folks :)
I think it's definitely a good idea for any pom samples in the README of this project to pass the lint check, otherwise it's setting people up for confusion (as this conversation has nicely demonstrated 😄)
If someone wants to fix it up, I'll happily accept a PR.
Cheers!
from lint-maven-plugin.
Merged! Thanks again.
from lint-maven-plugin.
Related Issues (20)
- I feel like having non-test scoped <dependencies/> in a pom packaging project is something that could be checked by maven lint HOT 2
- Recommend <type>test-jar</type> over <classifier>tests</classifier>
- RedundantDependencyVersionsRule false positive HOT 5
- NPE while building HOT 10
- Status of this project HOT 11
- create violation for <execution></execution> block without id HOT 4
- Variable vs. literal confusion HOT 2
- onlyRunRules ignored on master HOT 10
- please connect with travis ci to have automatic PR builds (and more) HOT 2
- add an possibility to collect all violations of a reactor project HOT 1
- Clean up logic and documentation around <rules>, <onlyRunRules>, -Drules
- The 'list' goal has been broken since 0.0.9 HOT 1
- .
- Feature request: Option to warn on multiprojects
- IllegalStateException: RedundantDependencyVersionsRule with maven expressions HOT 8
- Feature request: Warn on missing test functionality
- Feature request: Block springframework starter artifactIds HOT 2
- NPE in GAVOrder rule HOT 2
- Make it easier to configure which rules are desired HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lint-maven-plugin.