lezer-parser/cpp

C++ grammar for the Lezer parser system

cpp's Issues

Update TypeScript exports to support moduleResolution bundler

moduleResolution: "bundler" is a recent setting added to TypeScript to support bundler setups. It's the setting you should probably be using when bundling code. With this setting TypeScript only searches for types in the exports field of the package.json.

It requires the following change:

 "exports": {
   "import": "./dist/index.js",
   "require": "./dist/index.cjs",
+  "types": "./dist/index.d.ts"
 },

This is issue is relevent to multiple @lezer packages I'm using.

wrong affinity of pointer-star in function type

source

void* some_function() {}

actual parse tree

FunctionDefinition: "void* some_function() {"
  PrimitiveType: "void"
  PointerDeclarator: "* some_function()"
    FunctionDeclarator: "some_function()"
      Identifier: "some_function"
      ParameterList: "()"
        (: "("
        ): ")"
  CompoundStatement: "{"
    {: "{"
    }: "}"

actual affinity: void (* some_function)
expected affinity: (void *) some_function

actual vs expected parse tree

 FunctionDefinition: "void* some_function() {"
-  PrimitiveType: "void"
-  PointerDeclarator: "*some_function()"
-    FunctionDeclarator: "some_function()"
+  CompoundType: "void*"
+    PrimitiveType: "void"
+    PointerStar: "*"
+  FunctionDeclarator: "some_function()"
       Identifier: "some_function"
       ParameterList: "()"
         (: "("

same bug in tree-sitter-cpp, see playground

expected parse tree per clang

{
  "kind": "FunctionDecl",
  "name": "some_function",
  "type": {
    "qualType": "void *()"
  },
  "inner": [
    {
      "kind": "CompoundStmt",
    }
  ]
}

Large buffer of non C++ text results in RangeError: Maximum call stack size exceeded

Hi!

Using the C++ parser in Codemirror together with a large buffer of HTML text results in a RangeError: Maximum call stack size exceeded error.

The following code in the Try Codemirror reproduces the error:

import {basicSetup, EditorView} from "codemirror"
import { cpp } from "@codemirror/lang-cpp"

let view = new EditorView({
  doc: getContent(),
  extensions: [
    basicSetup,
    cpp(),
  ],
  parent: document.body
})


function getContent() {
  const urlStr = `<url>
<loc>https://example.org</loc>
</url>`
  return `<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
${[...Array(500)].map(() => urlStr).join("\n")}
</urlset>
`;
}

I understand that this is not proper use of the C++ parser, and I don't expect it to produce good syntax highlighting for that content, but I guess that it still shouldn't throw an exception. I imagine it could cause issues for an editor that lets the user manually change the current language if they accidentally chooses C++ for a large HTML-file.