libersys/rtp-ogg-opus

RTP Ogg/Opus Tools for NodeJS

rtp-ogg-opus's Issues

Build is broken on Mac OS

When I try to build on Mac OS, I get the following errors:

../src/helpers.cc:130:9: error: cannot use 'throw' with exceptions disabled
        throw std::invalid_argument("Couldn't allocate data buffer.");
        ^
../src/helpers.cc:136:9: error: cannot use 'throw' with exceptions disabled
        throw std::invalid_argument("Couldn't allocate Ogg packet.");
        ^
../src/helpers.cc:160:20: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
    char *vendor = "rtp-ogg-opus using libopus";
                   ^
../src/helpers.cc:168:9: error: cannot use 'throw' with exceptions disabled
        throw std::invalid_argument("Couldn't allocate data buffer.");
        ^
../src/helpers.cc:174:9: error: cannot use 'throw' with exceptions disabled
        throw std::invalid_argument("Couldn't allocate Ogg packet.");
        ^
2 warnings and 4 errors generated.
make: *** [Release/obj.target/rtpoggopus/src/helpers.o] Error 1

I resolved this by adding the following to binding.gyp:

"conditions": [
    ['OS=="mac"', {
       "xcode_settings": {
          "GCC_ENABLE_CPP_EXCEPTIONS": "YES"
       }
   }]
],

I just grabbed this snippet from here, I'm not sure if it's actually a good fix or not. rla/fast-feed#8

I'm using your package to take an RTP stream from mediasoup and package an OGG-Opus stream to send to Google's speach-to-text API. So far it seems to be working great. Thanks!

Doesn't build on Apple Silicon Mac

Not sure if this repo is maintained anymore, I tried seeing if I could fix, but just reporting here that it does not seem to build on Mac arm64. Probably related to discordjs/opus#98, getting this error:

gyp info spawn make gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ] CC(target) Release/obj.target/libogg/deps/libogg/src/framing.o CC(target) Release/obj.target/libogg/deps/libogg/src/bitwise.o LIBTOOL-STATIC Release/ogg.a CC(target) Release/obj.target/libopus/deps/libopus/src/opus_multistream.o ../deps/libopus/src/opus_multistream.c:29:10: fatal error: 'config.h' file not found #include "config.h" ^~~~~~~~~~

I was able to copy over the config.h file from @discordjs/opus, but still got this error:

In file included from ../deps/libopus/silk/SigProc_FIX.h:51: ../deps/libopus/silk/arm/biquad_alt_arm.h:31:11: fatal error: 'celt/arm/armcpu.h' file not found # include "celt/arm/armcpu.h" ^~~~~~~~~~~~~~~~~~~