Giter Site home page Giter Site logo

Comments (2)

martinjaeger avatar martinjaeger commented on August 15, 2024

Shunt Temperature Measurement: I'm exploring the bms_c1.dts file to understand shunt temperature measurement. I couldn't locate the configuration for the DFETOFF pin. Is shunt temperature currently measured and used to trigger alerts in the BMS system?

The shunt temperature measurement was only added for BMS C1 v0.4 board. It is not yet supported by the firmware.

Default Values in BQ769X2_INIT Macro: I'm curious about the configuration of temperature and discharge pins in the BQ769X2_INIT macro. While ts1_pin_config has a default value of 0x07, ts3_pin_config and dchg_pin_config seemingly don't. Could you explain the thinking behind this distinction?

Yes, that's to mimic the default behavior of the chip. The actual desired values of used sensors should be set via board .dts file.

DCHG Pin Configuration: In the code, dchg_pin_config is set to the default value (0x07). The BQ769X2 datasheet (section 6.4) recommends 0x0F for FET temperature measurement. I'm curious to understand the reasoning behind using the default value in this case.

Yep, that's wrong. The configuration for the FET temperature sensor should indeed be 0xF. Thanks for noticing. If you like, feel free to submit a PR with a fix.

from bms-firmware.

Ananyaaynana avatar Ananyaaynana commented on August 15, 2024

Thank you for the reply.
Sure, I will submit a PR request with the fix.

from bms-firmware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.