libscie/credit-roll

Create markdown credits for JavaScript projects

credit-roll's Issues

Add contributors

This issue should not be closed, because it is an easy way to activate the all-contributors bot when needed. :)

Old comments to the bot will be deleted for overview purposes.

Load contributors from multiple sources

— TBD —

generating credit roll breaks when dependency has invalid JSON in package.json

Description

If you have [email protected] as a dependency, there is a malformed_package_json subdependency that has an intentionally malformed package.json with contents:

{

When you try to generate credits on a project with this dependency it isn't able to parse that JSON and breaks:

<!-- This document was automatically generated through `credit-roll`. Please don't edit it directly. -->

# Credits

This project is made possible by the community surrounding it and especially the wonderful people and projects listed in this document.

## Libraries

SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at main (<redacted>\node_modules\credit-roll\index.js:62:22)

Expected behaviour

I'm not sure if it should simply skip any packages that have unparseable JSON but at the very least it should not break.

To reproduce

add dependency [email protected] and run credit-roll on it.