lidofinance/lido-l2

lido-l2's Issues

Proposal for Implementing ERC-2612 and ERC-1271 Support for (w)stETH on L2

As part of the recent Lido V2 upgrade, we've successfully incorporated both ERC-2612 and ERC-1271 standards for stETH. These changes were made in anticipation of the impending Account Abstraction on Ethereum, ensuring our platform remains at the forefront of industry developments.

In light of this progress, We should extend the same support for the wstETH bridged counterpart on Layer 2 (L2). Beyond upgrading Arbi/Optimism, incorporating these standards should be considered a fundamental feature for all future L2 extensions.

L2 bridge missing EOA check for withdraw

Optimism standard L2 token bridge (onlyEOA modifier):

function withdraw(
    address _l2Token,
    uint256 _amount,
    uint32 _minGasLimit,
    bytes calldata _extraData
) external payable virtual onlyEOA {
    _initiateWithdrawal(_l2Token, msg.sender, msg.sender, _amount, _minGasLimit, _extraData);
}

For the wstETH version, this check is missing:

function withdraw(
    address l2Token_,
    uint256 amount_,
    uint32 l1Gas_,
    bytes calldata data_
) external whenWithdrawalsEnabled onlySupportedL2Token(l2Token_) {
    _initiateWithdrawal(msg.sender, msg.sender, amount_, l1Gas_, data_);
}

However, it should have been there due to known design decision of Optimism.

L1 Bridge does not work with SCWs

The L1 ERC20 token bridge reverts if the sender is an SCW:

lido-l2/contracts/optimism/L1ERC20TokenBridge.sol

Lines 58 to 60 in 471993c

	if (Address.isContract(msg.sender)) {
	revert ErrorSenderNotEOA();
	}