liftedinit/alberto

A crypto wallet for any ledger supporting the Many protocol

Alberto

Alberto by Lifted Labs is a cryptocurrency wallet that can hold identities and manage communications with a ledger running as a module on a network that supports the Many Protocol.

Getting Started

To start Alberto, install dependencies and then run locally.

npm install
npm start

e2e Testing

• Start up local many-server. ex: run ./scripts/run.sh in many-framework
• Make a duplicate of e2e/.env.example and name it .env in e2e/. Result should be e2e/.env
• Edit the variables in e2e/.env if needed
  • If address (...wijp) below differs from what's found in ledger_state.json5 in many-framework, change MAIN_WALLET_PEM to be the PEM file of that address. Otherwise, keep the default.

  initial: {
      "maffbahksdwaqeenayy2gxke32hgb7aq4ao4wt745lsfs6wijp": {
          "MFX": 1000000000
      }
  },
  

  • Three seed phrases are already included. Change them if you prefer to use different ones.
• Run npm run test:e2e to run playwright tests locally

Alberto will also be available on mobile devices as an "installable" progressive web application via GitHub Pages once this repository has been made publicly available.

Web3auth

• Lifted web3auth dashboard: https://dashboard.web3auth.io/
• Users dashboard: https://app.openlogin.com/

Version

Alberto is currently pre-release alpha software, so incrementing the version (which will trigger creating a GitHub Release) is best accomplished with the following command:

npm version prerelease --preid alpha

alberto's Issues

User can see their account identity on the ledger web app

Should see the checksum of an address in address field

Any fields showing the address should show the checksum (the last 4 letters) to ensure this is the right address. Especially on Desktop there's no horizontal space limitation.

`package-lock.json` liftedinit/ui package points to a fork

When running a raw npm install on this repo, I get the following diff in package-lock.json:

diff --git a/package-lock.json b/package-lock.json
index 75c3701..96e8fd7 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -14,7 +14,7 @@
         "@emotion/styled": "^11.8.1",
         "@fontsource/roboto": "^4.5.8",
         "@liftedinit/many-js": "^0.1.0-alpha.5",
-        "@liftedinit/ui": "github:stanleyjones/lifted-ui#page-container",
+        "@liftedinit/ui": "github:liftedinit/lifted-ui",
         "@web3auth/openlogin-adapter": "^2.1.3",
         "@web3auth/web3auth": "^2.1.3",
         "framer-motion": "^6.2.8",
@@ -4984,7 +4984,7 @@
     },
     "node_modules/@liftedinit/ui": {
       "version": "0.1.0",
-      "resolved": "git+ssh://[email protected]/stanleyjones/lifted-ui.git#11ff6ad2488a0876140f26072fd2e2c9d78a2596",
+      "resolved": "git+ssh://[email protected]/liftedinit/lifted-ui.git#1fc4abe2c2ae9115cc1467d8aff90f443f62465a",
       "dependencies": {
         "@chakra-ui/react": "^1.8.6",
         "@emotion/react": "^11.8.2",
@@ -31165,8 +31165,8 @@
       }
     },
     "@liftedinit/ui": {
-      "version": "git+ssh://[email protected]/stanleyjones/lifted-ui.git#11ff6ad2488a0876140f26072fd2e2c9d78a2596",
-      "from": "@liftedinit/ui@github:stanleyjones/lifted-ui#page-container",
+      "version": "git+ssh://[email protected]/liftedinit/lifted-ui.git#1fc4abe2c2ae9115cc1467d8aff90f443f62465a",
+      "from": "@liftedinit/ui@github:liftedinit/lifted-ui",
       "requires": {
         "@chakra-ui/react": "^1.8.6",
         "@emotion/react": "^11.8.2",

Not sure if this impacted production.

User can see portfolio as a single chart

Frontend should error _before_ allowing to finish the send flow if token isn't selected

There's no message to the user (outside of an error in the console). The "Next" button should not be enabled and/or a message should be showing that the field is required.

Adding an invalid address in contacts should be an error

Right now it doesn't validate the identity address. It should.

Memos should be an array not a string

From Malcolm:

Just tried to do a test transaction for an investor who is exercising his tokens, and got this error…

The problem seems to be in the front-end (both ManyJS and Alberto) expecting memo to be a string instead of an array of strings.

See Hans' initial PR here: liftedinit/many-js#95

On new tags, create a release including a downloadable static build

Rename repository to "alberto"

All of the other branding issues have been resolved as of #86.

Website should say "Alberto" instead of "Albert" everywhere

This can also rename the repo but the content of the website is more important.

Multisig Transactions should have routes

So I can bookmark / send URLs for people to approve.

Visual styling for Send Transaction flow

Scale center wallet area with the browser

Resize the center area of the wallet with the browser size.

Normal sized window

Pulled out browser, no scaling

Visual styling for Home page

Wallet (Alpha)

Laundry List:

• Update the Wallet to the latest MANY protocol.
• Add transaction list to accounts.
• Implement / Update / Improve on the wireframes and UX.

Add BAZEL as a build system

Export/Import Contacts

Add a feature to be able to export/import the Contact list.

Component library

We should incorporate a customizable component library so we don't need to re-invent the wheel for common UI components and so that we can re-use these components for any future projects.

BrowserStack integration tests for Albert running locally

Resize Activity window

The Activity window displays a horizontal slider when the transaction amount is large, even if there is a lot of free space on the screen. We should make better use of screen real estate.

[tracking] QSP-7 User might use untrusted authenticators

• add copy to UI when creating an identity via hardware authenticator to use recommended security keys
  cc @fmorency @hansl

Bug: when using the page button (on Anonymous) to add a new address, recall phrase doesn't show

Using the Add Account button in the account dropdown works fine, but using the one on the page doesn't show the recall phrase.

Repro steps:

• Open private window to alberto
• See green button, press green button
• Create a new Hardware Authenticator identity
• Go through the process
• No recall phrase popup shows up, account is logged in.

Rework "Send" window flow

From @ebravick

In the "send" function we have a left-to-right flow, I have an element on the left and the "chooser" on the right that matches with that. So "TO" matches with "Select a contact". That works, and everyone gets it.

But next, we have "Amount" which is matched to "Select an asset". This is confusing for people, and always causes them to pause - they are expecting a "chooser" that is amounts, like 1,10,50 or some +/- button thing to fill in an amount.

The second element on the left should be "Asset Type" and that should be paired with "Select an Asset".

The amount should be moved down to be the 3rd element, and can have a selector or not if that makes sense from a UI perspective, or just a place to fill in the number.

Add support for async status envelope return value

Albert should support both ResponseMessage and CoseSign1 as async.status return value.

We can remove the ResponseMessage support after merging the fix in many-rs, many-framework and many-js

MS Edge user should be able to create a hardware account

From Slack (https://liftedinit.slack.com/archives/C02C91EMFDK/p1669833507384309):

Hey Lifted team! I have an Alberto wallet-specific question...not sure where to put it so putting it in #general I'm currently helping node owners create their wallet with HSMs...but one NP is having trouble getting his windows laptop to recognize the ledger device during the Alberto account creation process...nothing happens at this point and the request times out. (we've DL'ed FIDO U2F)

OS: Windows
Browser: Edge (?)

Update: a second user with a Ledger and Windows machine cannot get past the external security key prompt in creating an account on Alberto.

Current wallet setup instructions:
Lifted Node Program_ Wallet Setup.pdf

Responsive layout

We only have designs for one screen width right now.
We should have at least one more size to handle widths of 768px and up.

Visual styling for Splash page

User can send a transaction

State is persisted between sessions

Create a release script

Create a release.sh script, or similar. See https://github.com/liftedinit/many-rs/blob/main/release.sh

The script should

• Update the CHANGELOG.md file (using git cliff, see many-rs)
• Update the project version number everywhere
• Create a new tag and a new chore commit on main

Transaction Detail view should scroll

Describe the bug

When launching the app from a transaction link, the view does not scroll. Approving a multi-signature transaction potentially requires resizing the browser or adjusting the scale if the approval button is off the screen.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://alberto.app/#/transactions/OBFnAAAAAg%3D%3D
2. Adjust screen so approval button is not visible.
3. Attempt to scroll down to click the button.

Expected behavior

The screen should scroll if there's content below the fold.

Screenshots

Desktop (please complete the following information):

• MacOS 12.6
• Safari
• 16.0

Additional context

Scrolling works correctly if you navigate to the transaction via the Accounts > Activity > Transaction flow.

Update Alberto packages and node version

As a User I want to be able to watch other accounts from my wallet, without having the private key (read-only), by having their identity string.

Disable `Hardware Authenticator` entry if neighborhood doesn't support it

Some neighborhood, such as kvstore, dweb and compute, don't implement the idstore module. We should disable the ability to create/import Hardware Authenticator when such a neighborhood is selected.

We should also display a message if a neighborhood doesn't support the HSM feature.

@stanleyjones

Use code-splitting to reduce app size

Memos should display in multi-sig transactions

With the deploy of RC14 to production, memos are no longer visible in Alberto multi-sig transactions.

Implement Accounts

Is your feature request related to a problem? Please describe.

• We should be able to view accounts and create transactions on behalf of them.
• we should be able to view the transactions once they've been created
• we should be able to view the accounts assets/balance

Transactions that are not pending should not show action buttons on their details

And should show the state in the transaction details.

User can add recipients

add warning for Safari users trying to use Ledger

Per LedgerHQ/app-u2f#7, we should add a warning for users about Ledger having issues with Safari.

Credential IDs and recall phrases could be saved in local storage

It would save a few steps on refresh, and it's not private information.

Multi-sig transactions should show the correct expiration date

CURRENT

Looks like a milliseconds to seconds conversion is off somewhere.

edit account description and roles

Is your feature request related to a problem? Please describe.
we should be able to edit the account description and roles and call the API's from liftedinit/many-js#60

• API to call might change depending on what comes from many-protocol/specification#49

User can list transactions

Code coverage and badge

Add support for code coverage and add a code coverage badge in the README.

e2e testing in CI

Run e2e testing in CI

View and modify accounts multisig settings

• we should be able to view multisig account settings such as threshold, expire time, and automatic execution and be able to modify them.

Visual styling for "Add X" pages

[Explore] Web3Auth proof of concept for Alberto

This is exploratory to get a better size on the actual implementation.

Roadmap card: https://coda.io/d/Product-Roadmap_dy8ELW7g9Pn/Roadmap_su7wv#Prioritized-Backlog_tuaKs/r62&view=modal

Use web3auth for creating identities/accounts

users should be able to create identities with socials or email passwordless

related: liftedinit/roadmap#4