liip/liiptranslationbundle

Tools for translation management

liiptranslationbundle's Issues

make a first stable release

Add the edit option in the import module

Translation extractor?

As of this moment I'm using JMS Translation bundle which is quite terrific but has not been actively maintained for a while. Anyhow, it as a very good support for message extractor which makes it super fast and easy to populate the trans list by scanning existing code.

I wonder if there is any plan for it. In any case I could use both bundles at the same time but I would prefer to use only one if possible. :)

Fix the configuration parsing to have default values for all

Support for doctrine storage

Hello,

Given that Doctrine is the primary lib used in SF2, is there any plan to implement support for it soon?

Mechanism to prune old Unit should exist...

Currently, if you remove units from the master file, there is no remove on the intermediate storage. Such mechanism should exist...

Adapt CONTRIBUTING.md

https://github.com/liip/LiipTranslationBundle/blob/master/CONTRIBUTING.md

Allow to display read-only columns in the translation interface

Create a command translation:new

Should be used by developers to insert into xliff. Asking for description, min/max constraint, regex, etc...

Extend the trans() method to identify missing translation keys in dev mode

Add a screenshot to the doc

PCRE.backtrack_limit reached when using YamlFilePersistence

...
src/Acme/MyBundle/Resources/translations/messages.fr.yml  >> OK

  [Symfony\Component\Yaml\Exception\ParseException]                                                                                                                            
  pcre.backtrack_limit reached at line 8619 (near "- "<p>\n    Welcome to the ...... my long translation")

Exception trace:
 () at vendor/symfony/symfony/src/Symfony/Component/Yaml/Parser.php:245
 Symfony\Component\Yaml\Parser->parse() at vendor/symfony/symfony/src/Symfony/Component/Yaml/Parser.php:185
 Symfony\Component\Yaml\Parser->parse() at vendor/symfony/symfony/src/Symfony/Component/Yaml/Parser.php:185
 Symfony\Component\Yaml\Parser->parse() at vendor/symfony/symfony/src/Symfony/Component/Yaml/Parser.php:185
 Symfony\Component\Yaml\Parser->parse() at vendor/symfony/symfony/src/Symfony/Component/Yaml/Yaml.php:67
 Symfony\Component\Yaml\Yaml::parse() at src/Liip/TranslationBundle/Persistence/YamlFilePersistence.php:163
 Liip\TranslationBundle\Persistence\YamlFilePersistence->loadFile() at src/Liip/TranslationBundle/Persistence/YamlFilePersistence.php:157
 Liip\TranslationBundle\Persistence\YamlFilePersistence->loadFiles() at src/Liip/TranslationBundle/Persistence/YamlFilePersistence.php:50
 Liip\TranslationBundle\Persistence\YamlFilePersistence->getUnits() at src/Liip/TranslationBundle/Repository/UnitRepository.php:73
 Liip\TranslationBundle\Repository\UnitRepository->loadAll() at src/Liip/TranslationBundle/Repository/UnitRepository.php:98
 Liip\TranslationBundle\Repository\UnitRepository->findAll() at src/Liip/TranslationBundle/Repository/UnitRepository.php:104
 Liip\TranslationBundle\Repository\UnitRepository->getAll() at src/Liip/TranslationBundle/Repository/UnitRepository.php:110
 Liip\TranslationBundle\Repository\UnitRepository->getAllByDomainAndKey() at src/Liip/TranslationBundle/Import/SymfonyImporter.php:110
 Liip\TranslationBundle\Import\SymfonyImporter->processImportOfStandardResources() at src/Liip/TranslationBundle/Command/ImportCommand.php:71
 Liip\TranslationBundle\Command\ImportCommand->execute() at vendor/symfony/symfony/src/Symfony/Component/Console/Command/Command.php:244
 Symfony\Component\Console\Command\Command->run() at vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:904
 Symfony\Component\Console\Application->doRunCommand() at vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:191
 Symfony\Component\Console\Application->doRun() at vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:96
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:121
 Symfony\Component\Console\Application->run() at app/console:36

Once this has been done, the interface throws this error :

FatalErrorException: Error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 25568356 bytes) in vendor/symfony/symfony/src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php line 108
in vendor/symfony/symfony/src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php line 108
at ErrorHandler??handleFatal() in vendor/symfony/symfony/src/Symfony/Component/Debug/ErrorHandler.php line 0
at ??mb_strripos() in vendor/symfony/symfony/src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php line 108
at WebDebugToolbarListener??injectToolbar() in vendor/symfony/symfony/src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php line 89
at WebDebugToolbarListener??onKernelResponse() in vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php line 0
at ??call_user_func() in vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php line 450
at ??Symfony\Component\HttpKernel\Debug\{closure}() in app/cache/dev/classes.php line 0
at ??call_user_func() in app/cache/dev/classes.php line 1759
at EventDispatcher??doDispatch() in app/cache/dev/classes.php line 1692
at EventDispatcher??dispatch() in app/cache/dev/classes.php line 1856
at ContainerAwareEventDispatcher??dispatch() in vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php line 139
at TraceableEventDispatcher??dispatch() in app/bootstrap.php.cache line 2864
at HttpKernel??filterResponse() in app/bootstrap.php.cache line 2888
at HttpKernel??handleException() in app/bootstrap.php.cache line 2823
at HttpKernel??handle() in app/bootstrap.php.cache line 2947
at ContainerAwareHttpKernel??handle() in app/bootstrap.php.cache line 2249
at Kernel??handle() in app/AppKernel.php line 89
at AppKernel??handle() in web/app_dev.php line 41
at ??{main}() in web/app_dev.php line 0

Retrieved the modification date from the metadata

See: https://github.com/liip/LiipTranslationBundle/blob/master/Model/Translation.php#L81

Symfony 3.x support?

I see a branch by @dbu, however it doesn't really look like it's ready to use. Is the bundle still actively maintained, and is Symfony 3.x support planned? Or are there any alternate bundles you might know of that would support inline translation editing?

UPD. LexikTranslationBundle exposes a REST endpoint, adding some Twig extensions there should be the way to inline editing: https://github.com/lexik/LexikTranslationBundle/blob/master/Resources/doc/index.md

Configure Jenkins and phpcs

Handle security by domain

https://github.com/liip/LiipTranslationBundle/blob/master/DependencyInjection/LiipTranslationExtension.php#L65

Compatibility with sonata admin bundle

Hi,
Does your bundle compatible with sonata admin bundle, can it be shown in there ?

Integration with CreateBundle to edit translation in-place in the frontend

It would be awesome to allow inline editing of translation strings in the frontend with the CreateBundle. The user could edit the text right at the place where it is displayed.

We would need to come up with something clever how to display translations for this use case, as the HTML needs additional markup around each such string...

Ajaxify the remove action

Add "save and next" in the edit window

Add "filter by date" in the filter form

Allow to configure include/exclude list for the standard ressources

See: https://github.com/liip/LiipTranslationBundle/blob/master/Import/SymfonyImporter.php#L65

fix HHVM support

see https://travis-ci.org/liip/LiipTranslationBundle/jobs/45996579

63.46s$ phpunit --coverage-text && phpunit Tests/Controller/SecurityTest.php
PHPUnit 4.4.0 by Sebastian Bergmann.
Configuration read from /home/travis/build/liip/LiipTranslationBundle/phpunit.xml.dist
....F............................
Time: 1.03 minutes, Memory: 64.63Mb
There was 1 failure:
1) Liip\TranslationBundle\Tests\Controller\ImportControllerTest::testProcessing
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'new_value2'
+'value2'

Broken layout on new installation

Hi, thanks for this useful bundle.

I've just installed it and this is what is see for /translation/list:

I've run assets:install but it's still shown like that, look broken to me. Inline editing is not working either, but I don't see any Javascript error.

Thanks for any insight.

Describe configuration options

Convert config from yml to xml

hint: http://xmltoyaml.com/xml-to-yaml

Naming conventions

The commands in this bundle are called translation:<thing> - the naming convention would be liip:translation:<thing>. should we change this prior to the 1.0 release?

[GitPersistence] Sanity check whether the target folder is the translations git repository

I just had a problem not having initialized the translation folder, resulting in pullTranslations looking at the containing git repository of my project.

a simple check could be to look for the .git folder in the location where the translations are expected to exist and report if that is not a git repository.

/cc @thormeier