limechain/hashport-contracts

The EVM Smart Contracts of Hashport

hashport-contracts's Issues

Add Fee Policy contracts

1. Define IFeePolicy interface contract which will abstract all different fee policies that will be implemented.
   • Method feeAmount(uint256 _amount) returns (uint256)
2. Implement this interface for
   • PercentageFee (% of overall transaction amount)
   • FlatFee (flat token amount fee)

These contracts will be deployed on a per-user and per-asset basis which will have a specific service fee policy for porting usage. Once deployed, should be updated in the LibFeeCalculator user -> fee policy mapping.

The contracts' owner will be the multi-sig gnosis wallet governing the router contracts themselves.

User Stories

Update the README section for the contracts

verify Avalanche Router on mainnet

Please verify the avalanche Router address:  0xd8df34A071179fe8CEF910Ae0B43cdE49D611B49 on mainnet. You will need to checkout to the last commit before the deployment c26ee04 and pass the same order of the facets as in the router constructor.

Setup contract deployment script

• adding tests

Update LibFeeCalculator to check for user-specific fee policies

Relevant contract

1. Add a mapping to FeeCalculator for user address -> token address -> fee policy:
   • mapping(address => mapping(address => IFeePolicy)) feePolicies
2. Add functions to set and remove fee policies from the mapping
   • setFeePolicy(address _user, address _token, IFeePolicy _policy)
   • deleteFeePolicy(address _user, address _token, IFeePolicy _policy)
3. In distributeRewards(address _token, uint256 _amount) before L85 check the mapping for a set fee policy for the msg.sender. If such exists, call the policy feeAmount() to get the service fee.

User Stories

Test hashport smart contracts under Hedera EVM - Sept2022

Deploy and test the Hasport smart contracts (diamond) under Hedera EVM.
TODO: check around Sept-Oct2022

Slither CI has changed its supported flags

Slither version 0.9.0 has:

• removed the --ignore-reurn-value flag (which we use)
• introduced --fail-on<pedantic,medium,high>, with --fail-on-pedantic as default

-

support for wrapped erc721 enumerable

• add support for WrappedERC721 to implement ERC721Enumerable

Set code formatting with prettier

Update Contracts ReadMe

Transfer the info from the Deployment Sequence file from Notion.