lindenbergresearch/lrtrack

LRT Audio-Modules for VCVRack

lrtrack's Issues

build fail with latest pull

Fedora 23 Linux
VCV Rack 0.6.2b

g++ -Wsuggest-override -std=c++11 -DSLUG=LindenbergResearch -fPIC -I../../include -I../../dep/include -DVERSION=0.6.2_beta-5 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/dsp/LambertW.cpp.o src/dsp/LambertW.cpp
src/dsp/LambertW.cpp:18:17: error: ‘dsp’ is not a namespace-name
using namespace dsp;
^
src/dsp/LambertW.cpp:18:20: error: expected namespace-name before ‘;’ token
using namespace dsp;

More errors follow, I think they all stem from the namespace error. Any suggestions for fixing ?

VCO release

I see a VCO svg file in the res folder. When will you think that you will be able to release it. The graphics looks nice. The parameters seems like there is something all new going on with the standard 4 waveforms.

FrameBufferWidget error

Almost there now:

g++ -Wsuggest-override -std=c++11 -fPIC -I../../include -I../../dep/include -DSLUG=LindenbergResearch -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/LRComponents.cpp.o src/LRComponents.cpp
src/LRComponents.cpp: In constructor ‘SVGRotator::SVGRotator()’:
src/LRComponents.cpp:240:42: error: cannot call constructor ‘SVGRotator::FramebufferWidget’ directly [-fpermissive]
FramebufferWidget::FramebufferWidget();
^
src/LRComponents.cpp:240:42: note: for a function-style cast, remove the redundant ‘::FramebufferWidget’
../../compile.mk:57: recipe for target 'build/src/LRComponents.cpp.o' failed
make: *** [build/src/LRComponents.cpp.o] Error 1

Changing the line to simply FrameBufferWidget(); does allow the build to complete.

v1 build fail Information Widget

Fedora 23 Linux
VCV Rack v1.dev.3f513e1
GCC 5.3.1

I've hit another error:

$ make
g++  -std=c++11 -Wsuggest-override  -fPIC -I../../include -I../../dep/include -MMD -MP -g -O3 -march=athlon-fx -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/widgets/InformationWidget.cpp.o src/widgets/InformationWidget.cpp
src/widgets/InformationWidget.cpp: In member function ‘virtual void lrt::InformationWidget::draw(const rack::widget::Widget::DrawArgs&)’:
src/widgets/InformationWidget.cpp:30:64: error: ‘struct rack::Window’ has no member named ‘stats’
     string fps = stringf("FPS    => %05.2f", APP->window->stats.fps);
                                                                ^
src/widgets/InformationWidget.cpp:31:71: error: ‘struct rack::Window’ has no member named ‘stats’
     string duration = stringf("TIME   => %05.2fms", APP->window->stats.duration * 1000);
                                                                       ^
src/widgets/InformationWidget.cpp:32:66: error: ‘struct rack::Window’ has no member named ‘stats’
     string gpu = stringf("GPU    => %05.2f%%", APP->window->stats.gpu);
                                                                  ^
src/widgets/InformationWidget.cpp:57:46: error: ‘struct rack::Window’ has no member named ‘stats’
     float c = box.size.x / APP->window->stats.buffersize;
                                              ^
src/widgets/InformationWidget.cpp:61:43: error: ‘struct rack::Window’ has no member named ‘stats’
     for (int i = 0; i < APP->window->stats.buffersize; i++) {
                                           ^
src/widgets/InformationWidget.cpp:62:31: error: ‘struct rack::Window’ has no member named ‘stats’
         h = APP->window->stats.curve[i];
                               ^
src/widgets/InformationWidget.cpp: In constructor ‘lrt::InformationWidget::InformationWidget()’:
src/widgets/InformationWidget.cpp:97:23: error: ‘struct rack::Window’ has no member named ‘stats’
     APP->window->stats.interval = 2;
                       ^
../../compile.mk:61: recipe for target 'build/src/widgets/InformationWidget.cpp.o' failed
make: *** [build/src/widgets/InformationWidget.cpp.o] Error 1

Hopefully it's an easy fix. :)

Vampyr drive cv too responsive

I could not figure out what range to use for the drive cv on the vampyr filter even an extremely small amount of voltage was too much.
I think it's way too sensitive..
Love the sound

Greetings Peter.

Alma Filter

Your grandmother would be proud. The Alma Filter is all buttermilk, Brah.

LRTRack v0.5.210: Windows binaries (fixed version)

Binaries for Windows platform here.
Fixed v0.5.210 (version number wasn't updated into MakeFile)
abs occurences replaced by fabs into two cpp big thanks to Albert Jean:

• plugins\LRTRack\src\ReShaper.cpp
• plugins\LRTRack\src\dsp\LadderFilter.cpp

LindenbergResearch-0.5.210-win.zip

Patrick: some tests by other users will be appreciated before pushing this release.

build fail with GCC 5.3.1

Fedora 23 Linux
Rack 0.5.x

I can solve some C++ issues but not this one:

g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.210 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/MS20Filter.cpp.o src/MS20Filter.cpp
In file included from src/dsp/MS20zdf.hpp:4:0,
from src/MS20Filter.cpp:1:
src/dsp/DSPSystem.hpp:38:9: error: ‘virtual’ can only be specified for functions
};
^
src/dsp/DSPSystem.hpp:44:9: error: ‘virtual’ can only be specified for functions
};
^
src/dsp/DSPSystem.hpp:50:9: error: ‘virtual’ can only be specified for functions
};
^
../../compile.mk:53: recipe for target 'build/src/MS20Filter.cpp.o' failed
make: *** [build/src/MS20Filter.cpp.o] Error 1

build fail: setShape

Linux Fedora 23
Rack master (0.6.x dev)

g++ -Wsuggest-override -std=c++11 -fPIC -I../../include -I../../dep/include -DSLUG=LindenbergResearch -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/VCO.cpp.o src/VCO.cpp
src/VCO.cpp: In member function ‘virtual void VCO::step()’:
src/VCO.cpp:55:14: error: ‘struct dsp::BLITOscillator’ has no member named ‘setShape’
osc->setShape(shape);
^
../../compile.mk:57: recipe for target 'build/src/VCO.cpp.o' failed
make: *** [build/src/VCO.cpp.o] Error 1

Any suggestions for fixing ?

Re Woldemar

Hi Patrick,

Just a note to ask if Woldemar is still a work in progress?

It's rendering like this in Windows 10 (Rack 0.6):

The representation of CV modulation on the knobs in Valerie is stunning.

All the best,

Adrian

Feature request: Woldemar sync input

As this is a feature request and not a bug report, feel free to ignore it.
Woldemar is my VCO of choice for pretty much everything in VCV Rack. I'd really love a sync input, as its lack of sync is the only thing about it that makes me want to use another VCO sometimes.
Thank you for making these modules, they're awesome!

LRTRack 0.5.210: can't compile on Windows platform

Platform: Windows 7 Pro SP1 (x64)
VCV Rack dev (based on 0.5.1), on C:\Rack
LRTRack v0.5.210

Hi, I don't understand why I can't compile Windows binaries (having the same problem with previous 0.5.185)? what's I'm wrong? thanks in advance (sorry some messages are displayed in French in this log, because my Windows 7 Pro SP1 x64 is French-localized).

DoM@HAL-9000 MINGW64 /C/Rack/plugins/LRTRack
$ make
Makefile:28: avertissement : surchargement de la recette pour la cible « dist »
../../plugin.mk:36: avertissement : ancienne recette ignorée pour la cible « dist »
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.185 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -Wsuggest-override -std=c++11 -c -o build/src/AlmaFilter.cpp.o src/AlmaFilter.cpp
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.185 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -Wsuggest-override -std=c++11 -c -o build/src/SimpleFilter.cpp.o src/SimpleFilter.cpp
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.185 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -Wsuggest-override -std=c++11 -c -o build/src/BlankPanel.cpp.o src/BlankPanel.cpp
g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.185 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -Wsuggest-override -std=c++11 -c -o build/src/ReShaper.cpp.o src/ReShaper.cpp
src/ReShaper.cpp: In member function 'virtual void ReShaper::step()':
src/ReShaper.cpp:38:27: error: call of overloaded 'abs(float&)' is ambiguous
float out = x * (abs(x) + a) / (x * x + (a - 1) * abs(x) + 1);
^
In file included from C:/msys64/mingw64/include/c++/6.2.0/cstdlib:75:0,
from C:/msys64/mingw64/include/c++/6.2.0/stdlib.h:36,
from ../../include/util.hpp:4,
from ../../include/rack.hpp:3,
from src/LindenbergResearch.hpp:3,
from src/ReShaper.cpp:1:
C:/msys64/mingw64/x86_64-w64-mingw32/include/stdlib.h:338:15: note: candidate: int abs(int)
int __cdecl abs(int _X);
^~~
In file included from C:/msys64/mingw64/include/c++/6.2.0/stdlib.h:36:0,
from ../../include/util.hpp:4,
from ../../include/rack.hpp:3,
from src/LindenbergResearch.hpp:3,
from src/ReShaper.cpp:1:
C:/msys64/mingw64/include/c++/6.2.0/cstdlib:180:3: note: candidate: long long int std::abs(long long int)
abs(long long __x) { return __builtin_llabs (__x); }
^~~
C:/msys64/mingw64/include/c++/6.2.0/cstdlib:172:3: note: candidate: long int std::abs(long int)
abs(long __i) { return __builtin_labs(__i); }
^~~
src/ReShaper.cpp:38:60: error: call of overloaded 'abs(float&)' is ambiguous
float out = x * (abs(x) + a) / (x * x + (a - 1) * abs(x) + 1);
^
In file included from C:/msys64/mingw64/include/c++/6.2.0/cstdlib:75:0,
from C:/msys64/mingw64/include/c++/6.2.0/stdlib.h:36,
from ../../include/util.hpp:4,
from ../../include/rack.hpp:3,
from src/LindenbergResearch.hpp:3,
from src/ReShaper.cpp:1:
C:/msys64/mingw64/x86_64-w64-mingw32/include/stdlib.h:338:15: note: candidate: int abs(int)
int __cdecl abs(int _X);
^~~
In file included from C:/msys64/mingw64/include/c++/6.2.0/stdlib.h:36:0,
from ../../include/util.hpp:4,
from ../../include/rack.hpp:3,
from src/LindenbergResearch.hpp:3,
from src/ReShaper.cpp:1:
C:/msys64/mingw64/include/c++/6.2.0/cstdlib:180:3: note: candidate: long long int std::abs(long long int)
abs(long long __x) { return __builtin_llabs (__x); }
^~~
C:/msys64/mingw64/include/c++/6.2.0/cstdlib:172:3: note: candidate: long int std::abs(long int)
abs(long __i) { return __builtin_labs(__i); }
^~~
make: *** [../../compile.mk:54: build/src/ReShaper.cpp.o] Error 1

build fail, latest source

Linux Fedora 23
Rack 0.5.1 from source

Build of your plugin fails here:

g++ -fPIC -I../../include -I../../dep/include -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/VCO.cpp.o src/VCO.cpp
In file included from src/LindenbergResearch.hpp:6:0,
from src/VCO.cpp:3:
src/SimpleFilter.hpp:7:0: warning: "MODULE_WIDTH" redefined
#define MODULE_WIDTH 12.f
^
In file included from src/VCO.cpp:2:0:
src/VCO.hpp:7:0: note: this is the location of the previous definition
#define MODULE_WIDTH 11.f
^
In file included from src/dsp/Oscillator.hpp:3:0,
from src/VCO.cpp:1:
src/dsp/DSPMath.hpp:114:43: error: no matching function for call to ‘LP6DBFilter::LP6DBFilter(int)’
LP6DBFilter filter = LP6DBFilter(18000);
^
src/dsp/DSPMath.hpp:66:5: note: candidate: LP6DBFilter::LP6DBFilter(sfloat, int)
LP6DBFilter(sfloat fc, int factor) {
^
src/dsp/DSPMath.hpp:66:5: note: candidate expects 2 arguments, 1 provided
src/dsp/DSPMath.hpp:51:8: note: candidate: constexpr LP6DBFilter::LP6DBFilter(const LP6DBFilter&)
struct LP6DBFilter {
^
src/dsp/DSPMath.hpp:51:8: note: no known conversion for argument 1 from ‘int’ to ‘const LP6DBFilter&’
src/dsp/DSPMath.hpp:51:8: note: candidate: constexpr LP6DBFilter::LP6DBFilter(LP6DBFilter&&)
src/dsp/DSPMath.hpp:51:8: note: no known conversion for argument 1 from ‘int’ to ‘LP6DBFilter&&’
In file included from src/VCO.cpp:1:0:
src/dsp/Oscillator.hpp:45:40: error: no matching function for call to ‘LP6DBFilter::LP6DBFilter(int)’
LP6DBFilter lp1 = LP6DBFilter(20000);
^
In file included from src/dsp/Oscillator.hpp:3:0,
from src/VCO.cpp:1:
src/dsp/DSPMath.hpp:66:5: note: candidate: LP6DBFilter::LP6DBFilter(sfloat, int)
LP6DBFilter(sfloat fc, int factor) {
^
src/dsp/DSPMath.hpp:66:5: note: candidate expects 2 arguments, 1 provided
src/dsp/DSPMath.hpp:51:8: note: candidate: constexpr LP6DBFilter::LP6DBFilter(const LP6DBFilter&)
struct LP6DBFilter {
^
src/dsp/DSPMath.hpp:51:8: note: no known conversion for argument 1 from ‘int’ to ‘const LP6DBFilter&’
src/dsp/DSPMath.hpp:51:8: note: candidate: constexpr LP6DBFilter::LP6DBFilter(LP6DBFilter&&)
src/dsp/DSPMath.hpp:51:8: note: no known conversion for argument 1 from ‘int’ to ‘LP6DBFilter&&’
../../compile.mk:53: recipe for target 'build/src/VCO.cpp.o' failed
make: *** [build/src/VCO.cpp.o] Error 1

Any suggestions ?

EQ modules make Rack to crash on Windows

EQ module cannot load fonts on Windows...and make Rack to halt and crash.

src/SimpleFilter.cpp:84:39: error: ‘gSampleRate’ was not declared in this scope

Compiling this code with the latest Rack checkout throws some errors. The Plugin instance is not needed when calling createModel and std:: has to be specified before calling the abs function.
Actually, the init function should look something like this to be compatible with the latest rack:

void init(rack::Plugin *p) {
    plugin = p;
    plugin->slug = "Lindenberg Research";
    p->addModel(createModel<SimpleFilterWidget>("Lindenberg Research", "LPFilter24dB", "24dB Lowpass Filter"));
    p->addModel(createModel<BlankPanelWidget>("Lindenberg Research", "BlankPanel", "Blank Panel 26TE"));
    p->addModel(createModel<ReShaperWidget>("Lindenberg Research", "ReShaper", "ReShaper Wavefolder"));
}

After doing these changes, I'm left with the error ‘gSampleRate’ was not declared in this scope.
Where is this variable coming from?

CV Control "Overextends" Limit of Control of Frequency of Alma Filter

Scenario: The CV knob is all the way to the right for Frequency on the Alma, and I am controlling it with a knob on my physical control device via the MIDI-CC device. If the Frequency knob is set fairly far to the right to begin with, before I have made a complete turn of my physical knob, CV control tops out (as expected). What isn't expected (to me, anyway) is that the sound from the filter cuts out for a portion of the turn and then behaves as if the Frequency knob is all the way to the left, as well. Is this by design? This behavior does not occur on the Valerie filter.

build fail with latest pull

Fedora 23 Linux
GCC 5.3.1
Rack 0.6.2c

Hi Patrick,

I've hit a snag in the latest code:

$ make dist
g++ -Wsuggest-override -std=c++11 -DSLUG=LindenbergResearch -fPIC -I../../include -I../../dep/include -DVERSION=0.6.4 -MMD -MP -g -O3 -march=athlon-fx -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/modules/Korg35.cpp.o src/modules/Korg35.cpp
src/modules/Korg35.cpp:49:66: error: no matching function for call to ‘dsp::Korg35Filter::Korg35Filter(float)’
     Korg35Filter *filter = new Korg35Filter(engineGetSampleRate());
                                                                  ^
In file included from src/modules/Korg35.cpp:21:0:
src/modules/../dsp/Korg35Filter.hpp:84:5: note: candidate: dsp::Korg35Filter::Korg35Filter(float, dsp::Korg35Filter::FilterType)
     Korg35Filter(float sr, FilterType type) : DSPEffect(sr) {
     ^
src/modules/../dsp/Korg35Filter.hpp:84:5: note:   candidate expects 2 arguments, 1 provided
src/modules/../dsp/Korg35Filter.hpp:64:8: note: candidate: constexpr dsp::Korg35Filter::Korg35Filter(const dsp::Korg35Filter&)
 struct Korg35Filter : DSPEffect {
        ^
src/modules/../dsp/Korg35Filter.hpp:64:8: note:   no known conversion for argument 1 from ‘float’ to ‘const dsp::Korg35Filter&’
src/modules/../dsp/Korg35Filter.hpp:64:8: note: candidate: constexpr dsp::Korg35Filter::Korg35Filter(dsp::Korg35Filter&&)
src/modules/../dsp/Korg35Filter.hpp:64:8: note:   no known conversion for argument 1 from ‘float’ to ‘dsp::Korg35Filter&&’
../../compile.mk:64: recipe for target 'build/src/modules/Korg35.cpp.o' failed
make: *** [build/src/modules/Korg35.cpp.o] Error 1

I'm not sure if it's a compiler issue. Any suggestion for a fix ?

Brighter LED Display?

Patrick,

I really like the Alternate/Aged appearance of Vampyr, but on my crummy monitor with poor gamma, the red LED display is fairly unreadable. (The blue one is fine). Would you consider lightening the hue of the red a little for that display?

LRTRack v0.5.185: inappropriate tags

Hi,

I report tags issues for some modules:

• Blank Panel 12TE / 20TE would be "Blank" (instead of "Utility").
• ReShaper Wavefolder would be "Waveshaper" (instead of "Filter/VCF"). GUI indicates "VCS Waveshaper" when the module is loaded in rack.

Regards.

Laika Classic Dark skin is missing inner pointers on knobs when cv is added/connected

Hi Patrick

I think the subject says enough , the white knobs do not get a black triangle when I connect cv to one of the three knobs freq/res/sat.

Thanks for your great plugins,

Greetings Peter.

VCO Module

Do you have an ETA as to when your VCO will be available for release.

Thanks,

Omar

Westcoast module crashes Rack

Fedora 23 Linux
Rack 0.6.x (built from source)

No problems building the plugin, and all other modules load and seem fine. When I try to load the Westcoast module it crashes Rack. Here's the edited output from 'make debug':

...
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffcd109700 (LWP 2875)]
Westcoast::step (this=0x16a12a0) at src/Westcoast.cpp:72
72 gain->setIndicatorActive(inputs[CV_GAIN_INPUT].active);
...
(gdb) thread apply all bt
Thread 5 (Thread 0x7fffcd109700 (LWP 2875)):
#0 0x00007fffe20ec4a3 in Westcoast::step() (this=0x16a12a0) at src/Westcoast.cpp:72
#1 0x000000000051664f in rack::engineRun() () at src/engine.cpp:128
#2 0x000000000051664f in rack::engineRun() () at src/engine.cpp:172
#3 0x00007ffff45eaf20 in () at /lib64/libstdc++.so.6
#4 0x00007ffff7bc561a in start_thread () at /lib64/libpthread.so.0
#5 0x00007ffff3d5a5fd in clone () at /lib64/libc.so.6

Thread 4 (Thread 0x7fffce023700 (LWP 2874)):
#0 0x00007ffff7bce28d in nanosleep () at /lib64/libpthread.so.0
#1 0x0000000000520448 in rack::serverRun() (__rtime=...) at /usr/include/c++/5.3.1/thread:292
#2 0x0000000000520448 in rack::serverRun() () at src/bridge.cpp:358
#3 0x0000000000520448 in rack::serverRun() () at src/bridge.cpp:371
#4 0x00007ffff45eaf20 in () at /lib64/libstdc++.so.6
#5 0x00007ffff7bc561a in start_thread () at /lib64/libpthread.so.0
#6 0x00007ffff3d5a5fd in clone () at /lib64/libc.so.6

Thread 3 (Thread 0x7fffce884700 (LWP 2873)):
#0 0x00007ffff3d4eb7d in poll () at /lib64/libc.so.6
#1 0x00007ffff4dec18c in g_main_context_iterate.isra () at /lib64/libglib-2.0.so.0
#2 0x00007ffff4dec512 in g_main_loop_run () at /lib64/libglib-2.0.so.0
#3 0x00007ffff586e516 in gdbus_shared_thread_func () at /lib64/libgio-2.0.so.0
#4 0x00007ffff4e128e5 in g_thread_proxy () at /lib64/libglib-2.0.so.0
#5 0x00007ffff7bc561a in start_thread () at /lib64/libpthread.so.0
#6 0x00007ffff3d5a5fd in clone () at /lib64/libc.so.6

Thread 2 (Thread 0x7fffcf085700 (LWP 2872)):
#0 0x00007ffff3d4eb7d in poll () at /lib64/libc.so.6
#1 0x00007ffff4dec18c in g_main_context_iterate.isra () at /lib64/libglib-2.0.so.0
#2 0x00007ffff4dec29c in g_main_context_iteration () at /lib64/libglib-2.0.so.0
#3 0x00007ffff4dec2d9 in glib_worker_main () at /lib64/libglib-2.0.so.0
#4 0x00007ffff4e128e5 in g_thread_proxy () at /lib64/libglib-2.0.so.0
#5 0x00007ffff7bc561a in start_thread () at /lib64/libpthread.so.0
#6 0x00007ffff3d5a5fd in clone () at /lib64/libc.so.6

Thread 1 (Thread 0x7ffff7f9f9c0 (LWP 2868)):
#0 0x00007ffff3d549e7 in munmap () at /lib64/libc.so.6
#1 0x00007ffff3cd3a52 in __GI__IO_setb () at /lib64/libc.so.6
#2 0x00007ffff3cd1e7e in __GI__IO_file_close_it () at /lib64/libc.so.6
#3 0x00007ffff3cc5aff in fclose@@GLIBC_2.2.5 () at /lib64/libc.so.6
#4 0x0000000000534f2c in nsvgParseFromFile(char const*, char const*, float) (filename=, units=0x7c9083 "px", dpi=75) at dep/include/nanosvg.h:2896
#5 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (filename="./plugins/LRTRack/res/Westcoast.svg", this=0x16b3f70) at src/window.cpp:692
#6 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (__p=, this=)
at /usr/include/c++/5.3.1/ext/new_allocator.h:120
#7 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (__p=, __a=...)
at /usr/include/c++/5.3.1/bits/alloc_traits.h:530
#8 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (__a=..., this=0x16b3f60)
at /usr/include/c++/5.3.1/bits/shared_ptr_base.h:522
#9 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (__a=..., this=)
at /usr/include/c++/5.3.1/bits/shared_ptr_base.h:617
#10 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (__a=..., __tag=..., this=)
at /usr/include/c++/5.3.1/bits/shared_ptr_base.h:1097
#11 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (__a=..., __tag=..., this=)
at /usr/include/c++/5.3.1/bits/shared_ptr.h:319
#12 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (__a=...) at /usr/include/c++/5.3.1/bits/shared_ptr.h:620
#13 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) () at /usr/include/c++/5.3.1/bits/shared_ptr.h:636
#14 0x0000000000537067 in rack::SVG::load(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (filename="./plugins/LRTRack/res/Westcoast.svg")
at src/window.cpp:709
#15 0x00007fffe20ef8b2 in WestcoastWidget::WestcoastWidget(Westcoast*) (this=this@entry=0x16a32f0, module=module@entry=0x16a12a0, __in_chrg=, __vtt_parm=)
at src/Westcoast.cpp:123
#16 0x00007fffe20f41a2 in rack::Model* rack::Model::create<Westcoast, WestcoastWidget, rack::ModelTag>(std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >, rack::ModelTag)::TModel::createModuleWidget() (this=0xc26c20) at ../../include/plugin.hpp:78
#17 0x000000000055d907 in rack::ModelItem::onAction(rack::EventAction&) (this=, e=...) at src/app/ModuleBrowser.cpp:139
#18 0x000000000055dba5 in rack::BrowserListItem::onDragDrop(rack::EventDragDrop&) (this=) at src/app/ModuleBrowser.cpp:92
#19 0x000000000055dba5 in rack::BrowserListItem::onDragDrop(rack::EventDragDrop&) (this=, e=...) at src/app/ModuleBrowser.cpp:86
#20 0x00000000005373ac in rack::mouseButtonCallback(GLFWwindow*, int, int, int) (window=window@entry=0xff6980, button=0, action=, mods=) at src/window.cpp:117
#21 0x0000000000537be9 in rack::windowRun() () at src/window.cpp:144
#22 0x0000000000537be9 in rack::windowRun() () at src/window.cpp:447
#23 0x00000000004c6e2c in main(int, char**) (argc=, argv=0x7fffffffda98) at src/main.cpp:107
(gdb)

I hope that helps. Thanks for the great modules !

Could your 0.6.0 modules please be compiled?

I'm unable to go through all the steps involved in compiling the code for these modules for use on my Mac. But I'm a big fan of the -24dB filter, and have a number of patches that use it that won't work anymore.

Would it be asking to much that these modules be distributed in the normal fashion in the VCV Rack plugin manager with versions that are ready for use?

Thanks.

plugin breaks slug rules

built on Debian 9.9

same issue as https://github.com/VCVRack/Rack/issues/1305
plugin builds but when added to Rackv1.dev.4b3508b will crash with the following error:

Rack: src/plugin/Plugin.cpp:17: void rack::plugin::Plugin::addModel(rack::plugin::Model*): Assertion `isSlugValid(model->slug)' failed.
Aborted

Linux build

LindenbergResearch-0.5.210-lin.zip

VCO is invisible except for 4 screws

On the Mac, after building for 0.5.0, I can select each module except for Voltage Controlled Oscillator. When that is selected, an empty module appears in Rack which is apparent only by the black screws. The module itself is not there.

build fail

Fedora 23 Linux
Rack 0.5.x

g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.210 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/MS20Filter.cpp.o src/MS20Filter.cpp
src/MS20Filter.cpp: In member function ‘virtual void MS20Filter::step()’:
src/MS20Filter.cpp:76:14: error: ‘struct dsp::MS20zdf’ has no member named ‘setType’
ms20zdf->setType(params[MODE_SWITCH_PARAM].value);
^
../../compile.mk:53: recipe for target 'build/src/MS20Filter.cpp.o' failed
make: *** [build/src/MS20Filter.cpp.o] Error 1

Community JSON file: Missing version tag

The problem is more properly one with the community repo but, the "version" attribute is missing.
This means my automated script ends up checking out the master branch, which isn't the latest version.

You just need to add
"version": "0.5.210"

to the "Lindenberg Research.json" file.

Also: there's no "license" tag.

And the file name has a space in it, which isn't according to spec. I believe you can use 'git mv' to change the name, and that will go with your pull request to the community repo.

Problem with v0.6.5

I am running W10 Rack version.6.2c on 2 different machines and this only happens on my primary machine.
I have reinstalled Rack and the lindenberg mods to no avail.
The directory is there and looks fine.
Woldemar loads fine.
The blank wood loads fine.
West coast loads but only 1 skin works on the Westcoast and that is the classic dark. The others just show the knobs and jacks and no writing
Hoe this helps.

build fail with Rack v1

Fedora 23 Linux
GCC 5.3.1
VCV Rack v1.dev.0517cc2 (May 23)

Hi Patrick ! I've hit this snag during the build:

In file included from src/LRModule.cpp:18:0:
src/LRComponents.hpp: In member function ‘virtual void lrt::ScrewLight::onGestaltChange(lrt::LREventGestaltChange&)’:
src/LRComponents.hpp:760:9: error: ‘dirty’ was not declared in this scope
         dirty = true;
         ^
../../compile.mk:61: recipe for target 'build/src/LRModule.cpp.o' failed
make: *** [build/src/LRModule.cpp.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from src/LRModuleWidget.cpp:18:0:
src/LRComponents.hpp: In member function ‘virtual void lrt::ScrewLight::onGestaltChange(lrt::LREventGestaltChange&)’:
src/LRComponents.hpp:760:9: error: ‘dirty’ was not declared in this scope
         dirty = true;
         ^
../../compile.mk:61: recipe for target 'build/src/LRModuleWidget.cpp.o' failed
make: *** [build/src/LRModuleWidget.cpp.o] Error 1

Any suggestions ?

Valerie output bug: inf and nan

Hi Patrick,

I've been having an intermittent bug with the Valerie filter, and so far I'm not sure how exactly to reproduce it. I'm posting the issue anyways, in case others have observed this, and more data can be gathered to help debug. The problem is that sometimes the output gets stuck at "inf" and no sound comes out. When I close Rack and restart it, the problem goes away.

I'm using Rack 0.5.1, and version 0.5.3 of the LRTRack plugins, on windows 10.

As a side note, when I tried the Valerie filter on my macbook air, I actually got a "nan" in the output at one point, but once again, when I closed Rack and started it up again, all was normal and I couldn't repeat the bug. Sorry if this is not super helpful.

V1 Bug: Seg Fault when right clicking display on Woldermar

Right clicking on the display will crash rack

[3.166 info src/main.cpp:161] Starting engine
[New Thread 9036.0x5e4]
[3.166 info src/main.cpp:173] Running window
[New Thread 9036.0x774]
[New Thread 9036.0x17e4]

Thread 1 received signal SIGSEGV, Segmentation fault.
0x00000000007764b6 in rack::app::ParamLabel::step (this=0x1d3d20d0)
    at src/app/ParamWidget.cpp:82
82                      text = paramWidget->paramQuantity->getString();
(gdb) bt
#0  0x00000000007764b6 in rack::app::ParamLabel::step (this=0x1d3d20d0)
    at src/app/ParamWidget.cpp:82
#1  0x00000000004a3887 in rack::widget::Widget::step (
    this=this@entry=0x1fd10e10) at src/widget/Widget.cpp:151
#2  0x000000000049edd3 in rack::ui::Menu::step (this=0x1fd10e10)
    at src/ui/Menu.cpp:29
#3  0x00000000004a3887 in rack::widget::Widget::step (this=0x1d3d1ef0)
    at src/widget/Widget.cpp:151
#4  0x00000000004a3887 in rack::widget::Widget::step (this=0x6ae9cb0)
    at src/widget/Widget.cpp:151
#5  0x000000000048c8c9 in rack::app::Scene::step (this=0x6ae9cb0)
    at src/app/Scene.cpp:49
#6  0x0000000000453441 in rack::Window::run (this=0x6ae2b70)
    at src/window.cpp:365
#7  0x000000000079b849 in main (argc=<optimized out>, argv=<optimized out>)
    at src/main.cpp:174
(gdb)

veeseevee LR modules knobs displaced

for some reason no matter what I do the knobs appear detached and moved to far left in the VCV rack. IN FL and ableton

windows version 0.5.210

LindenbergResearch-0.5.185-win.zip

Oscillator doesn't show in VCV rack!

Hello!

I just tried compiling one of the branches, 5.3 and I see all of the modules in Rack, except the oscillator. I also tried the release version for Rack 5 and oscillator doesn't work here either.

Is the oscillator still in development or for some other reason not working yet?

SUPER awesome filters btw. Alma is exceptional. Thanks for sharing :)

Thanks, Jakob

crash on loading wood blank

Trying to select the Wood blank, or loading a saved patch with the wood blank leads to a reproducible crash of VCV Rack 0.6.2b on Win 10, using current git (0.6,4-beta1)

[43.141 info src/window.cpp:694] Loaded SVG D:\Ben\Documents/Rack/plugins/LindenbergResearch/res/panels/WoodLeftTop.svg
[43.192 info src/window.cpp:694] Loaded SVG D:\Ben\Documents/Rack/plugins/LindenbergResearch/res/panels/LaikaPatina.svg
[44.015 debug src/Core/AudioInterface.cpp:224] Audio Interface underflow

Failed to load library ./plugins/LRTRack/plugin.so

Ubuntu 16.04
Rack 0.5.0 dev

[warning] Failed to load library ./plugins/LRTRack/plugin.so: ./plugins/LRTRack/plugin.so: undefined symbol: _Z17getPhaseIncrementf

Alam seems to break veeseevee

The audio click pops and goes silent using this module for some reason in veesseerack. I removed it and the project works

Linux Binaries

linux version, compiled on Ubunut16Lts
LindenbergResearch-0.5.210-lin.zip

linux build fails

LRTRack/src/ReShaper.cpp

Line 39 in 94f5e53

float out = x * (abs(x) + a) / (x * x + (a - 1) * abs(x) + 1);

changing abs to std::abs did the trick for me

load fail with latest pull

Fedora 23 Linux
Rack 0.6.2b from source

Hi Patrick ! No build problems, but the plugin doesn't load here:

[0.132 warn src/plugin.cpp:90] Failed to load library ./plugins/LRTRack/plugin.so: ./plugins/LRTRack/plugin.so: undefined symbol: kiss_fft_alloc

Missing an object during linking perhaps ? Seeking advice here. :)

load fail with latest git pull

Fedora 23 Linux
Rack 0.5.x

Plugin build is fine, no problems, but the module fails to load. This error is reported:

[warning] Failed to load library ./plugins/LRTRack/plugin.so: ./plugins/LRTRack/plugin.so: undefined symbol: plugin

Incidentally, I always 'make clean' before compiling, so the build is fresh.

Anybody out there for compiling a linux version for me? :)

Master updated to 0.6.xx

The last two day's I migrated the current sources to work with the upcoming v0.6.xx of Rack. For detailed information on what has been changed please see the API update thread at the Rack issue discussions.
You will have to fetch the current 0.6.xxdev in order to get the plugin running fine. I suggest to do a clean build - I had some trouble while updating the current 0.5.xx repo and started from scratch - then it worked fine.
If you encounter any issue with the migration, please post it here. For now it seems to run fine on my machine.

Cheers,
Patrick

Westcoast crashes Rack when connected to input

I think I have used Westcoast and not had this crash. I was talking part in a collaboration patch in this thread on the community forum when I got a crash after another**user added modules to the patch which then started crashing rack for me but not him or anyone else in the disccussion/collab.

Connecting to the input of Westcoast is causing a segmentation fault:
Latest rack release and dev commit f4151bed2ece0fa1eee79fe15c4ec1af883c590e
Windows 7
**Windows 10

Thread 12 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 5692.0x215c]
Westcoast::process (this=0x1032df40, args=...)
    at src/modules/Westcoast.cpp:168
168         reflect->gainBtn->setIndicatorActive(inputs[CV_GAIN_INPUT].isConnected());
(gdb) bt
#0  Westcoast::process (this=0x1032df40, args=...)
    at src/modules/Westcoast.cpp:168
#1  0x000000000049a079 in rack::engine::Engine_stepModules (threadId=0,
    that=<optimized out>) at src/engine/Engine.cpp:258
#2  0x000000000049c527 in rack::engine::Engine_step (that=0x6650b10)
    at src/engine/Engine.cpp:335
#3  rack::engine::Engine_run (that=0x6650b10) at src/engine/Engine.cpp:432
#4  rack::engine::Engine::<lambda()>::operator() (__closure=<optimized out>)
    at src/engine/Engine.cpp:461
#5  std::__invoke_impl<void, rack::engine::Engine::start()::<lambda()> > (
    __f=...) at C:/msys64/mingw64/include/c++/8.2.1/bits/invoke.h:60
#6  std::__invoke<rack::engine::Engine::start()::<lambda()> > (__fn=...)
    at C:/msys64/mingw64/include/c++/8.2.1/bits/invoke.h:95
#7  std::thread::_Invoker<std::tuple<rack::engine::Engine::start()::<lambda()> > >::_M_invoke<0> (this=<optimized out>)
    at C:/msys64/mingw64/include/c++/8.2.1/thread:244
#8  std::thread::_Invoker<std::tuple<rack::engine::Engine::start()::<lambda()> > >::operator() (this=<optimized out>)
    at C:/msys64/mingw64/include/c++/8.2.1/thread:253
#9  std::thread::_State_impl<std::thread::_Invoker<std::tuple<rack::engine::Engine::start()::<lambda()> > > >::_M_run(void) (this=<optimized out>)
    at C:/msys64/mingw64/include/c++/8.2.1/thread:196
#10 0x000000006fd0891f in ?? () from C:\msys64\mingw64\bin\libstdc++-6.dll
#11 0x0000000064944b90 in ?? () from C:\msys64\mingw64\bin\libwinpthread-1.dll
#12 0x000007fefe62415f in srand () from C:\Windows\system32\msvcrt.dll
#13 0x000007fefe626ebd in msvcrt!_ftime64_s ()
   from C:\Windows\system32\msvcrt.dll
#14 0x00000000773859cd in KERNEL32!BaseThreadInitThunk ()
   from C:\Windows\system32\kernel32.dll
#15 0x00000000775e385d in ntdll!RtlUserThreadStart ()
   from C:\Windows\SYSTEM32\ntdll.dll
#16 0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb)

It was a though crash to find had to manually remove cables from the save to narrow down 😞

Versioning on the blankpanel

Hi!

I asked you today if it is ok to "steal" the part of the code which lets you show the versioning on the blankpanel.. after I was finished and got it working "properly" I noticed that when I use zoom in Rack that it wont behave like I thought it would. Meaning that I will not get bigger or smaller the same way everything else does. Best would be if you try it yourself to see what I mean. It also happens to your blankpanel ;)

0.5.0 builds

last commit, except:
commented out the VCO in lindenbergresearch.cpp and fixed the shaper to build in linux

LindenbergResearch-0.5.0-lin.zip
LindenbergResearch-0.5.0-mac.zip
LindenbergResearch-0.5.0-win.zip

Cannot compile on Windows

$ make
g++ -Wsuggest-override -std=c++11 -DSLUG=LindenbergResearch -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/AlmaFilter.cpp.o src/AlmaFilter.cpp
src/AlmaFilter.cpp: In constructor 'AlmaFilterWidget::AlmaFilterWidget(AlmaFilter*)':
src/AlmaFilter.cpp:141:40: error: 'LRRedLight' was not declared in this scope
addChild(ModuleLightWidget::create(Vec(85, 247), module, AlmaFilter::OVERLOAD_LIGHT));
^~~~~~~~~~
src/AlmaFilter.cpp:141:40: note: suggested alternative: 'LRLight'
addChild(ModuleLightWidget::create(Vec(85, 247), module, AlmaFilter::OVERLOAD_LIGHT));
^~~~~~~~~~
LRLight
src/AlmaFilter.cpp:141:100: error: no matching function for call to 'rack::ModuleLightWidget::create< >(rack::Vec, AlmaFilter*&, AlmaFilter::LightIds)'
addChild(ModuleLightWidget::create(Vec(85, 247), module, AlmaFilter::OVERLOAD_LIGHT));
^
In file included from ../../include/rack.hpp:9:0,
from src/dsp/DSPMath.hpp:5,
from src/dsp/LadderFilter.hpp:6,
from src/AlmaFilter.cpp:1:
../../include/app.hpp:447:12: note: candidate: template static T* rack::ModuleLightWidget::create(rack::Vec, rack::Module*, int)
static T *create(Vec pos, Module *module, int firstLightId) {
^~~~~~
../../include/app.hpp:447:12: note: template argument deduction/substitution failed:
src/AlmaFilter.cpp:141:100: error: template argument 1 is invalid
addChild(ModuleLightWidget::create(Vec(85, 247), module, AlmaFilter::OVERLOAD_LIGHT));
^
make: *** [../../compile.mk:65: build/src/AlmaFilter.cpp.o] Error 1

s/Template/LindenbergResearch/

LRTRack/Makefile

Line 20 in 94f5e53

DIST_NAME = Template

Question on filter design

I am planning on making a few modules, and really like these as examples of how modules can be created (to add to Tutorial in Rack). The "blank" module is nice! Some of these questions I am sure are basic, but hopefully apply to any module. I have questions (labeled as **) underneath each statement in Step() for the Shaper module (which seems an excellent starter because of the functions)

// normalize signal input to [-1.0...+1.0]
float x = clampf(inputs[RESHAPER_INPUT].value * 0.1f, -1.f, 1.f);

** As you point out, this normalizes the signal, but what is the incoming range for a Rack signal? Are modules always sending a signal from -10 to +10v or are input signals arbitrary in voltage?

float cv = inputs[RESHAPER_CV_INPUT].value * params[RESHAPER_CV_AMOUNT].value;

** The top knob is presumably ranging 0 to 1 in value as it is turned ?

float a = clampf(params[RESHAPER_AMOUNT].value + cv, 1.f, 50.f);

** What is the reason for ranging from 1 to 50?

// do the acid!
float out = x * (abs(x) + a) / (x * x + (a - 1) * abs(x) + 1);

** Is this a known filter design or something you've designed? I have not yet delved into the numerical methods for modular filters but I guess there are many books on the subject.