linkdata/deadlock

Deadlock detection for Go

deadlock's Issues

removing goid as dependency

Hi , thanks for the revival :)

When compiling with garble im facing an issue with goid

# github.com/petermattis/goid
/tmp/garble-shared1926219085/EBih0wwzivaK/NOrHNRTEp.s:29: expected pseudo-register; found R14
asm: assembly of /tmp/garble-shared1926219085/EBih0wwzivaK/NOrHNRTEp.s failed

while it looks like a garble issue with build tags, after looking at goid, it looks like since go 1.8 only the slow version is used anyway.

so to fix this i added a goid.go file in deadlock with this code :

package deadlock

import (
        "bytes"
        "runtime"
        "strconv"
)


func ExtractGID(s []byte) int64 {
        s = s[len("goroutine "):]
        s = s[:bytes.IndexByte(s, ' ')]
        gid, _ := strconv.ParseInt(string(s), 10, 64)
        return gid
}

// Parse the goid from runtime.Stack() output. Slow, but it works.
func GetGID() int64 {
        var buf [64]byte
        return ExtractGID(buf[:runtime.Stack(buf[:], false)])
}

and replace the goid.xx function with those one. Like this all works for me and the garble compilation succeed.

Dunno if you would be interested to also add it to this fork.

Best Regards