linkyard/docker-logrotate

Logrotate in an Alpine Linux docker container

docker-logrotate's Issues

Custom logrotate expression (`LOGROTATE_CRON`) gets executed multiple times

Hi,

Thanks for putting together this, very convenient and I find myself using it from time to time.

However, I have been running into a problem where a custom cron expression (i.e using LOGROTATE_CRON) gets executed multiple times and digging in to this I found /var/spool/cron/crontabs/root looking like this:

# do daily/weekly/monthly maintenance
# min   hour    day     month   weekday command
*/15    *       *       *       *       run-parts /etc/periodic/15min
0       *       *       *       *       run-parts /etc/periodic/hourly
0       2       *       *       *       run-parts /etc/periodic/daily
0       3       *       *       6       run-parts /etc/periodic/weekly
0       5       1       *       *       run-parts /etc/periodic/monthly

0 0 * * * /etc/.logrotate.cronjob
0 0 * * * /etc/.logrotate.cronjob
0 0 * * * /etc/.logrotate.cronjob
0 0 * * * /etc/.logrotate.cronjob

I.e. it as multiple identical lines appended to the bottom. Currently, my best guess is that this Confirmed, this is a result of restarts of the container (which do preserve the filesystem I think?) in combination with appending instead of overwriting in https://github.com/linkyard/docker-logrotate/blob/master/entrypoint.sh#L25.

Will try to find some time to try out a fix and revert with a PR if it works out.