linux-system-roles/postfix

An ansible role which configures postfix

postfix's Issues

Molecule idempotence test fails on linux-system-roles.postfix : Configure Postfix

I'm wrapping your role in our's, to install and configure postfix. Molecule idempotence test fails on the Configure Postfix.

CRITICAL Idempotence test failed because of the following tasks:

• => linux-system-roles.postfix : Configure Postfix
• => linux-system-roles.postfix : Configure Postfix
• => linux-system-roles.postfix : Configure Postfix

I believe adding a tags: molecule-idempotence-notest on Postfix Configure task should fix the test

Configuration paradox

This role introduces a paradox.

• The daemon can not be started if the configuration is not valid for the system
• The role can not change the daemon configuration unless the daemon is started

There are unknown cases in which by external dependencies the configuration is inapplicable.

• Eg. system has ipv6 disabled but localhost in /etc/hosts is 127.0.0.1 and ::1. postfix will not start as it can not bind to ::1

Please solve the configuration paradox.

Conscious Language: Please rename master branch to main branch

As part of the conscious language project, the master branch is to be renamed to the main branch.

Here are the instructions.

1. Rename the master branch to main: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch
2. Check this to ensure the default branch has been changed to main: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/changing-the-default-branch - this should keep the github history, as well as updating the default branch configuration and updating any existing PRs

If you use the gh cli (highly recommended) you can use this to check which repos need to be updated:

gh repo list linux-system-roles -L 100 --json name,defaultBranchRef --source | \
  jq --raw-output '.[] | select(.defaultBranchRef.name == "master") | .name'

Thanks.

Conflicting configuration mechanisms

postfix/tasks/main.yml

Line 26 in 2a1b47b

line: "# This file is managed by Ansible"

This role manages the configuration file via postconf, not Ansible. Ansible comments and statements are disambigious.

role is not idempotent

we run the role in regular intervals and with each invocation /etc/postfix/main.cf is changed with

# Last modified: {{ ansible_date_time.date }}

this behavior was removed from {{ ansible_managed }} and now re-introduced with a separate task.

please update meta

metadata does not seem current, making the role seem old at https://galaxy.ansible.com/linux-system-roles/postfix

ansible-lint reports errors

--> Executing Ansible Lint on postfix/tests/tests_default.yml...
[ANSIBLE0010] Package installs should not use latest
postfix/tests/roles/linux-system-roles.postfix/tasks/main.yml:2
Task/Handler: Install Postfix

[ANSIBLE0013] Use shell only when shell functionality is required
postfix/tests/roles/linux-system-roles.postfix/tasks/main.yml:8
Task/Handler: Backup configuration

[ANSIBLE0012] Commands should not change things if nothing needs doing
postfix/tests/roles/linux-system-roles.postfix/tasks/main.yml:28
Task/Handler: Configure Postfix