linuxbox2/ntirpc

New development on tirpc

ntirpc's Issues

incomplete or lack of information about interface for RDMA client

It looks RDMA is rather supported by ntirpc, but the interface for RDMA client seems incomplete or lack of documenentation.
Specifically, clnt_rdma_ncreate() is the interface for create a CLIENT for RDMA, while,

1. where is the declaration of this interface?
2. The first parameter is RDMAXPRT *. How to create one for RDMA client? svc_rdma_create() is also used?

Could anyone confirm the status of RDMA support in ntirpc and provide help for above questions? Thanks a lot .

non-free files

File src/auth_time.c seems to be non-free due to copyright statement without explicit license:

Copyright (c) 1992 Sun Microsystems Inc.
All rights reserved.

Also man pages in man/ are Copyright 1989 AT&T and some are Copyright (c) 1988 Sun Microsystems, Inc. - All Rights Reserved....

Please remove those files or update licensing information after confirmation from current copyright owners (Oracle, AT&T).

old BSD license

Files src/crypt_client.c and ntirpc/rpcsvc/crypt.x are licensed under "BSD-4-clause" (old BSD) license. Unfortunately this GPL-incompatible license is universally deprecated.
It is not recognised as DFSG-compatible license hence this file can not be included to Debian etc.

See more

• https://www.gnu.org/licenses/license-list.html#OriginalBSD
• https://en.wikipedia.org/wiki/BSD_licenses#4-clause_license_.28original_.22BSD_License.22.2

Please consider removing those files or re-license 'em under "new" BSD (aka BSD-3-clause) license if copyright holder agrees with that:

Bill Paul <[email protected]>

xdr_destroy and XDR_CONTROL should be expressions, not statements

xdr_destroy and XDR_CONTROL are defined as "if" statements in xdr.h, but they should be expressions.
#define xdr_destroy(xdrs)
if ((xdrs)->x_ops->x_destroy)
(*(xdrs)->x_ops->x_destroy)(xdrs)

As an "if" statement, xdr_destroy() can't appear in the increment clause of a "for" statement:
for (cond; test; xdr_destroy(xp)) { ... } // syntax error

Much worse, it can cause unexpected results when used within an if statement. Consider:
if (cond)
xdr_destroy(xdrs);
else
oops();

If xdrs->x_ops->x_destroy is NULL, then oops() will be called, which is not what the programmer would expect.

canonical upstream location?

I think https://github.com/nfs-ganesha/ntirpc is the canonical upstream location for ntirpc now, right?

If so, would you please update this repo to point there?

(I noticed this because the Debian/Ubuntu libntirpc packages still point to this repo here)

Problem after turn off USE_GSS

Good to see this new development of TIRPC.

Here is a problem after I turn off USE_GSS in CMakeLists.txt:

Link will report error below:

undefined reference to _svcauth_gss' undefined reference toauthgss_ctx_gc_idle'

This is because svc_auth.c and svc_vc.c still reference the two functions even after USE_GSS is turned off.