Giter Site home page Giter Site logo

Comments (2)

jpcima avatar jpcima commented on June 12, 2024

When ADSR.cpp is edited to not restart at 0 after a re-trigger, ADSR looks better but sound is still clicking.

It's by applying this change:

	//bool bRestart = phase==kAdsrAttack;
	bool bRestart = phase==kAdsrAttack && previousPhase==kAdsrIdle;

Before
Capture du 2019-12-24 19-24-27

After
Capture du 2019-12-24 19-24-33

To check whether the retrigger is resetting oscillator's phase (which it shouldn't)

from vl1-emulator.

jpcima avatar jpcima commented on June 12, 2024

It should be fixed, testing needed

from vl1-emulator.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.