lioramr/ribs

Robust Infrastructure for Backend Systems

ribs's Issues

ability to set timeout per file descriptor

Currently there are 2 hard coded timeout chains, one for server and a second one for the client. It makes more sense to allow setting up the timeout per file descriptor. The change would require creating a hash table of timeout chains where the key is the desired timeout and the value is the circular timeout chain.

Failed to compile on Ubuntu 10.04.3 LTS

uname -a :
Linux sbr-dks4 2.6.32-31-server #61-Ubuntu SMP Fri Apr 8 19:44:42 UTC 2011 x86_64 GNU/Linux

Error:

(C++) acceptor.cpp [ -c -O3 -gdwarf-2 -W -Wall -Werror -I../../ribs/include acceptor.cpp -o ../obj/acceptor.o ]
acceptor.cpp:23: error: ‘vmpool_op’ is not a template
acceptor.cpp:23: error: ‘template struct acceptor’ used without template parameters
acceptor.cpp:23: error: aggregate ‘vmpool_op pool’ has incomplete type and cannot be defined
acceptor.cpp:25: error: ‘template struct acceptor’ used without template parameters
acceptor.cpp: In function ‘int init(int, int, int, epoll_server_event_array_)’:
acceptor.cpp:27: error: invalid use of ‘this’ in non-member function
acceptor.cpp:28: error: invalid use of ‘this’ in non-member function
acceptor.cpp:28: error: ‘template struct acceptor’ used without template parameters
acceptor.cpp:82: error: invalid use of ‘this’ in non-member function
acceptor.cpp:86: error: invalid use of ‘this’ in non-member function
acceptor.cpp:89: error: ‘callback’ was not declared in this scope
acceptor.cpp:89: error: ‘template struct acceptor’ used without template parameters
acceptor.cpp:90: error: ‘accept_callback’ was not declared in this scope
acceptor.cpp:90: error: ‘template struct acceptor’ used without template parameters
acceptor.cpp: At global scope:
acceptor.cpp:94: error: ‘template struct acceptor’ used without template parameters
acceptor.cpp: In function ‘basic_epoll_event_ on_accept()’:
acceptor.cpp:98: error: invalid use of ‘this’ in non-member function
acceptor.cpp:106: error: ‘events’ was not declared in this scope
acceptor.cpp:108: error: no matching function for call to ‘epoll::add(server_epoll_event_&, int)’
../../ribs/include/epoll.h:112: note: candidates are: static int epoll::add(basic_epoll_event_, uint32_t)
acceptor.cpp:109: error: invalid use of incomplete type ‘struct server_epoll_event’
acceptor.cpp:23: error: forward declaration of ‘struct server_epoll_event’
acceptor.cpp:109: error: ‘callback’ was not declared in this scope
acceptor.cpp:111: error: invalid use of ‘this’ in non-member function
acceptor.cpp:112: error: cannot convert ‘server_epoll_event_’ to ‘basic_epoll_event_’ in return
acceptor.cpp: At global scope:
acceptor.cpp:115: error: ‘template struct acceptor’ used without template parameters
acceptor.cpp: In function ‘void init_per_thread()’:
acceptor.cpp:117: error: invalid use of ‘this’ in non-member function

commit cb174b0 (previous) works just fine

reduce the number of maps by using dynamic pools

Currently the framework allocates fixed size pools of objects (http_server, http_client, etc) where the size of the pool is the number of max file descriptor allowed. Switching to dynamic pools which can be allocated using vmbuf will reduce the number of maps.

move gzip compression/decompression to ribs