Giter Site home page Giter Site logo

Comments (8)

rukala avatar rukala commented on June 19, 2024

When I upload a picture a second time (after error in dashboard) and it has the same filename, it's not uploaded after pressing save.

from a4-meinberlin.

rukala avatar rukala commented on June 19, 2024

The same happens in all project-types. Also after navigating back from the error page and pressing save without selected image to upload, same error message occurs.

from a4-meinberlin.

2e2a avatar 2e2a commented on June 19, 2024

This image size is limited by our web server to 10M. Is this not enough?

from a4-meinberlin.

xi avatar xi commented on June 19, 2024

I think part of the issue is that the error page does not look particularly nice. I think it is an important security property that large file uploads are blocked before they even reach django. Still, it is not an ideal user experience.

Maybe we can have a compromise: Increase the maximum in nginx, so we can show nicer error pages for medium-large files. Huge files could still be blocked early.

from a4-meinberlin.

2e2a avatar 2e2a commented on June 19, 2024

The current limit in django is 5M, in the webserver 10M.

Whereas we could increase the webserver limit, the disadvantage is that the image has to be fully uploaded before the django error is shown. The webserver error is shown directly.

from a4-meinberlin.

2e2a avatar 2e2a commented on June 19, 2024

@rukala Can we close this issue? Or should we change the limits?

from a4-meinberlin.

rittermo avatar rittermo commented on June 19, 2024

I would like to re-open this issue. I think we need to increase the nginx filesize limit and then think about (i.e. write a US) how we could validate the filesize documents to be uploaded via JS, no?

from a4-meinberlin.

rmader avatar rmader commented on June 19, 2024

I just set the nginx filesize limit to 20mb on all a4 instances. I'm rather reluctant to increase it further as that opens the door for DDOS things/makes it easier.

File size check seems to be easy, though, here is an example

from a4-meinberlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.