liquidz/build.edn

Make your Clojure library build process easy.

build.edn's Issues

set-output command is deprecated

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Use org.clojure/tools.build and deploy to clojars

https://mvnrepository.com/artifact/org.clojure/tools.build

Replace actions/create-release

https://github.com/actions/create-release is already deprecated and it uses set-output.

Collect scm information automatically

Leiningen does not have scm, but pom.xml generated by lein pom have a scm section

Add clean task

First off, this lib is awesome.

My request is to add a clean task, which deletes the target folder and all ephemeral folders/files created by the build.

Organize variable names

[readme] Clojure CLI tools install not used

The readme instructions for Clojure CLI show installing the tool using a :build alias. However the deploy command also uses the :build alias, -T:build rather than calling the installed tool, -Tbuild

Is the deploy command incorrect, or does the tool not need to be installed (I assume the former)

Thank you

bump minor and major don't set the other versions to 0

I noticed that clojure -T:build bump-minor-version and clojure -T:build bump-major-version don't reset the other version to 0 as per sem-ver.

So if the current version is 1.2.1 and you do clojure -T:build bump-minor-version it sets the version to 1.3.1 instead of 1.3.0 as it should. Similarly, if you you do clojure -T:build bump-major-version it sets the version to 2.3.1 instead of 2.0.0 as it should.

Add description to pom.xml

Credential management

The current implementation of build.edn relies on environment variables for clojars credentials. One thing I found pretty useful in lein is the gpg encrypted credential.clj, with which I can avoid to expose my password in plain text in environment variables. It would be nice to have similar support in build.edn to smooth deployment workflow at local.

Error building classpath. Library com.github.liquidz/build.edn has sha and tag that point to different commits

I'm getting this error after copying code from README. It seems the correct sha is b276908. I assume the README is automatically updated so there might be a bug in recent versions about replacing previous version.

Schema maintenance

• :jar-file -> :jar {:file ...}
• :uber-file -> :uberjar {:file ...}
• :main -> :uberjar {:main ...}
• :deploy-repository -> :deploy {:repository ...}

source-dir is not used

• build.edn/src/build_edn/schema.clj

  Line 14 in 27cc730

  [:source-dir {:optional true} string?]

• build.edn/src/build_edn/core.clj

  Line 65 in 27cc730

  (or (:src-dirs config)

Enable to define configs in deps.edn?

e.g.

{:build.edn/config {...}
 :paths []
 :deps {}}

lint missed something that errored later

I ran clojure -T:build lint and got OK.

But when I ran clojure -T:build java-compile I got:

Execution error (ExceptionInfo) at build-edn.core/validate-config! (core.clj:40).
Invalid config: {:java-paths ["missing required key"]}

Full report:

{:clojure.main/message
 "Execution error (ExceptionInfo) at build-edn.core/validate-config! (core.clj:40).\nInvalid config: {:java-paths [\"missing required key\"]}\n",
 :clojure.main/triage
 {:clojure.error/class clojure.lang.ExceptionInfo,
  :clojure.error/line 40,
  :clojure.error/cause
  "Invalid config: {:java-paths [\"missing required key\"]}",
  :clojure.error/symbol build-edn.core/validate-config!,
  :clojure.error/source "core.clj",
  :clojure.error/phase :execution},
 :clojure.main/trace
 {:via
  [{:type clojure.lang.ExceptionInfo,
    :message
    "Invalid config: {:java-paths [\"missing required key\"]}",
    :data {:java-paths ["missing required key"]},
    :at
    [build_edn.core$validate_config_BANG_
     invokeStatic
     "core.clj"
     40]}],
  :trace
  [[build_edn.core$validate_config_BANG_ invokeStatic "core.clj" 40]
   [build_edn.core$validate_config_BANG_ invoke "core.clj" 34]
   [build_edn.core$java_compile invokeStatic "core.clj" 136]
   [build_edn.core$java_compile invoke "core.clj" 131]
   [build_edn.main$java_compile invokeStatic "main.clj" 36]
   [build_edn.main$java_compile invoke "main.clj" 31]
   [clojure.lang.Var invoke "Var.java" 384]
   [clojure.run.exec$exec invokeStatic "exec.clj" 89]
   [clojure.run.exec$exec invoke "exec.clj" 78]
   [clojure.run.exec$_main$fn__220 invoke "exec.clj" 228]
   [clojure.run.exec$_main invokeStatic "exec.clj" 224]
   [clojure.run.exec$_main doInvoke "exec.clj" 192]
   [clojure.lang.RestFn applyTo "RestFn.java" 137]
   [clojure.lang.Var applyTo "Var.java" 705]
   [clojure.core$apply invokeStatic "core.clj" 667]
   [clojure.main$main_opt invokeStatic "main.clj" 514]
   [clojure.main$main_opt invoke "main.clj" 510]
   [clojure.main$main invokeStatic "main.clj" 664]
   [clojure.main$main doInvoke "main.clj" 616]
   [clojure.lang.RestFn applyTo "RestFn.java" 137]
   [clojure.lang.Var applyTo "Var.java" 705]
   [clojure.main main "main.java" 40]],
  :cause "Invalid config: {:java-paths [\"missing required key\"]}",
  :data {:java-paths ["missing required key"]}}}

Specify license in build.edn

If I understand correctly there is no way at the moment to specify license information in build.edn, which will be in generated pom.

As clojars requires license in pom in 2024, it would be nice to be able to do that with build.edn