littlepeng/redis-monitor

monitor redis perfmonance、master-slave status

redis-monitor's Issues

Use redis-py has error

I used pip install -r requirements.txt to install python packages, the default redis-py is 3.0.1.
when i start python redis_monitor.py, some error happened

2019-01-31 13:17:39.020112
Traceback (most recent call last):
  File "redis_monitor.py", line 88, in run
    self.LogInfo(redis_info, current_time, self.last)
  File "redis_monitor.py", line 185, in LogInfo
    expired, evicted, hit_rate, commands, used_memory, peak_memory)
  File "/usr/local/redis-monitor/src/dataprovider/redisprovider.py", line 33, in save_keys_Info
    self.conn.zadd(server +':'+ rediskey, score, data)
  File "/usr/lib/python2.7/site-packages/redis/client.py", line 2263, in zadd
    for pair in iteritems(mapping):
  File "/usr/lib/python2.7/site-packages/redis/_compat.py", line 94, in iteritems
    return x.iteritems()
AttributeError: 'int' object has no attribute 'iteritems'

then I found redis-py 3.xx had some changes https://github.com/andymccurdy/redis-py#mset-msetnx-and-zadd

def mset(self, mapping):
def msetnx(self, mapping):
def zadd(self, name, mapping, nx=False, xx=False, ch=False, incr=False):

so, we need do some compatible or prompt user to install redis-py 2.x version?

Error 500 when add multi redis intance

Hi LittlePeng!
I build tool redis-monitor from your source , first I add 30 instance , result working OK, then I add about 100 redis instance , result server response status 500 loading (tab Overview).
Can you help me fix error 500?

This is debug log file get 500 error
Traceback (most recent call last):
File "/usr/lib64/python2.6/site-packages/tornado/web.py", line 1467, in _execute
result = method(*self.path_args, **self.path_kwargs)
File "/build/redis-monitor/api/controller/InfoListController.py", line 16, in get
info=self.getStatsPerServer((server['server'],server['port']))
File "/build/redis-monitor/api/controller/BaseController.py", line 30, in getStatsPerServer
slaves += info["slave" + (str)(i)]
TypeError: cannot concatenate 'str' and 'dict' objects

redis_live.conf line end character

I found the line end character is ^M on linux(ubuntu) . We know dos2unix or unix2dos tool but it has better to update this . Actually some linux distributions have no dos2unix default .

StatServer config doesnt accept password

providing a password for stats server block is unrecognized.

403 error

when i visit the url http://ip:8888/, i met with difficulties about '403: Forbidden'。and how can i see the log? where is the log path? when run daemon

How to make chart widget display English?

I don't find the place to replace morning / afternoon Chinese language in the time series widget. Could you help? Thanks a lot!

AttributeError: 'int' object has no attribute 'iteritems'

Traceback (most recent call last):
File "redis_monitor.py", line 88, in run
self.LogInfo(redis_info, current_time, self.last)
File "redis_monitor.py", line 185, in LogInfo
expired, evicted, hit_rate, commands, used_memory, peak_memory)
File "/kuyu/soft/redis-monitor-master/src/dataprovider/redisprovider.py", line 33, in save_keys_Info
self.conn.zadd(server +':'+ rediskey, score,data)
File "/usr/lib/python2.7/site-packages/redis/client.py", line 2685, in zadd
for pair in iteritems(mapping):
File "/usr/lib/python2.7/site-packages/redis/_compat.py", line 133, in iteritems
return x.iteritems()
AttributeError: 'int' object has no attribute 'iteritems'

What happened?

sms alert

who can tell me how to use the sms alert,and "sms_alert": "192.168.110.207:9999" in the redis_live.conf use for what?

when i run python redis_monitor.py it reports [Errno 111] Connection refused

[root@bigdata239 src]# python redis_monitor.py --duration 120
add 10.110.17.238:7001
add 10.110.17.237:7002
add 10.110.17.236:7002
add 10.110.17.238:7002
add 10.110.17.236:7000
add 10.110.17.238:7000
add 10.110.17.237:7001
add 10.110.17.236:7001
add 10.110.17.237:7000
[redis]PRSOnline-M2(10.110.17.237:7002):slave status OK.({'ip': '10.110.17.238', 'state': 'online', 'lag': 0, 'port': 7000, 'offset': 517035})
[Errno 111] Connection refused
[redis]PRSOnline-M4(10.110.17.238:7002):slave status OK.({'ip': '10.110.17.236', 'state': 'online', 'lag': 0, 'port': 7001, 'offset': 516811}{'ip': '10.110.17.237', 'state': 'online', 'lag': 1, 'port': 7000, 'offset': 516797})
[Errno 111] Connection refused
[redis]PRSOnline-M4(10.110.17.238:7002):slave status OK.({'ip': '10.110.17.236', 'state': 'online', 'lag': 0, 'port': 7001, 'offset': 516811}{'ip': '10.110.17.237', 'state': 'online', 'lag': 1, 'port': 7000, 'offset': 516811})
[Errno 111] Connection refused
[redis]PRSOnline-Master1(10.110.17.238:7001):slave status OK.({'ip': '10.110.17.236', 'state': 'online', 'lag': 1, 'port': 7000, 'offset': 516811})
[Errno 111] Connection refused
[redis]PRSOnline-M3(10.110.17.236:7002):slave status OK.({'ip': '10.110.17.237', 'state': 'online', 'lag': 0, 'port': 7001, 'offset': 516825})
[Errno 111] Connection refused
[redis]PRSOnline-M2(10.110.17.237:7002):slave status OK.({'ip': '10.110.17.238', 'state': 'online', 'lag': 0, 'port': 7000, 'offset': 517049})
[Errno 111] Connection refused

when I visit http://myip:8888/index.html, it return for me 404

Hi, Peng. Thanks for your great work, and I have a problem when I visit http://myip:8888/index.html. It return "404: Not Found" for me. Can you help me to resolve it?

AttributeError: 'RedisStatsProvider' object has no attribute 'save_keys_Info'

2015-07-10 13:39:15.183334
Traceback (most recent call last):
File "redis_monitor.py", line 89, in run
self.LogInfo(redis_info, current_time, self.last)
File "redis_monitor.py", line 185, in LogInfo
self.stats_provider.save_keys_Info(self.id, last.key , current_time, expires, persists,
AttributeError: 'RedisStatsProvider' object has no attribute 'save_keys_Info'