liupold/fmdpy

music downloader written in python. (Uses jiosaavn API)

Hi 👋, I'm Liupold

A passionate tinkerer.

• 🔭 I’m currently working on ____________.

Languages and Tools:

fmdpy's Issues

Gracefully exit after fmdpy prompt

Wondering what is the best way to gracefully exit after the fmdpy: prompt. Otherwise, anything that you enter after the fmdpy gives some error

fmdpy: asldkfjalsdkfjal;sdfjlas
Traceback (most recent call last):
  File "/home/arsaboo/.local/bin/fmdpy", line 8, in <module>
    sys.exit(fmdpy())
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/fmdpy/__main__.py", line 121, in fmdpy
    c_pool.append(int(indx)-1)
ValueError: invalid literal for int() with base 10: 'asldkfjalsdkfjal;sdfjlas'

URL download is broken - Unknown . cmd

Entering the URL returns Unknown . cmd

fmdpy (v0.6.3)-> https://www.jiosaavn.com/album/XYZ
Unknown . cmd: https://www.jiosaavn.com/album/XYZ

Missing prompt documentation

Prompt documentation must be added before the 0.7 release.
The prompt now supports the following :

Operators:
{}, {}-{}, {}:{}: Will download the songs from the list.
{}.p, {}-{}.p, {}:{}.p: Will stream the songs from the list.
{}.l: will show the lyrics

Commands:
.conf : show the config (priority: command line > config file > default)
.ls: show the current song list.
.save {name}: save the current song list.
.lsave: list all the saved song list.
.load {name}: load the saved song list.

Command which may be added:
.cls or .clear: clears the screen
.del {name}: delete a saved song list.
.set {option} {value}: on the fly config update.
.gen: write the current config to config file.
{}.i: show the info of the song.
{}.u: show download url of the song.
{}.t: show the thumbnail url of the song.

fmt = mp3 not working

On one of my machines, fmt --mp3 (both using the command line parameters or the config file) is not working. If I keep fmt = native, I get an mp4 file. However, no output is produced when I use fmt = mp3. I reinstalled FFmpeg and even manually tried the conversion (which works).

Any thoughts on how I may debug this?

Looks like API changed

Getting this error:

Traceback (most recent call last):
  File "/home/arsaboo/.local/lib/python3.10/site-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/arsaboo/.local/bin/fmdpy", line 8, in <module>
    sys.exit(fmdpy())
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/fmdpy/__main__.py", line 112, in fmdpy
    song_list = find_songs(search, count)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/fmdpy/prompt.py", line 22, in find_songs
    song_list = query(search_str, count)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/fmdpy/api.py", line 94, in query
    return query_songs_search(query_string, max_results)
  File "/home/arsaboo/.local/lib/python3.10/site-packages/fmdpy/api.py", line 58, in query_songs_search
    return parse_query(req.json())
  File "/home/arsaboo/.local/lib/python3.10/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Accept URL as input

Instead of searching, I was wondering if we can add a feature to directly provide a URL. The search is not perfect.

fmdpy broken

Looks like fmdpy is broken at the moment. It only returns small files (not audio files) and then ffmpeg returns an error.

is it OK for these to be public?

fmdpy/fmdpy/splist.py

Line 35 in ac38dae

client_id="694d8bf4f6ec420fa66ea7fb4c68f89d",

Track listing should start from 1 and not from 0

Currently, the search results start from 0. I think for the users, it should start from 1.