liyuewang-zz/serverless-plugin-custom-binary

serverless-plugin-custom-binary

This is a plugin for Serverless that sets up BinaryMediaTypes and ContentHandling to enable support for Binary Payloads in API Gateway.

Usage

service: my-service

plugins:
  - serverless-plugin-custom-binary

custom:
  apiGateway:
    binaryMediaTypes:
      - 'application/json'

functions:
  helloword:
    handler: handler.hello
    events:
      - http:
        path: /hello
        method: GET
        contentHandling: CONVERT_TO_BINARY

Notes

Several other plugins exist but now CloudFormation appears to support configuring these properties directly. The other plugins make sure of API calls that create race conditions or otherwise complicate deployments.

serverless-plugin-custom-binary's Issues

Issue with Response Headers

I have the below config

events:
      - http:
          path: example/message
          method: get
          integration: lambda
          contentHandling: CONVERT_TO_BINARY
          response:
            statusCodes:
              200:
                pattern: '' # Default response method
                headers:
                  Content-Type: "'application/pdf'"

The value of response headers "Content-Type" is getting removed from integration response - response headers, if I provide a value for "contentHandling". Tested with out "contentHandling" and its working fine.

Doesn't work with Lambda Proxy

Unless I'm mistaken, this wont work with Lambda Proxy integration as there is no IntegrationResponse to add contentHandling to.

Is this correct? If yes, possibly a note in the readme would help. Spent a good day stuck on this one..

Separate getDeploymentId from add depends on?

This is somewhat of a nitpick

https://github.com/LiyueWang/serverless-plugin-custom-binary/blob/645ca1c92b5e004691599d07691c5e1f6f763c7f/lib/utils.js#L23

Re-using object from outer scope

Should this be the case?

https://github.com/LiyueWang/serverless-plugin-custom-binary/blob/645ca1c92b5e004691599d07691c5e1f6f763c7f/lib/utils.js#L13

I would think const integrationResponse ={} inside the loop?