llvm-fortran/libfortrt

Runtime library for Fort compiler

libfortrt's Issues

lentrim misses trailing spaces

lentrim seems to return the position of the last whitespace character rather than the opposite:

template<typename T>
static size_t lentrim(const CharacterValue<T> String) {
  for(size_t I = String.Length; I > 0; I--) {
    if(isWhitespace(String.Ptr[I-1])) return I;
  }
  return String.Length;
}

This is relatively easy to reproduce with a test that would use it.

Implement lexcompare

Fort emits calls to lexcompare, but that always returns 0:

template<typename T>
static int32_t lexcompare(const CharacterValue<T> LHS,
                          const CharacterValue<T> RHS) {
  return 0;//FIXME
}

lexcompare is produced when two strings are compared usind .lt., .gt., and so on. In Fortran that requires padding shorter string with spaces before comparison.

isWhitespace only handles ' ' character

isWhilespace implementation looks like this:

static bool isWhitespace(uint32_t C) {
  return C == ' '; //FIXME
}

This would not handle any whitespace characters other than a simple space.